Repository navigation
Conversation
moetemp
changed the title
moetemp
changed the title
moetemp
changed the base branch from
moe/up/resource-method-record-result
to
moe/up/dotnet-resource-property-name-2
October 23, 2026 01:32
moetemp
changed the title
Owner
Author
|
Opened upstream as temporalio#273. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the
stream-servicesample for Python, TypeScript and .NET, with today's output. It is the shape that a stream API needs:streamresource built from astream-refrecord, withappend-records,close,read-recordsanddescribe.from-offset,next-offsetanddone, and payload and duration fields.create-streamoperation that returns the resource.Why?
Later fixes show their effect as a golden diff on this sample.
How did you test it?
The goldens only.
This PR is based on fork PR #66 (on #61). A stub fails the Python checks, and the
streamfield of thestreamresource needs the .NET fix.