[Brook] feat: generate resource classes for WIT resources in all targets by moetemp · Pull Request #45 · moetemp/nexgen

moetemp · 2026-10-22T07:29:13Z

What changed?

This PR fits nexgen's resources to the Brook Stream and Writer handles. It merges the upstream PRs #48 to #53, #56 and #57. Fork-only:

@nexus.client-only, for the Brook writer's in-process call surface.
iter_<method> on a Workflow resource for a long poll over offsets.
The proto enum module import, until upstream settles proto enum typing.
@nexus.doc on the client resource classes.

Why?

Decisions S84 to S87: the Stream and Writer handles come from the IDL, reads are an iterator, handles are immutable values, and the writer is a client-only WIT interface.

How did you test it?

tests/wit_streaming.rs checks the Workflow resource iterator and a client-only service.

A required method parameter after an optional one makes the method keyword-only, lists default to empty, enum parameters import their proto module, and a required resource field from the response is checked.

The caller gets iter_<operation>, and a bound resource method gets iter_<method>. No wire type changes, since a WIT stream cannot cross a Nexus call.

The resource binds from the record's message, the other fields come from the same message, and the message travels as a wire record named after it.

…ngs.

The caller takes a data_converter, and the payloads and failures inside a proto-backed model go through its converters and codec, as in Workflow code.

A client-only service gets its caller and resource classes in client.py and no Workflow surface, for an in-process call surface such as the Stream writer.

A result record that holds a resource declares only what its caller sees, and the planned holder keeps its fields in order, for the other targets.

TypeScript, .NET and Go no longer refuse such a record. Java still does.

…ream-resource # Conflicts: # GUIDE.md

…n8-stream-resource

…ream-resource

# Conflicts: # tests/generate_typescript.rs # xtask/src/build_examples.rs

# Conflicts: # tests/generate_python.rs

# Conflicts: # advanced/samples/dotnet/wit/user-service/Models.cs # advanced/samples/dotnet/wit/user-service/Resources.cs # advanced/samples/dotnet/wit/user-service/Services.cs # advanced/samples/go/userservice/userservice.go # advanced/samples/inputs/user-service.wit # advanced/samples/python/tests/test_user_service.py # advanced/samples/python/wit/user_service/__init__.py # advanced/samples/python/wit/user_service/_resources/user.py # advanced/samples/python/wit/user_service/models.py # advanced/samples/python/wit/user_service/services.py # advanced/samples/typescript/tests/user-service.test.ts # advanced/samples/typescript/wit/user-service/index.ts # advanced/samples/typescript/wit/user-service/models.ts # advanced/samples/typescript/wit/user-service/resources.ts # advanced/samples/typescript/wit/user-service/services.ts # src/generator/python.rs # tests/generate_python.rs

# Conflicts: # advanced/samples/inputs/examples.toml

# Conflicts: # advanced/samples/README.md # advanced/samples/inputs/examples.toml # xtask/src/build_examples.rs

# Conflicts: # advanced/samples/inputs/user-service.wit

moetemp · 2026-10-26T07:06:37Z

Closed in favor of the review chain. Its two remaining parts are #57 (the client resource docstrings) and #74 (@nexus.client-only), on top of the rebased [UPSTREAM-*] PRs (plan: Brook: code review and upstream plan). The branch stays, since the superproject's prototype pin 204b566e is on it.

Fitted Python resource methods to a handle that carries a record.

de0c7ed

A required method parameter after an optional one makes the method keyword-only, lists default to empty, enum parameters import their proto module, and a required resource field from the response is checked.

moetemp mentioned this pull request Oct 22, 2026

[Brook] Declared the Stream handle as a WIT resource with methods. moetemp/sdk-streams#32

Closed

Read a long poll over offsets as one async iterator in Python.

aff8ff8

The caller gets iter_<operation>, and a bound resource method gets iter_<method>. No wire type changes, since a WIT stream cannot cross a Nexus call.

moetemp mentioned this pull request Oct 22, 2026

[Brook] fix(wit): map WIT s64 and u64 to 64-bit integers #46

Closed

moetemp added 4 commits October 22, 2026 01:08

Let a Python result record hold a resource in an own<T> field.

655dd04

The resource binds from the record's message, the other fields come from the same message, and the message travels as a wire record named after it.

Carried @nexus.doc on resources and their methods into Python docstri…

35bafa3

…ngs.

Added Python client resource classes over the data converter.

10fc35b

The caller takes a data_converter, and the payloads and failures inside a proto-backed model go through its converters and codec, as in Workflow code.

Added @nexus.client-only services and client resource returns.

93d1279

A client-only service gets its caller and resource classes in client.py and no Workflow surface, for an in-process call surface such as the Stream writer.

moetemp mentioned this pull request Oct 22, 2026

[Brook] Added the writer calls as a client-only WIT interface. moetemp/sdk-streams#33

Closed

moetemp added 9 commits October 22, 2026 01:40

Dropped the low-value resource and long-poll tests.

6bfe4be

Moved Python result records beside their resource for any target.

b71056b

A result record that holds a resource declares only what its caller sees, and the planned holder keeps its fields in order, for the other targets.

Built result records that hold a resource in .NET.

a987529

Built result records that hold a resource in TypeScript.

aa57013

Built result records that hold a resource in Go.

84616d6

Added the workflow-run sample for result records that hold a resource.

fcb29cf

TypeScript, .NET and Go no longer refuse such a record. Java still does.

Skipped docstrings when Python picks the names to import.

204b566

Built the .NET workflow-run sample in its own project.

3e815d8

Named a model in the workflow-run resource doc to cover the import scan.

7249af4

moetemp changed the title ~~[Brook] Generated Python resource classes for WIT resources with methods.~~ [Brook] Generated resource classes for WIT resources in all targets. Oct 22, 2026

moetemp added 11 commits October 22, 2026 11:16

Made Python resource methods valid for any WIT parameter order.

5d11c1a

Skipped docstrings when Python picks the names to import.

8edc850

Checked required resource fields from a response in Python and .NET.

3eb0d91

Let a result record hold a resource in an own<T> field in Python.

499a886

Built result records that hold a resource in .NET.

c91fa20

Built result records that hold a resource in TypeScript.

80b1e8e

Built result records that hold a resource in Go.

bf43247

Added the workflow-run sample for result records that hold a resource.

0638bbd

Built the returned resource on the TypeScript System Nexus path.

17b80cc

Emitted @nexus.doc on resources and methods as Python docstrings.

87decdb

Took undefined for optional TS params before a required one.

5ff3a4b

moetemp added 27 commits October 22, 2026 13:12

Reworded the holder comments and dropped the per-language tests.

cd6ed52

Merge branch 'moe/up/long-poll' into moe/up/python-client-resources

72531b2

Merge branch 'moe/brook/v3/n7-long-poll-loop' into moe/brook/v3/n8-st…

1bdb682

…ream-resource # Conflicts: # GUIDE.md

Merge branch 'moe/up/result-record-holds-resource' into moe/brook/v3/…

8b315a1

…n8-stream-resource

Merge branch 'moe/up/python-client-resources' into moe/brook/v3/n8-st…

33ba200

…ream-resource

Reworded the proto enum import comments.

151f64b

Generated the TypeScript start-workflow sample with System Nexus on.

2847136

Showed the required response field guard in the start-workflow sample.

16dac7a

Merged the TypeScript parameter order fix for the user-service sample.

2211089

Showed the keyword-only resource method in the user-service sample.

cb48c92

Merged the TypeScript System Nexus sample into the result record branch.

a76a0ed

Merged the System Nexus sample and result record branches.

c1d9a0a

# Conflicts: # tests/generate_typescript.rs # xtask/src/build_examples.rs

Merged the user-service sample for keyword-only resource methods.

f925205

# Conflicts: # tests/generate_python.rs

Passed a required resource field to an optional Go field as a pointer.

034a4f3

Merged the Go resource field pointer fix.

aed1e08

Dropped the TypeScript unit test that the user-service golden replaces.

18c21ea

Merged the resource parameter order golden.

f12f114

Indented the docstrings of Python caller methods.

3510b22

Moved the System Nexus resource example to its own TypeScript sample.

6d18335

Wrapped the workflow-handle README line.

3d5a633

Merged the TypeScript workflow-handle sample.

794ca6a

# Conflicts: # advanced/samples/inputs/examples.toml

Merged the workflow-handle sample and result record branches.

736400a

# Conflicts: # advanced/samples/README.md # advanced/samples/inputs/examples.toml # xtask/src/build_examples.rs

Merged the Python caller docstring indent fix.

81c074f

# Conflicts: # advanced/samples/inputs/user-service.wit

Set the required flag in the request plan unit test.

e14cdfe

Merged the request plan unit test fix.

35fb959

Merged the request plan unit test fix.

ee961f1

moetemp mentioned this pull request Oct 25, 2026

[UPSTREAM-16] feat(python): add @nexus.client-only #74

Closed

moetemp closed this Oct 26, 2026

Navigation Menu

Repository navigation

[Brook] feat: generate resource classes for WIT resources in all targets - #45

[Brook] feat: generate resource classes for WIT resources in all targets#45
moetemp wants to merge 67 commits into
moe/brook/v3/n7-long-poll-loopfrom
moe/brook/v3/n8-stream-resource

moetemp commented Oct 22, 2026 •

edited

Loading

Uh oh!

moetemp commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

moetemp commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed?

Why?

How did you test it?

Uh oh!

moetemp commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

moetemp commented Oct 22, 2026 •

edited

Loading