Skip to content

[Brook] fix(wit): map WIT s64 and u64 to 64-bit integers - #46

Closed
moetemp wants to merge 30 commits into
moe/brook/v3/n8-stream-resourcefrom
moe/brook/v3/n9-dotnet-s64
Closed

moetemp wants to merge 30 commits into
moe/brook/v3/n8-stream-resourcefrom
moe/brook/v3/n9-dotnet-s64

Conversation

@moetemp

@moetemp moetemp commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

What changed?

This PR maps WIT s64 and u64 to 64-bit integers for WIT-only types. It merges #47, the upstream version.

Why?

The Brook Stream methods typed sequence and failed-tasks as int in .NET.

How did you test it?

Covered by #47.

@moetemp moetemp changed the title [Brook] Planned WIT s64 and u64 as 64-bit integers. [Brook] Mapped WIT s64 and u64 to 64-bit integers. Oct 22, 2026
@moetemp moetemp changed the title [Brook] Mapped WIT s64 and u64 to 64-bit integers. [Brook] Map WIT s64 and u64 to 64-bit integers Oct 22, 2026
@moetemp moetemp changed the title [Brook] Map WIT s64 and u64 to 64-bit integers fix(brook): map WIT s64 and u64 to 64-bit integers Oct 22, 2026
@moetemp moetemp changed the title fix(brook): map WIT s64 and u64 to 64-bit integers [Brook] fix(wit): map WIT s64 and u64 to 64-bit integers Oct 22, 2026
@moetemp

moetemp commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

Closing as superseded. Upstream temporalio#265 keeps the size and sign of WIT integers. Plan: https://www.notion.so/4048fc567738814990b7c796ac28fe3f

@moetemp moetemp closed this Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant