Skip to content

test: add a stream-service sample with a resource built from a ref - #274

Merged
moetemp merged 2 commits into
mainfrom
moe/up/stream-service-sample
Oct 23, 2026
Merged

moetemp merged 2 commits into
mainfrom
moe/up/stream-service-sample

Conversation

@moetemp

@moetemp moetemp commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

What changed?

This PR adds a stream-service sample for Python and TypeScript, with today's output. #272 adds .NET with its fix. It has a stream resource built from a ref, create-stream, append, read, describe and close, with 64-bit offsets, payloads and durations.

Its records are proto-backed, as a stream service's are. Upstream has no stream protos, so the sample has its own small proto in descriptors/streamsample/v1/, with checked-in bindings. The samples README has the commands that regenerate them. build_examples now loads every *.bin under descriptors/.

Why?

Later fixes show their effect as a golden diff on this sample.

How did you test it?

The goldens. A TypeScript test sends a full ReadRecordsRequest through the converter, so the TypeScript type file can't drift from the proto.

What comes next

These fixes are ready, in this order. Each one adds its shape to this sample, then the fix.

#262 adds a status enum to the holder record once it merges.

@moetemp
moetemp requested a review from a team as a code owner October 23, 2026 08:54
@moetemp moetemp added the skip-changelog No user-facing changelog fragment required label Oct 23, 2026
Comment thread xtask/src/build_examples.rs Resolved
Comment thread validation-tests/tests/dotnet.rs Resolved
@moetemp
moetemp force-pushed the moe/up/stream-service-sample branch from 39d2f20 to c4f0743 Compare October 23, 2026 18:51
@moetemp
moetemp enabled auto-merge (squash) October 23, 2026 18:53
@moetemp
moetemp disabled auto-merge October 23, 2026 19:02
@moetemp
moetemp merged commit cf18dc9 into main Oct 23, 2026
5 checks passed
@moetemp
moetemp deleted the moe/up/stream-service-sample branch October 23, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog No user-facing changelog fragment required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants