Repository navigation
test: make example descriptors opt-in - #277
Merged
Merged
Conversation
The doc comment said examples match the fixtures, but their default was the opposite.
tconley1428
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR makes the
descriptorskey ofadvanced/samples/inputs/examples.tomlopt-in, as in the compiler rejection fixtures. An example with nodescriptorsgets no descriptor set. The seven examples that need the Temporal set saydescriptors = "temporal". A list still names files inadvanced/samples/descriptors/, since an example has no case directory.Why?
#274 said example descriptors had the same shape as the fixtures, but its default was the opposite. Examples got
temporal_api.binunless they listed something else.How did you test it?
cargo build-examplesleaves every generated file as it is on main. The five other examples build the same output with no descriptor set.