Skip to content

fix(deps): update msgpack for security fix - #551

Closed
TeoSlayer wants to merge 1 commit into
mlcommons:mainfrom
TeoSlayer:fix/msgpack-update
Closed

TeoSlayer wants to merge 1 commit into
mlcommons:mainfrom
TeoSlayer:fix/msgpack-update

Conversation

@TeoSlayer

@TeoSlayer TeoSlayer commented Oct 28, 2026 •

Copy link
Copy Markdown

Require msgpack>=1.2.3 and lock 1.2.4. This fixes the CI audit for CVE-2026-114613.

Checks: audit passes with the existing NLTK exception; wheel builds. 2,233 unit tests pass; 27 skip. macOS has one base test failure and three base type errors. Linux mypy and other hooks pass.

CI has a base timeout failure. Review requests lack fork permission.

@github-actions

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@arekay-nv arekay-nv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TeoSlayer - this can go in while we fix the CI issues.

@arekay-nv
arekay-nv requested a review from nv-alicheng November 2, 2026 18:35
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@4b385eb). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage        ?   81.37%           
=======================================
  Files           ?      157           
  Lines           ?    22472           
  Branches        ?        0           
=======================================
  Hits            ?    18286           
  Misses          ?     4186           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arekay-nv

Copy link
Copy Markdown
Collaborator

Thanks @TeoSlayer for putting this up. As the PR isn't ready to be merged, we will consolidate the changes in #557 which also fixes addresses other CVE to unblock PRs on main.

@TeoSlayer

Copy link
Copy Markdown
Author

Thanks for consolidating this into #557. That fix has merged, so this PR is superseded.

@TeoSlayer TeoSlayer closed this Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/normal PR Review Policy: <=500 non-test lines & <=20 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants