Skip to content

fix: retain session start in metrics reports - #549

Draft
TeoSlayer wants to merge 4 commits into
mlcommons:mainfrom
TeoSlayer:fix/session-start
Draft

TeoSlayer wants to merge 4 commits into
mlcommons:mainfrom
TeoSlayer:fix/session-start

Conversation

@TeoSlayer

@TeoSlayer TeoSlayer commented Oct 28, 2026 •

Copy link
Copy Markdown

Carry the monotonic session start through live snapshots, final JSON, and reports so elapsed-time reporting uses the actual session origin. Append the optional snapshot field to preserve older array-encoded messages; missing timestamps keep the existing zero fallback. Refs #463.

Tests cover live, complete, interrupted, and older snapshots. Synced with upstream dependency/watchdog fixes, with session startup synchronized in the SIGINT test. Full Linux CI passes.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

MLCommons CLA bot:
Thank you very much for your submission; we really appreciate it. Before we can accept your contribution,
we ask that you sign the MLCommons CLA (Apache 2). Please submit your GitHub ID to our onboarding form to initiate
authorization. If you are from a MLCommons member organization, we will request that you be added to the CLA.
If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact
support@mlcommons.org.
1 out of 2 committers have signed the MLCommons CLA.
✅ @TeoSlayer
❌ @teovl
You can retrigger this bot by commenting recheck in this Pull Request

@github-actions github-actions Bot added the size/normal PR Review Policy: <=500 non-test lines & <=20 files label Oct 28, 2026
@codecov-commenter

codecov-commenter commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@745ac91). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage        ?   82.66%           
=======================================
  Files           ?      170           
  Lines           ?    24334           
  Branches        ?        0           
=======================================
  Hits            ?    20115           
  Misses          ?     4219           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TeoSlayer

TeoSlayer commented Nov 5, 2026 •

Copy link
Copy Markdown
Author

Verified session starts survive live/final snapshots and older snapshots remain readable. All CI checks pass.

# Conflicts:
#	tests/integration/commands/test_sigint.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/normal PR Review Policy: <=500 non-test lines & <=20 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants