Repository navigation
fix(deps): update nltk, msgpack, and virtualenv for security fixes - #557
Merged
arekay-nv merged 1 commit intoNov 3, 2026
Merged
Conversation
- nltk 3.10.3 -> 3.10.4 (CVE-2026-81726 / PYSEC-2026-3740, GHSA-j456-xh4h-cpf2) - msgpack 1.2.1 -> 1.2.3 (CVE-2026-114613); pinned in the dev extra since it is pulled in transitively via pip-audit -> cachecontrol - virtualenv 21.14.10 -> 21.14.13 (CVE-2026-115586) nltk 3.10.4 fixes PYSEC-2026-3740, so drop the pip-audit ignore from the CI audit job, AGENTS.md, and docs/DEVELOPMENT.md. Closes mlcommons#520 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #557 +/- ##
=======================================
Coverage ? 81.37%
=======================================
Files ? 157
Lines ? 22472
Branches ? 0
=======================================
Hits ? 18286
Misses ? 4186
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps the three root-lock packages that have open Dependabot alerts with a
fixed release available in the
dev/testtooling extras, and drops thenltk
pip-auditignore now that a fixed nltk release has shipped.rougepin (viatest)pip-audit->cachecontrol)devpin, plus pre-commitChanges
pyproject.toml:nltk==3.10.4(rouge),virtualenv==21.14.13(dev),and a new
devpinmsgpack==1.2.3next to the existingpip==26.2pin,which covers the same
pip-auditdependency chain. The pin (rather than a[tool.uv] constraint-dependenciesfloor) means pip installs get the fix too.uv.lock: relocked. The three versions above are the only changes; nopackages added or removed.
.github/workflows/test.yml,AGENTS.md,docs/DEVELOPMENT.md: drop--ignore-vuln PYSEC-2026-3740and the related notes. With nltk 3.10.4,pip-auditreports nothing, ignores or not.Out of scope
The remaining root-lock alerts are all in the
bfclresolution fork(bfcl-eval's old pins: pyasn1, datamodel-code-generator, filelock 3.20.0,
black, cryptography, dnspython, soupsieve, torch). The isolated subproject
locks (
swebench_service,legacy_mlperf_deepseek_r1, the WAN 2.2 accuracyexample) are also not touched here.
Type of change
Related issues
Closes #520
Supersedes #551, which fixes only msgpack (CVE-2026-114613) via a
[tool.uv] constraint-dependenciesfloor (msgpack>=1.2.3). This PRcarries the same msgpack fix as an exact
devpin, so pip installs get ittoo, and also covers nltk and virtualenv.
Testing
(
--extra dev --extra test --extra performance), then ranuv run pip-auditwith no ignores: no known vulnerabilities.uv lock --checkanduv pip check: all 143 installed packagescompatible.
RougeScorer(use_stemmer=True)smoke test on nltk 3.10.4;tests/unit/evaluation/test_accuracy_results.pypasses.-m "not slow and not performance") on macOS:2599 passed, 55 failed. All 55 are macOS-only (CPU affinity requires
Linux:
pin_loadgen() requires Linux, no/proc). The failing set isidentical with
main's lock, same as noted in fix(deps): update filelock, setuptools, and virtualenv for security fixes #546.Checklist
os.sched_setaffinityplatform errors in untouched files)🤖 Generated with Claude Code