Skip to content

fix: save datasets selected by run mode - #548

Draft
TeoSlayer wants to merge 5 commits into
mlcommons:mainfrom
TeoSlayer:fix/run-mode-config
Draft

TeoSlayer wants to merge 5 commits into
mlcommons:mainfrom
TeoSlayer:fix/run-mode-config

Conversation

@TeoSlayer

@TeoSlayer TeoSlayer commented Oct 28, 2026 •

Copy link
Copy Markdown

Saved report configs currently include datasets skipped by the requested run mode, so rerunning the saved YAML can invoke external accuracy evaluation that the original performance run never used. Persist the datasets the runtime selects: omit external accuracy scorers in performance mode, retain endpoint-backed accuracy datasets, and omit performance datasets in accuracy-only mode. The live config and credentials remain intact; saved credentials stay redacted.

Refs #420. All 188 benchmark-command tests pass, including six mode/scorer combinations, config round trips, redaction, and unchanged runtime credentials. The endpoint-backed performance case failed before the follow-up fix. Synced with upstream dependency/watchdog fixes; Linux CI validates the platform-specific checks.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

MLCommons CLA bot:
Thank you very much for your submission; we really appreciate it. Before we can accept your contribution,
we ask that you sign the MLCommons CLA (Apache 2). Please submit your GitHub ID to our onboarding form to initiate
authorization. If you are from a MLCommons member organization, we will request that you be added to the CLA.
If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact
support@mlcommons.org.
1 out of 2 committers have signed the MLCommons CLA.
✅ @TeoSlayer
❌ @teovl
You can retrigger this bot by commenting recheck in this Pull Request

@TeoSlayer

TeoSlayer commented Nov 5, 2026 •

Copy link
Copy Markdown
Author

Corrected the saved performance config to retain endpoint-backed accuracy datasets and omit only external accuracy scorers. All 188 benchmark-command tests and the complete Linux CI checks pass.

@codecov-commenter

codecov-commenter commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@745ac91). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage        ?   82.63%           
=======================================
  Files           ?      170           
  Lines           ?    24336           
  Branches        ?        0           
=======================================
  Hits            ?    20111           
  Misses          ?     4225           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/normal PR Review Policy: <=500 non-test lines & <=20 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants