Implement image save and export container by ptrivedi · Pull Request #14121 · microsoft/WSL

ptrivedi · 2026-01-28T05:04:56Z

No description provided.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

src/windows/wslaservice/exe/WSLASession.cpp

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 15 comments.

src/windows/wslaservice/exe/WSLASession.cpp

test/windows/WSLATests.cpp

src/windows/wslaservice/exe/WSLASession.cpp

test/windows/WSLATests.cpp

src/windows/wslaservice/inc/wslaservice.idl

test/windows/WSLATests.cpp

src/windows/wslaservice/exe/DockerHTTPClient.cpp

src/windows/wslaservice/exe/WSLASession.h

src/windows/wslaservice/exe/DockerHTTPClient.cpp

src/windows/wslaservice/exe/WSLAContainer.cpp

test/windows/WSLATests.cpp

src/windows/wslaservice/inc/wslaservice.idl

test/windows/WSLATests.cpp

Copilot · 2026-01-30T16:25:31Z

@ptrivedi I've opened a new pull request, #14130, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

test/windows/WSLATests.cpp

src/windows/wslaservice/inc/wslaservice.idl

test/windows/WSLATests.cpp

src/windows/wslaservice/exe/WSLASession.cpp

Copilot · 2026-01-30T20:52:12Z

@ptrivedi I've opened a new pull request, #14134, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-30T20:52:57Z

@ptrivedi I've opened a new pull request, #14135, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-30T20:53:24Z

@ptrivedi I've opened a new pull request, #14136, to work on those changes. Once the pull request is ready, I'll request review from you.

…om/microsoft/WSL into user/ptrivedi/saveimage-exportcont

src/windows/wslaservice/exe/DockerHTTPClient.cpp

* Consolidate SendRequest* methods * Enhance ExportContainer and the corresponding test for specific error code return when specified container is not found.

…om/microsoft/WSL into user/ptrivedi/saveimage-exportcont

OneBlue

Couple minor comments, can be done in a followup PR

src/windows/wslaservice/exe/WSLASession.cpp

test/windows/WSLATests.cpp

…rtcont

Implement image save and export container

c4a405c

ptrivedi requested a review from a team as a code owner January 28, 2026 05:04

ptrivedi requested review from OneBlue, benhillis, Copilot, craigloewen-msft and justus-camp-microsoft January 28, 2026 05:04

ptrivedi changed the base branch from master to feature/wsl-for-apps January 28, 2026 05:05

ptrivedi requested a review from a team as a code owner January 28, 2026 05:05

Copilot AI reviewed Jan 28, 2026

View reviewed changes

benhillis requested a review from Copilot January 28, 2026 17:01

Copilot started reviewing on behalf of benhillis January 28, 2026 17:02 View session

benhillis reviewed Jan 28, 2026

View reviewed changes

src/windows/wslaservice/exe/WSLASession.cpp Show resolved Hide resolved

benhillis reviewed Jan 28, 2026

View reviewed changes

src/windows/wslaservice/exe/WSLASession.cpp Show resolved Hide resolved

Copilot AI reviewed Jan 28, 2026

View reviewed changes

OneBlue requested changes Jan 28, 2026

View reviewed changes

Copilot AI mentioned this pull request Jan 30, 2026

Refactor SaveImageImpl and ExportContainerImpl to eliminate code duplication #14130

Draft

5 tasks

Apply suggestions from code review

324a914

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

benhillis requested a review from Copilot January 30, 2026 16:54

Copilot started reviewing on behalf of benhillis January 30, 2026 16:54 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

Copilot AI mentioned this pull request Jan 30, 2026

Fix IDL attribute spacing inconsistencies in SaveImage and ExportContainer #14134

Draft

5 tasks

Copilot AI mentioned this pull request Jan 30, 2026

Standardize parameter annotation spacing in wslaservice.idl #14135

Closed

5 tasks

Copilot AI mentioned this pull request Jan 30, 2026

Fix IDL attribute spacing inconsistencies in SaveImage and ExportContainer #14136

Closed

5 tasks

Pooja Trivedi added 2 commits January 30, 2026 17:50

Incorporate code review comments

386dab4

Merge branch 'wsl-for-apps' into user/ptrivedi/saveimage-exportcont

8cee4a4

Merge branch 'user/ptrivedi/saveimage-exportcont' of https://github.c…

682a779

…om/microsoft/WSL into user/ptrivedi/saveimage-exportcont

OneBlue reviewed Jan 30, 2026

View reviewed changes

src/windows/wslaservice/exe/DockerHTTPClient.cpp Outdated Show resolved Hide resolved

Pooja Trivedi added 3 commits February 2, 2026 10:38

Followup fixes

ae32b76

* Consolidate SendRequest* methods * Enhance ExportContainer and the corresponding test for specific error code return when specified container is not found.

Followup fixes

cd1108d

* Consolidate SendRequest* methods * Enhance ExportContainer and the corresponding test for specific error code return when specified container is not found.

Merge branch 'user/ptrivedi/saveimage-exportcont' of https://github.c…

c201e01

…om/microsoft/WSL into user/ptrivedi/saveimage-exportcont

ptrivedi force-pushed the user/ptrivedi/saveimage-exportcont branch from 2b3cadd to ac87c71 Compare February 2, 2026 19:32

Fix variable naming

3d2b37a

ptrivedi force-pushed the user/ptrivedi/saveimage-exportcont branch from ac87c71 to 3d2b37a Compare February 2, 2026 19:33

OneBlue approved these changes Feb 2, 2026

View reviewed changes

src/windows/wslaservice/exe/WSLASession.cpp Show resolved Hide resolved

test/windows/WSLATests.cpp Show resolved Hide resolved

ptrivedi and others added 3 commits February 2, 2026 15:20

Merge branch 'feature/wsl-for-apps' into user/ptrivedi/saveimage-expo…

cab18f9

…rtcont

Merge branch 'wsl-for-apps' into user/ptrivedi/saveimage-exportcont

f00e95b

Fix merge conflict

17f25e5

ptrivedi merged commit ca1bcc7 into feature/wsl-for-apps Feb 4, 2026
6 checks passed

ptrivedi deleted the user/ptrivedi/saveimage-exportcont branch February 4, 2026 00:05

Conversation

ptrivedi commented Jan 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 30, 2026

Uh oh!

Copilot AI commented Jan 30, 2026

Uh oh!

Copilot AI commented Jan 30, 2026

Uh oh!

Uh oh!

OneBlue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants