Refactor SaveImageImpl and ExportContainerImpl to eliminate code duplication#14130
Draft
Copilot wants to merge 6 commits intofeature/wsl-for-appsfrom
Draft
Refactor SaveImageImpl and ExportContainerImpl to eliminate code duplication#14130Copilot wants to merge 6 commits intofeature/wsl-for-appsfrom
Copilot wants to merge 6 commits intofeature/wsl-for-appsfrom
Conversation
Co-authored-by: ptrivedi <1638019+ptrivedi@users.noreply.github.com>
Co-authored-by: ptrivedi <1638019+ptrivedi@users.noreply.github.com>
Co-authored-by: ptrivedi <1638019+ptrivedi@users.noreply.github.com>
Co-authored-by: ptrivedi <1638019+ptrivedi@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Refactor image save and export container based on feedback
Refactor SaveImageImpl and ExportContainerImpl to eliminate code duplication
Jan 30, 2026
ac87c71 to
3d2b37a
Compare
Base automatically changed from
user/ptrivedi/saveimage-exportcont
to
feature/wsl-for-apps
February 4, 2026 00:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Addresses code review feedback from #14121 requesting extraction of ~80% duplicated code between
SaveImageImplandExportContainerImplinto a shared helper function.PR Checklist
Detailed Description of the Pull Request / Additional comments
Extracted common logic into
HandleImageLikeOperationhelperm_dockerClientvalidation already performed by callersBefore:
After:
Net change: -1 LOC (67 removed, 66 added) with improved maintainability.
Validation Steps Performed
This PR targets the base branch of #14121 (not main). Validation will occur when #14121 is built and tested on Windows with Visual Studio.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.