Fix IDL attribute spacing inconsistencies in SaveImage and ExportContainer#14134
Draft
Copilot wants to merge 4 commits intofeature/wsl-for-appsfrom
Draft
Fix IDL attribute spacing inconsistencies in SaveImage and ExportContainer#14134Copilot wants to merge 4 commits intofeature/wsl-for-appsfrom
Copilot wants to merge 4 commits intofeature/wsl-for-appsfrom
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: ptrivedi <1638019+ptrivedi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update image save and export container implementation
Fix IDL attribute spacing inconsistencies in SaveImage and ExportContainer
Jan 30, 2026
ac87c71 to
3d2b37a
Compare
Base automatically changed from
user/ptrivedi/saveimage-exportcont
to
feature/wsl-for-apps
February 4, 2026 00:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Addresses code review feedback on #14121 by fixing inconsistent spacing in IDL attribute declarations for
SaveImageandExportContainermethods.PR Checklist
Detailed Description of the Pull Request / Additional comments
The
SaveImageandExportContainermethod declarations inwslaservice.idlused inconsistent spacing in their attribute declarations and pointer types, deviating from the file's established conventions.Changes:
[ in, unique ] IProgressCallback * ProgressCallback→[in, unique] IProgressCallback* ProgressCallback[in,out,unique] WSLA_ERROR_INFO * ErrorInfo→[in, out, unique] WSLA_ERROR_INFO* ErrorInfoBoth declarations now match the compact spacing style used by all other methods in the interface:
Validation Steps Performed
Verified spacing consistency by comparing with existing method declarations (
PullImage,LoadImage,ImportImage) that use the same parameter types.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.