Skip to content

Fix IDL attribute spacing inconsistencies in SaveImage and ExportContainer#14136

Closed
Copilot wants to merge 15 commits intofeature/wsl-for-appsfrom
copilot/sub-pr-14121-yet-again
Closed

Fix IDL attribute spacing inconsistencies in SaveImage and ExportContainer#14136
Copilot wants to merge 15 commits intofeature/wsl-for-appsfrom
copilot/sub-pr-14121-yet-again

Conversation

Copy link
Contributor

Copilot AI commented Jan 30, 2026

Summary of the Pull Request

Addresses spacing inconsistencies in IDL attribute declarations that deviated from the file's established conventions.

PR Checklist

  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Fixed spacing in SaveImage and ExportContainer method declarations in wslaservice.idl to match existing file conventions:

  • Before: [ in, unique ] IProgressCallback * ProgressCallback, [in,out,unique] WSLA_ERROR_INFO * ErrorInfo
  • After: [in, unique] IProgressCallback* ProgressCallback, [in, out, unique] WSLA_ERROR_INFO* ErrorInfo

Changes align with patterns used throughout the file:

  • No extra spaces inside brackets
  • Spaces after commas in multi-part attributes
  • Asterisks attached to type names

Validation Steps Performed

Verified consistency with existing method declarations (PullImage, LoadImage, ImportImage).


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Pooja Trivedi and others added 3 commits January 27, 2026 23:50
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: ptrivedi <1638019+ptrivedi@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on image save and export container implementation Fix IDL attribute spacing inconsistencies in SaveImage and ExportContainer Jan 30, 2026
Copilot AI requested a review from ptrivedi January 30, 2026 20:55
Pooja Trivedi added 7 commits January 30, 2026 17:50
* Consolidate SendRequest* methods
* Enhance ExportContainer and the corresponding test for specific error
  code return when specified container is not found.
* Consolidate SendRequest* methods
* Enhance ExportContainer and the corresponding test for specific error
  code return when specified container is not found.
@ptrivedi ptrivedi force-pushed the user/ptrivedi/saveimage-exportcont branch from ac87c71 to 3d2b37a Compare February 2, 2026 19:33
Base automatically changed from user/ptrivedi/saveimage-exportcont to feature/wsl-for-apps February 4, 2026 00:05
@ptrivedi ptrivedi closed this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants