Repository navigation
P0 UI: universal black LCD VU glass and paint-first lightweight native splash - #140
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee5c72c152
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| public: | ||
| ConsoleWindow() | ||
| explicit ConsoleWindow (std::function<void(int)> onStartupStage) |
There was a problem hiding this comment.
Update the startup contract test for the new constructor signature
Changing this signature breaks the existing startup contract test: tests/main_v08_native_integration_test.mjs:73 still searches for ConsoleWindow(), which now matches the destructor, producing an empty constructor slice. Running the suite fails with “GUI navigation must be started from constructor.” The Windows native workflow (.github/workflows/p1-windows.yml) explicitly runs this suite, so its gate fails despite navigation remaining intact. Update the constructor extraction alongside this signature change.
AGENTS.md reference: AGENTS.md:L29-L29
Useful? React with 👍 / 👎.
| border:0;border-radius:5px; | ||
| box-shadow:inset 2px 0 3px #000a,inset -2px 0 3px #000a, | ||
| inset 0 3px 3px #000e,inset 0 -2px 2px #122a33; | ||
| filter:none;backdrop-filter:none; |
There was a problem hiding this comment.
Reconcile the explicit filter resets with the fader asset check
Adding these declarations makes python tests/fader_asset_test.py fail: lines 95–96 reject any backdrop-filter or filter: text after the P0 FADER BED RECOVERY marker, including these harmless none resets. Both .github/workflows/ui-smoke.yml and .github/workflows/pages-publish.yml run that check, so the change blocks UI validation and publishing. Either omit the unnecessary resets or narrow the asset assertion to distinguish disabled filters from expensive effects.
AGENTS.md reference: AGENTS.md:L20-L21
Useful? React with 👍 / 👎.
…med startup constructor
…ash-enabled constructor name
Implements owner-approved visual reference with a lightweight JUCE vector splash rather than embedding the 1.4 MB image or adding a GPU blur layer. All 10 channels + MASTER now have the same recessed black sleeping glass material while mono is 14px single slit and stereo/master are 30px dual; preserves 7px LED threshold painter, fader skins, selected strip/toolbar colors, native FX/de-click and VST Orbit. Splash paints before WebView2 construction via a single 90ms one-shot message-loop yield, displays true interface/audio preparation stages, and closes at native engine-ready or on WebView2 error. No plugin/device lifecycle is moved into a background thread; OS driver's synchronous startup can still block briefly (splash remains visible). Regression: 11-strip computed black-glass styles, no filters and startup event order. CSS source/runtime/offline embedded sync maintained. Separate true native BS.1770-5 + 4x dBTP analyzer follows; this PR does not invent or change audio numbers. Windows CI and Chromium checks required before merge; #139 live DRY Show SAVE is untouched.