Repository navigation
P4 stage 4: browse and recall native DRY Shows with current-device ACK + muted graph publication - #141
P4 stage 4: browse and recall native DRY Shows with current-device ACK + muted graph publication#141masarray wants to merge 2 commits into
Conversation
…act device epoch and port guard
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ffde790070
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| safe->engine_.setMasterGainLinear( | ||
| static_cast<float>(result.loaded.masterGain)); | ||
| safe->engine_.setMasterMuted(result.loaded.masterMute); | ||
| safe->engine_.setMasterMono(result.loaded.masterMono); |
There was a problem hiding this comment.
Reject mono Shows until the LAB render path supports master mono
When a saved Show has masterMono=true, recall succeeds and calls this setter, but the active Routing LAB never reads masterMono_: LiveAudioEngine returns from its LAB branch before the legacy mono processing, and LiveDryRoutingLab::process accepts only master gain and mute. Consequently, unmuting a recalled mono Show still produces stereo output. Either implement master mono in the LAB render path or reject these snapshots during preflight instead of acknowledging an incomplete recall.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 1267acc68214: Routing LAB now passes native masterMono_ into its RT render path and runs a fixed 64-sample, allocation-free mono blend, primed to exact L/R mono while hardware output is MUTED. Existing prepared-mixer native CTest now exercises muted priming, live stereo↔mono transition, bit-identical full-mono output and zero allocations. Exact-head Windows CI pending; no approval/merge claim until it passes.
| document.getElementById("arRouteFeedback").textContent=ack?.ok | ||
| ? "NATIVE SHOW RECALL ACK · verified routing published · OUTPUT STAYS MUTED" | ||
| : "RECALL REJECTED · "+String(ack?.error||"Unknown native error"); | ||
| if(ack?.ok){hydrateAcceptedRoute();drawRoutes();} |
There was a problem hiding this comment.
Synchronize the master controls after successful Show recall
When the recalled Show changes master gain or mute, this success handler refreshes only the routing editor, leaving the main MASTER fader and MUTE button at their previous values. Periodic status does not repair them: web/bridge.js::syncNativeMixerControls returns after synchronizing channels whenever the LAB is active and ready, skipping its master synchronization code. Since recall requires that exact LAB state, the displayed master controls remain inconsistent with the newly applied audio settings, and subsequent clicks operate on stale toggle state. Synchronize the recalled master values through the native adapter as well.
AGENTS.md reference: AGENTS.md:L30-L30
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 1267acc68214: factored native SSOT syncNativeMasterControls() and invoke it for both the 10CH Routing LAB and legacy CH1 paths, so the early LAB return cannot skip master fader, MUTE or MONO. Chromium UI smoke now simulates an active Lab status changing all three MASTER controls and asserts the actual DOM matches. Exact-head Chromium CI is green.
…nc, native and Chromium regression
HOLD FOR PRODUCTION ROUTING RECONCILIATION (#143; explicit product-owner direction, 2026-10-29)Latest main is The owner has rejected LAB as a product mode; #143 makes one always-live unified 10CH+4AUX+MASTER native routing engine and Waves-LV1-inspired patch grid the canonical direction. Preserve/reuse valuable PR #141 internals: SHA-verified off-RT Show listing/readback, fail-closed epoch/physical port preflight, exact master gain/mono, SSOT master GUI sync, tests. But integrate into single production routing/Shows workflow only after re-diffing newest Product contract and ordered implementation/acceptance gates: #143. |
|
2026-10-29 modern P4 Stage-4 selective port is staged as real 12-file GitHub commit |
|
Superseded by merged modern P4 #163 (source main |
Native browse + real DRY Show recall — follows #137, #138 and #139
This is an actual user-directed native BROWSE SHOWS / RECALL SELECTED DRY vertical slice. It reads the portable
Studio/Showsvia an owned IO worker, verifies the entire current generation and stored binary hashes with existingNativeShowStore::load, and prepares a fresh native Routing LAB transaction for the current device. No WebView localStorage scenes or fabricated VST3 state.NativeDryShowRecall::prepareis no-side-effect / fail-closed: validate current MUTE/DIRECT mode, active acknowledged 10CH/4AUX route, valid sparse physical ports, master support and zero VST3 in both stored and active session. Converts valid Show V3 to exact native command (CH MONO/STEREO/NONE/BUS, hard zero fader, PAN/MUTE/SOLO, CH/AUX PRE/POST sends, 4 returns).LiveAudioEngine::applyDryRoutingLabowns the only graph publication and CAS. On failure old graph remains. On success apply exact master linear/mute/mono on control thread; hardware output remains MUTED, no auto hardware activation or unmute.docs/P4_NATIVE_DRY_SHOW_RECALL_STAGE4_20261029.mdfor safety and remaining hardware FAT.Exact base main:
446eb534795a1b7ce01939971646f7ec9e2e8fc0. Exact PR head:ffde7900707804c8f7fe8b431cef2d6afcc6beae.Boundaries: DRY-only, no vendor VST3 capture/restore, no cross-PC physical device identity claim, no auto-unmute, #15 zero-FX physical crackle still open. This is a native LAB recall milestone, not production-scene certification.