Repository navigation
P4: real native Show BROWSE + transactional DRY RECALL on merged 10CH/4AUX engine - #163
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…re obsolete CH1-only gate
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a232dd9a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| document.getElementById("arRouteFeedback").textContent= | ||
| "Saving acknowledged 10 INPUT + 4 AUX DRY state to Studio/Shows (not a live recall)..."; | ||
| api.emitEvent("arMixAction",{action:"routingDryShowSave"}); | ||
| }); |
There was a problem hiding this comment.
Remove the duplicate SAVE DRY SHOW listener
Every valid SAVE DRY SHOW click now emits two routingDryShowSave actions because the original click listener remains below the new browse/recall handlers. In Main.cpp, the first action starts the worker and sets nativeShowBusy_, so the second action produces a rejected-save ACK and an error notice even though the requested save is underway. Retain only one click handler and one save-ACK handler so a single user action cannot generate contradictory success/failure feedback.
Useful? React with 👍 / 👎.
| function showIdle(){ | ||
| nativeShowRecall.disabled=nativeShowBusy||patchPending||!nativeShowUuid.test(nativeShowSelect.value)|| | ||
| !!state.monitor||!state.dryRoutingLab?.ready; | ||
| } |
There was a problem hiding this comment.
Refresh recall availability when native status changes
If a user browses and selects a Show while output is armed, showIdle() disables RECALL as intended, but muting output afterward never enables it: the arMixStatus listener updates state and calls repaint() without calling showIdle(). The same stale disabled state occurs when a device becomes ready after selection. Refresh this derived button state on native status updates; otherwise users must change the selected Show or browse again after satisfying the advertised recall prerequisites.
Useful? React with 👍 / 👎.
…rer and FAT packaging * Use native Windows Explorer file/folder pickers for VST3 import and safe chooser callbacks * Add compact indexed VST3 table and stable filtered FX picker renderer * Add compact non-blurred responsive plugin table and collision-free FX picker styles * Wire stable native VST3 table/picker, preserve text focus and material close icons * Integrate native plugin UI assets and split file/bundle import regression contracts * Integrate native plugin UI assets and split file/bundle import regression contracts * Integrate native plugin UI assets and split file/bundle import regression contracts * Integrate native plugin UI assets and split file/bundle import regression contracts * Update VST3 import contract to verify the extracted plugin UI controls * Add deterministic plugin manager paging/search, picker stability and native chooser contracts * Run plugin UI syntax/contracts in existing CI gates without adding workflows * Run plugin UI syntax/contracts in existing CI gates without adding workflows * Run plugin UI syntax/contracts in existing CI gates without adding workflows * test(plugin-ui): validate relocated native picker renderer without weakening FX safety contracts * test(plugin-ui): validate relocated native picker renderer without weakening FX safety contracts * test(plugin-ui): align native packaged UI resource contracts with new assets * test(ui): load embedded plugin-ui module before native bridge in Chromium smoke * docs: lock cross-thread P4 staged Show recall and R0B #160 CI gates * test(plugin-ui): Chromium geometry, stable focus and paging with native mock catalog * feat(r0b): verified always-on unpatched native 10CH+4AUX session (#160) * feat(r0b B3): always-on 10CH+4AUX native unpatched startup and safe CLEAR PATCH with R2 AUX matrix * fix(r0b): unpatched native graph skips all DSP and preserves CH1 preset/PDC safety * test(r0b): reconcile legacy opt-in assertions with native unpatched authorization * docs(fat): current 10CH native hardware quick-start (#162) * fix(build): use JUCE 8.0.15 generated BinaryData identifiers for hyphenated plugin UI assets * Fix JUCE 8 BinaryData symbol mangling for hyphenated plugin UI resources * fix(release): attest native 10CH/4AUX and embedded plugin UI in hardware FAT ZIP * feat(p4): native DRY Show browser, versioned routing recall and master mono (#163) * feat(p4): native Show browse and device-bound DRY recall on unified R0B B3 * test(fat): assert current real native 10CH/4AUX safety workflow, retire obsolete CH1-only gate * fix(release): truthful native 10CH+4AUX artifact provenance with FAT-unqualified guard * docs(fat): P4 native Show recall hardware steps and verified cross-thread milestone lock * Stage isolated PR161 plugin UI assets, browser tests and CI gates on post-P4 main * Reconcile plugin UI resource/import/CI patches with P4 native Show and 10CH hardware provenance * Fix release verifier nativeDSP constant to match post-P4 10CH/4AUX provenance and lock regression
User-testable production milestone
Built specifically ON TOP of merged R0B B3 #160, current R2 10x4 AUX matrix (#159), and B2 FX lifetime (#156). Reconciled all overlapping native/GUI files by patch hunks; no stale #141 wholesale merge or second audio graph. Native DRY Show SAVE already exists; this finishes bounded BROWSE and SHA-readback RECALL.
Studio/Showsfolders / list max 64, load fully SHA-verified generations; browser never sees host filesystem paths.applyDryRoutingLab; physical output always remains MUTED, reject before publication on unsupported/stale state.Gates
One PR CI Windows MSVC native 50/50+ CTests, independently verified ZIP and Chromium required before merge, then one main packaged Windows build for user test. #15 0-FX crackle physical FAT remains required; NO third-party FX Show recall, automatic hardware unmute, PDC, or independent physical AUX output implied. Hardware quickstart
docs/HARDWARE_FAT_GUI10_ENGINE_P012_20261027.mdgives startup/output-only/capture-only/DRY-through/real 10CH tests.