Skip to content

P1K: measured native MASTER 48k LUFS-I and 4x intersample dBTP - #142

Merged
masarray merged 9 commits into
mainfrom
feature/p1k-native-measured-lufs-dbtp-20261029
Oct 29, 2026
Merged

masarray merged 9 commits into
mainfrom
feature/p1k-native-measured-lufs-dbtp-20261029

Conversation

@masarray

Copy link
Copy Markdown
Owner

Real native MASTER PCM metering: preallocated 48k K-weighted 400ms/75% gated integrated LUFS histograms, independently measured 4x windowed-sinc FIR intersample dBTP, one existing 12Hz status transport, two-row green/red glass LCD rendering. Reads actual post-fader routed MASTER samples for CH1 and ten-channel DRY LAB; never reuses sample-peak or demo numbers. No new worker/UI polling/OS I/O/VST state on audio callback; tests use 997Hz -20dBFS stereo reference, phase-shifted 12k intersample peak, unsupported rates, silence, reset. Unsupported 44.1/96/independent clock remains correctly unavailable until separately validated. Preserves P1J FX, Orbit, 10CH+AUX, #15. CI must pass MSVC+CTest+Chromium and hardware FAT before release. See docs/P1K_NATIVE_BS1770_DBTp_20261029.md; independent from visual splash PR #140.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T01:17:15.237269Z fdfc794 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fdfc79488f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +153 to +155
const double y=b0*x+z1;
z1=b1*x-a1*y+z2;
z2=b2*x-a2*y;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Suppress denormals in the loudness filter

When audio becomes silent after a nonzero signal and the callback thread has flush-to-zero disabled, these recursive filter states decay into subnormal doubles and continue doing expensive subnormal arithmetic throughout silence. Neither process() nor the calling LiveAudioEngine callback establishes a denormal guard. An optimized standalone reproduction using an impulse followed by silence took approximately 40–51 ms per second of processed audio, versus 16 ms with FTZ/DAZ enabled. Because this meter now runs on every supported DIRECT callback, this unnecessarily consumes realtime processing headroom even while output is muted. Add a scoped denormal guard or explicitly flush sufficiently small filter states to zero, and cover signal-to-silence transitions in the tests.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant