Skip to content

P0: GUI-first WebView startup, compact mono/stereo LED wells, LUFS/dBTP LCD - #133

Merged
masarray merged 12 commits into
mainfrom
fix/p0-meter-lcd-startup-20261029
Oct 28, 2026
Merged

masarray merged 12 commits into
mainfrom
fix/p0-meter-lcd-startup-20261029

Conversation

@masarray

Copy link
Copy Markdown
Owner

Latest main baseline

Built on main@faee66f after validated ShowV2 PR #131 merge. No audio callback, VST lifecycle, Orbit, FX drag/de-click, meter scheduler or routing topology code changes.

Four user-reported issues

  1. WebView2 starts navigating immediately; defer synchronous JUCE engine_.start until the authenticated arMixGuiReady handshake plus 150ms compositor opportunity on the existing 12Hz control timer. No extra worker, timer, polling or premature device selection. Cold WebView2/DPI hardware first-paint FAT still required.
  2. Mono vu-bank is 35px/one physical 14px LED; stereo/master keep 51px/two LEDs. No phantom empty left mono rail, fixed 7px LED DSP and all source/native meter IDs intact.
  3. Both meters become fully static machined recessed wells with inset edges matching the fader bed; no new rectangle border, blur or animated glow.
  4. MASTER becomes two-line dark glass LCD, labels LUFS and dBTP only, green values, red for LUFS > -12 or dBTP > -1. The browser uses a clearly UI-preview simulated source; native still returns em dashes (no truthful BS.1770/oversampled true peak DSP yet). No invented live numbers.

Gates

CSS source regenerated into runtime+standalone with exact byte parity; existing Chromium smoke now validates mono/stereo pixel widths, recessed inset, 2-row LCD and both thresholds; Node contract validates native handshake before audio start. Await Windows MSVC+CTest/Chromium CI and physical WebView2 first-open timing before merging. Preview should not be marketed as a certified audio loudness meter.

Follow-on

Real native BS.1770 K-weighted gated LUFS-I and oversampled dBTP measurement requires separate RT-safe DSP design, preallocation, off-callback publish and trusted golden-vector tests; current limitation remains visible as —.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T21:55:46.356805Z 4df685c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4df685caf8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +2215 to +2217
'use strict';
// AR MIX Studio UI-only demonstration. No audio is mixed or routed here.
const colors=['#1699cd','#b92e41','#cf6b1e','#b28c27','#34a544','#168762','#0e95c9','#066fa9','#7140b5','#b52893','#c32974','#586889'];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Replace the embedded app instead of appending a second copy

Opening the standalone distributable now fails to initialize the mixer because the updated app is appended inside the existing <script> rather than replacing its previous contents. Both copies declare top-level constants such as colors, producing SyntaxError: Identifier 'colors' has already been declared before any mixer rendering executes. This also breaks the Pages preview, which scripts/build_pages.py copies directly from this file. Replace the embedded script with exactly one copy of web/app.js; the required tests/gui_baseline_lock_test.py currently fails its script-parity assertion. This violates the standalone synchronization requirement in AGENTS.md.

AGENTS.md reference: AGENTS.md:L18-L18

Useful? React with 👍 / 👎.

masarray added a commit that referenced this pull request Oct 28, 2026
…uses

Merge P1K on P1J/P1I/P4 main. Four dedicated stereo AUX FX returns no longer occupy CH1-10 input strips; actual 10CH PCM and AUX pre/post DSP, independent AUX VST3, control-only validation and preallocated scratch, P1J FX reuse, native source-to-AUX routing UI and ACK. Fail-closed port identity, device epoch, MUTE gate, existing CH1/Orbit/ShowV2 preserved. Windows exact PR f9a6a3b PASS (46/46 CTest including P1K native, P1H JUCE processor, P1I realtime, P4 ShowV2; verified Windows package), Chromium exact-head PASS. Parallel PR #133 premium GUI file scope preserved; no claim of hardware FAT, PDC or physical AUX outputs.
@masarray
masarray merged commit 6077513 into main Oct 28, 2026
2 checks passed
masarray added a commit that referenced this pull request Oct 28, 2026
…and CI-stable mixer

* P4 stage 2: generation-staged native Show workspace with verified immutable plugin state blobs

* test: native Show generation roundtrip, corruption rollback, old generation retention

* P4: run native Show store test and verify portable backup includes Shows

* P4: run native Show store test and verify portable backup includes Shows

* P4: run native Show store test and verify portable backup includes Shows

* P4 hardening: deduplicate immutable blob verification and enforce load IO budget

* docs: P4 staged Shows generations, backup integration, guardrails and remaining native recall gates

* P1K: ten independent physical inputs plus four real AUX VST3 return buses

Merge P1K on P1J/P1I/P4 main. Four dedicated stereo AUX FX returns no longer occupy CH1-10 input strips; actual 10CH PCM and AUX pre/post DSP, independent AUX VST3, control-only validation and preallocated scratch, P1J FX reuse, native source-to-AUX routing UI and ACK. Fail-closed port identity, device epoch, MUTE gate, existing CH1/Orbit/ShowV2 preserved. Windows exact PR f9a6a3b PASS (46/46 CTest including P1K native, P1H JUCE processor, P1I realtime, P4 ShowV2; verified Windows package), Chromium exact-head PASS. Parallel PR #133 premium GUI file scope preserved; no claim of hardware FAT, PDC or physical AUX outputs.

* P4: use dashed JUCE UUID for Show generations; index verified vendor hashes and pin API contract

* P0 GUI: fast WebView startup, recessed mono/stereo VU and dual-metric master LCD

* P0 GUI: tailored recessed mono meter and compact threshold-colored master LCD

* P0: WebView-ready-first startup avoids synchronous device-blocked blank window

* test: mono/stereo recessed meter geometry, LCD thresholds and GUI-first native startup

* test: mono/stereo recessed meter geometry, LCD thresholds and GUI-first native startup

* test: use exact LUFS label check without fragile regexp escaping

* fix: exact standalone script parity (remove duplicated JS after GUI update)

* test: replace superseded SIM/LUFS-I caption assertions with minimal LCD and honest preview provenance

* test: updated mono/stereo bank widths and rail offsets to match requested compact meter geometry

* P0: keep fixed 10px LED cells inside borderless recessed meter well

* P0: keep fixed 10px LED cells inside borderless recessed meter well

* P0: keep fixed 10px LED cells inside borderless recessed meter well

* P0: lightweight native first-frame text during WebView2 cold boot, no blank window or compositor timer

* test: isolate master clip reset assertions from live browser demo producer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant