Skip to content

P4: persist 10 INPUT + 4 AUX in versioned native Shows with verified FX state - #138

Merged
masarray merged 1 commit into
mainfrom
feature/p4-aux-show-v3-storage-20261029
Oct 29, 2026
Merged

masarray merged 1 commit into
mainfrom
feature/p4-aux-show-v3-storage-20261029

Conversation

@masarray

Copy link
Copy Markdown
Owner

P4 AUX-aware native storage slice (from main@e24f9169eea5)

Completes the merged #134 transactional storage contract for P1K: four dedicated stereo AUX returns with independent ordered FX state references and input-only PRE/POST sends. The original 10 INPUTs, original engine DSP, GUI #133, Orbit, WebView, routing and realtime control are unchanged.

  • Version 3 snapshots; fail closed for old V2 readers (prevent silent AUX loss); accept legacy V2 with AUX disabled.
  • Four fixed AUX IDs, enabled/MAIN/mute/gain/FX; up to 32 input-only sends with strict source/destination/tap/gain/pan validation and duplicate/disabled-bus rejection.
  • Atomic storage commit and read validate AUX VST3 binary SHA256 references, missing binary rejection, generation retention, caller rollback.
  • JUCE CTest coverage for legacy migration, FX state, PRE/POST, invalid routes and failure atomicity; existing CI and portable backup retained.

Verify: exact PR-head MSVC full build + all CTests + packaged Windows binary, exact-head Chromium UI smoke. No trial-only test relaxation. Physical 48 kHz ASIO/WASAPI 128/256/480 buffer FAT is separate; #15 zero-FX crackle unresolved. This is native storage, not live vendor capture/recall. Tracks handoff #137.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T23:42:09.663653Z fd54118 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant