Skip to content

P4 stage 3: live native DRY Show SAVE from ACK routing + off-RT transactional storage - #139

Merged
masarray merged 2 commits into
mainfrom
feature/p4-native-dry-show-save-20261029
Oct 29, 2026
Merged

masarray merged 2 commits into
mainfrom
feature/p4-native-dry-show-save-20261029

Conversation

@masarray

Copy link
Copy Markdown
Owner

Real native DRY Show SAVE (follows #137 and merged #138)

Production-facing vertical slice: a new SAVE DRY SHOW button inside the real native Routing LAB captures the ACK'd source routing graph, not browser/localStorage drafts, and writes an independently verified Show generation to the portable Studio/Shows vault. Zero VST3 only until safe vendor processor quiescence is proven.

  • Capture requires verified active DIRECT session, output MUTE, current device epoch+route revision, enabled physical port mask, exact 10 live controls and all 4 AUX definitions; no partial snapshot on error.
  • Captures actual live fader linear coefficients including hard zero, PAN, MUTE/SOLO, MONO/STEREO/BUS semantics, CH and AUX PRE/POST sends, dedicated AUX gain/switches, MASTER gain/mute/mono.
  • New BUS-return marker preserves BUS vs NONE across storage. Existing snapshots without the marker remain safely disconnected.
  • Worker IO/HASH commit + verified readback, one new UUID Show, no UI/RT blocking, mutually exclusive with USB backup. No device reconfiguration, auto-unmute, native recall or fake plugin state.
  • Native acceptance CTest asserts dry capture, 10 INPUT + 4 AUX, hardware port verification, rejection of stale revision/active output/vendor FX, rollback, and transactional on-disk readback.
  • One single Windows CI workflow (MSVC full app + existing CTests + new native CTest + packaged ZIP) and Chromium smoke for only changed native Routing panel. Legacy FX/Orbit UI untouched.

Boundaries: on-RT remains no heap/lock/file/scan/JSON. Current one-VST3-per-channel/AUX graph is preserved. FX-equipped full Show capture/recall still requires a separately qualified quiescence/thread-affinity protocol. No physical FAT or zero-FX crackle #15 claim. See docs/P4_NATIVE_DRY_SHOW_CAPTURE_STAGE3_20261029.md.

Parent main SHA: c66649059169428385f3804f4281df3df931ca8e.

… worker with live controls and fail-closed guards
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T00:44:19.336287Z 366fead PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit 446eb53 into main Oct 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant