Repository navigation
P4 stage 2: transactional native Shows generations, verified VST3 blobs and backup tests - #134
Conversation
…utable plugin state blobs
… remaining native recall gates
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fbb3c0240b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const auto generation=juce::Uuid().toString().toLowerCase(); | ||
| if(!detail::uuid(generation)) return "Could not create generation ID"; |
There was a problem hiding this comment.
Generate a dashed UUID that passes the generation validator
Every otherwise-valid commit() fails here: JUCE's Uuid::toString() returns a 32-character hexadecimal string, while detail::uuid() in NativeShowSchema.h requires 36 characters with hyphens. Consequently, no generation or HEAD can ever be published, and the new native store test fails at its first successful-commit assertion. Use toDashedString() so generated IDs satisfy the validator used by both commit and load. See the JUCE UUID documentation.
Useful? React with 👍 / 👎.
…uses Merge P1K on P1J/P1I/P4 main. Four dedicated stereo AUX FX returns no longer occupy CH1-10 input strips; actual 10CH PCM and AUX pre/post DSP, independent AUX VST3, control-only validation and preallocated scratch, P1J FX reuse, native source-to-AUX routing UI and ACK. Fail-closed port identity, device epoch, MUTE gate, existing CH1/Orbit/ShowV2 preserved. Windows exact PR f9a6a3b PASS (46/46 CTest including P1K native, P1H JUCE processor, P1I realtime, P4 ShowV2; verified Windows package), Chromium exact-head PASS. Parallel PR #133 premium GUI file scope preserved; no claim of hardware FAT, PDC or physical AUX outputs.
…hashes and pin API contract
… master LCD * P0 GUI: tailored recessed mono meter and compact threshold-colored master LCD * P0: WebView-ready-first startup avoids synchronous device-blocked blank window * test: mono/stereo recessed meter geometry, LCD thresholds and GUI-first native startup * test: mono/stereo recessed meter geometry, LCD thresholds and GUI-first native startup * test: use exact LUFS label check without fragile regexp escaping * fix: exact standalone script parity (remove duplicated JS after GUI update) * test: replace superseded SIM/LUFS-I caption assertions with minimal LCD and honest preview provenance * test: updated mono/stereo bank widths and rail offsets to match requested compact meter geometry * P0: keep fixed 10px LED cells inside borderless recessed meter well * P0: keep fixed 10px LED cells inside borderless recessed meter well * P0: keep fixed 10px LED cells inside borderless recessed meter well * P0: lightweight native first-frame text during WebView2 cold boot, no blank window or compositor timer
|
CI root cause isolated and repaired at |
|
Cross-thread integration gate — Issue #137 is the up-to-date canonical architecture/handoff. Main now includes merged P1K 10 native INPUTS + FOUR AUX FX returns ( |
Baseline and protection
Based on merged P4 ShowV2 schema in
main@faee66f. Independent of GUI fix PR #133. NoMain.cpp, WebView, realtime audio callback, P1J FX lifecycle, routing, Orbit, meter or GUI CSS edits.Implemented (CONTROL/IO only)
NativeShowStore: validated ShowV2 / ten-channel SnapshotV2 payload, ordered snapshot UUIDs, strict size limits, SHA256-verifiable actual supplied vendor state bytes. Missing binary fails before disk. No fake capture claims.show.json,snapshots/*.json,blobs/<sha256>.bin); re-open/verify them and publish underversions/<uuid>; commit oneHEADpointer via flushedjuce::TemporaryFile. Failed commit preserves old HEAD; old versions retained.Studio/Showsis included.Honest limitations
This is the storage engine, not wired UI or live native mixer save/recall. Real VST3
getStateInformation()capture, native state projection/ACK, device map preflight, Orbit, HPF, master FX, gated live recall/undo and full hardware FAT are separate reviewable gates. Zero-VST crackle #15 remains open. Record and thread affinity/OS power-loss proof needed before production qualification.Full architecture and gates:
docs/P4_NATIVE_SHOW_STORE_STAGE2_20261029.md. Require exact-head Windows MSVC/CTest green before merge.