Skip to content

P4 stage 2: transactional native Shows generations, verified VST3 blobs and backup tests - #134

Merged
masarray merged 12 commits into
mainfrom
feature/p4-native-show-transactional-store-20261029
Oct 28, 2026
Merged

masarray merged 12 commits into
mainfrom
feature/p4-native-show-transactional-store-20261029

Conversation

@masarray

Copy link
Copy Markdown
Owner

Baseline and protection

Based on merged P4 ShowV2 schema in main@faee66f. Independent of GUI fix PR #133. No Main.cpp, WebView, realtime audio callback, P1J FX lifecycle, routing, Orbit, meter or GUI CSS edits.

Implemented (CONTROL/IO only)

  • NativeShowStore: validated ShowV2 / ten-channel SnapshotV2 payload, ordered snapshot UUIDs, strict size limits, SHA256-verifiable actual supplied vendor state bytes. Missing binary fails before disk. No fake capture claims.
  • Prepare all files in same-volume staged generation (show.json, snapshots/*.json, blobs/<sha256>.bin); re-open/verify them and publish under versions/<uuid>; commit one HEAD pointer via flushed juce::TemporaryFile. Failed commit preserves old HEAD; old versions retained.
  • Read verifies HEAD UUID, snapshot manifests and all unique referenced blobs, bounded total read bytes, before replacing out-parameters. Reject corrupt/missing states without corrupting the caller.
  • Native deterministic CTest covers generation commit/retention/recovery/corrupt HEAD and VST3 state bytes; adds CTest to existing canonical Windows CI (no extra workflow). Existing verified Studio USB Backup test now asserts Studio/Shows is included.

Honest limitations

This is the storage engine, not wired UI or live native mixer save/recall. Real VST3 getStateInformation() capture, native state projection/ACK, device map preflight, Orbit, HPF, master FX, gated live recall/undo and full hardware FAT are separate reviewable gates. Zero-VST crackle #15 remains open. Record and thread affinity/OS power-loss proof needed before production qualification.

Full architecture and gates: docs/P4_NATIVE_SHOW_STORE_STAGE2_20261029.md. Require exact-head Windows MSVC/CTest green before merge.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T22:06:18.611374Z fbb3c02 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fbb3c0240b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/NativeShowStore.h Outdated
Comment on lines +72 to +73
const auto generation=juce::Uuid().toString().toLowerCase();
if(!detail::uuid(generation)) return "Could not create generation ID";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Generate a dashed UUID that passes the generation validator

Every otherwise-valid commit() fails here: JUCE's Uuid::toString() returns a 32-character hexadecimal string, while detail::uuid() in NativeShowSchema.h requires 36 characters with hyphens. Consequently, no generation or HEAD can ever be published, and the new native store test fails at its first successful-commit assertion. Use toDashedString() so generated IDs satisfy the validator used by both commit and load. See the JUCE UUID documentation.

Useful? React with 👍 / 👎.

…uses

Merge P1K on P1J/P1I/P4 main. Four dedicated stereo AUX FX returns no longer occupy CH1-10 input strips; actual 10CH PCM and AUX pre/post DSP, independent AUX VST3, control-only validation and preallocated scratch, P1J FX reuse, native source-to-AUX routing UI and ACK. Fail-closed port identity, device epoch, MUTE gate, existing CH1/Orbit/ShowV2 preserved. Windows exact PR f9a6a3b PASS (46/46 CTest including P1K native, P1H JUCE processor, P1I realtime, P4 ShowV2; verified Windows package), Chromium exact-head PASS. Parallel PR #133 premium GUI file scope preserved; no claim of hardware FAT, PDC or physical AUX outputs.
… master LCD

* P0 GUI: tailored recessed mono meter and compact threshold-colored master LCD

* P0: WebView-ready-first startup avoids synchronous device-blocked blank window

* test: mono/stereo recessed meter geometry, LCD thresholds and GUI-first native startup

* test: mono/stereo recessed meter geometry, LCD thresholds and GUI-first native startup

* test: use exact LUFS label check without fragile regexp escaping

* fix: exact standalone script parity (remove duplicated JS after GUI update)

* test: replace superseded SIM/LUFS-I caption assertions with minimal LCD and honest preview provenance

* test: updated mono/stereo bank widths and rail offsets to match requested compact meter geometry

* P0: keep fixed 10px LED cells inside borderless recessed meter well

* P0: keep fixed 10px LED cells inside borderless recessed meter well

* P0: keep fixed 10px LED cells inside borderless recessed meter well

* P0: lightweight native first-frame text during WebView2 cold boot, no blank window or compositor timer

Copy link
Copy Markdown
Owner Author

CI root cause isolated and repaired at 81c71557 (now based on merged P0 GUI main@6077513e). The failing CTest from 40777152058 was not an audio regression: JUCE Uuid::toString() emits 32 hex digits but the Show storage validator requires 36-character dashed UUIDs. Replaced with toDashedString(), added regression assertions for both JUCE APIs, and indexed prevalidated vendor-state hashes for bounded O(log B) lookups. The latest main Chromium failure was a test-only race: active preview RAF could re-arm peakHold.masterL immediately after RESET; the deterministic clip-latch test now cancels its demo producer before manual injection, without changing native metering. Reconciled the CMake/workflow changes against current main preserving dedicated AUX build targets. Keep this PR unmerged until exact-head Windows CTest (including ShowStore) and Chromium are green; avoid speculative pushes/reruns.

Copy link
Copy Markdown
Owner Author

Cross-thread integration gate — Issue #137 is the up-to-date canonical architecture/handoff. Main now includes merged P1K 10 native INPUTS + FOUR AUX FX returns (662b060f) and merged P0 GUI PR #133 (6077513). Current PR #134 was originally based on faee66f and its changed-files list includes P1K core and recent GUI files, despite Show-storage-only scope. Please compare this branch against live main and isolate the actual NativeShowStore/persistence/CTest changes before merging, preserving all P1K AUX DSP, P1J FX identity, and #133 visual/startup work. Stage1 ShowV2 snapshot schema does NOT serialize P1K AUX, so adding transactional storage is NOT equivalent to full 10CH+4AUX performance backup/recall. Current main UI smoke has a separate MASTER peak-hold click test failure; avoid hiding or overriding this through a broad merge.

@masarray
masarray merged commit e24f916 into main Oct 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant