Repository navigation
P1K: 10 always-available input channels plus four real independent AUX/VST3 return buses - #136
Conversation
…PRE/POST sends and feedback-free topology
…fore MASTER; no impact to ten source strips
…rs with P1J reuse semantics
…PRE/POST sends to AUX ids 10..13
…and accepted ACK with P1J instance reuse
…re routing commit
… lanes, pre/post FX sample math and rollback/no RT allocation
…rn; preserve instance and tail on routing revision
…id bus and preserve rollback
…ults; clear off-session aux labels
…, rollback and professional mixer caveats
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…ndependent AUX while preserving assertions
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42e1bd656e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| }; | ||
| using FxBank=std::array<std::shared_ptr<FxInstance>,channels>; | ||
| using FxBank=std::array<std::shared_ptr<FxInstance>,fxSlots>; |
There was a problem hiding this comment.
Update existing routing contracts for the AUX-aware implementation
Running node --test tests/live_routing_ui_contract_test.mjs now fails two existing tests: P1H still requires FxBank to use channels, and P1G still requires result.sendCount, which the revised ACK text removes. The Windows workflow .github/workflows/p1-windows.yml explicitly runs this suite and exits on failure before configuring the native build, so adding the new P1K test does not leave the required native CI gate passing. Update both existing assertions to validate the new AUX-aware behavior while retaining their original coverage.
AGENTS.md reference: AGENTS.md:L86-L86
Useful? React with 👍 / 👎.
P1K — real 10 fixed inputs + FOUR native AUX FX returns (single existing engine)
Base:
main@faee66f(P1J FX continuity, P1I realtime 10CH, P4 ShowV2 native wire contract, latest GUI). Coordinated with parallel PR #133; this PR does NOT modify premium GUIweb/app.js,web/styles.css, standalone HTML or toolbar. Sharedsrc/Main.cpponly adds AUX identities to the existing routing bridge and must reconcile before merge if #133 lands first.True executable milestone
AuxBusPlancompiler (max four AUX, total 32 UI sends). Input-only source, unique source/bus/tap, valid level/pan, enabled destination; no AUX→INPUT/AUX cycles possible by construction. Full transactional rollback on bad plan.PreparedMixerBlockadds optional preallocated AUX scratch (when any AUX enabled), dispatches PRE and POST at the exact same channel sample points, calls actual FX seam with idstripCount+b, then mixes each independent AUX return to stereo MAIN. No heap on callback.LiveChannelFxGraphsupports 10 real channel VST3 inserts plus 4 AUX inserts with P1J stable vendor state/processor reuse across graph swaps and deferred release.NativeDryRouteCommandvalidates typedauxes[4]and send destination 10..13;src/Main.cppresolves AUX plugin IDs only through the native verified catalog, never file paths from WebView.LiveDryRoutingLabperforms one atomic publication for 10CH+4AUX and reportsauxCount,auxSendCount,auxFxNames,auxPeaks,fxReused.SIGNAL FLOW → OPEN ROUTING MATRIXadds real AUX1–4 controls and destination choices, and rehydrates from native acknowledged route. No mock FX routing, no cosmetic redesign.Hard limits: this remains opt-in Routing LAB requiring output MUTE for structural APPLY; one stereo-compatible VST3 per strip and per AUX; no physical AUX outputs, cross-AUX sends, latency PDC, full native multichannel snapshot restore or #15 hardware crackle FAT. This is not yet parity with Studio One / Adobe Audition; it removes the structural 10-channel bottleneck.
Merge gate: exact PR head Windows x64 native app+all CTests+verified ZIP AND Chromium UI smoke success; inspect/reconcile parallel GUI PR #133 first. Full engineering FAT
docs/P1K_TEN_INPUTS_FOUR_DEDICATED_AUX_20261029.md.