Skip to content

P1K: 10 always-available input channels plus four real independent AUX/VST3 return buses - #136

Merged
masarray merged 23 commits into
mainfrom
feature/p1k-dedicated-aux-buses-20261029
Oct 28, 2026
Merged

masarray merged 23 commits into
mainfrom
feature/p1k-dedicated-aux-buses-20261029

Conversation

@masarray

Copy link
Copy Markdown
Owner

P1K — real 10 fixed inputs + FOUR native AUX FX returns (single existing engine)

Base: main@faee66f (P1J FX continuity, P1I realtime 10CH, P4 ShowV2 native wire contract, latest GUI). Coordinated with parallel PR #133; this PR does NOT modify premium GUI web/app.js, web/styles.css, standalone HTML or toolbar. Shared src/Main.cpp only adds AUX identities to the existing routing bridge and must reconcile before merge if #133 lands first.

True executable milestone

  • Four independent AUX stereo buses no longer consume CH1–CH10. All ten physical sources can be enabled while AUX1–4 process PRE/POST sends, independent AUX VST3, level/mute/Main and audible master return in the existing prepared callback. The original P1G channel-channel BUS path remains backward compatible. No new realtime threading/audio engine.
  • Bounded, allocation-free AuxBusPlan compiler (max four AUX, total 32 UI sends). Input-only source, unique source/bus/tap, valid level/pan, enabled destination; no AUX→INPUT/AUX cycles possible by construction. Full transactional rollback on bad plan.
  • PreparedMixerBlock adds optional preallocated AUX scratch (when any AUX enabled), dispatches PRE and POST at the exact same channel sample points, calls actual FX seam with id stripCount+b, then mixes each independent AUX return to stereo MAIN. No heap on callback.
  • LiveChannelFxGraph supports 10 real channel VST3 inserts plus 4 AUX inserts with P1J stable vendor state/processor reuse across graph swaps and deferred release.
  • NativeDryRouteCommand validates typed auxes[4] and send destination 10..13; src/Main.cpp resolves AUX plugin IDs only through the native verified catalog, never file paths from WebView. LiveDryRoutingLab performs one atomic publication for 10CH+4AUX and reports auxCount, auxSendCount, auxFxNames, auxPeaks, fxReused.
  • SIGNAL FLOW → OPEN ROUTING MATRIX adds real AUX1–4 controls and destination choices, and rehydrates from native acknowledged route. No mock FX routing, no cosmetic redesign.
  • New C++ native test exercises all 10 actual physical PCM inputs plus two AUX simultaneously, PRE/POST / real FX callbacks, analytical audio sums, solo/fader PRE semantics, AUX MUTE and gain, no RT heap, compiler rollback, invalid feedback, old no-AUX legacy. Existing real JUCE FX processor test extended with a live AUX VST3 instance and P1J identity preservation. Native JSON parser and UI contract augmented. Reuses existing lean Windows CI and test suite; no extra workflow.

Hard limits: this remains opt-in Routing LAB requiring output MUTE for structural APPLY; one stereo-compatible VST3 per strip and per AUX; no physical AUX outputs, cross-AUX sends, latency PDC, full native multichannel snapshot restore or #15 hardware crackle FAT. This is not yet parity with Studio One / Adobe Audition; it removes the structural 10-channel bottleneck.

Merge gate: exact PR head Windows x64 native app+all CTests+verified ZIP AND Chromium UI smoke success; inspect/reconcile parallel GUI PR #133 first. Full engineering FAT docs/P1K_TEN_INPUTS_FOUR_DEDICATED_AUX_20261029.md.

… lanes, pre/post FX sample math and rollback/no RT allocation
…rn; preserve instance and tail on routing revision
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T22:14:50.533557Z 42e1bd6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42e1bd656e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}
};
using FxBank=std::array<std::shared_ptr<FxInstance>,channels>;
using FxBank=std::array<std::shared_ptr<FxInstance>,fxSlots>;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update existing routing contracts for the AUX-aware implementation

Running node --test tests/live_routing_ui_contract_test.mjs now fails two existing tests: P1H still requires FxBank to use channels, and P1G still requires result.sendCount, which the revised ACK text removes. The Windows workflow .github/workflows/p1-windows.yml explicitly runs this suite and exits on failure before configuring the native build, so adding the new P1K test does not leave the required native CI gate passing. Update both existing assertions to validate the new AUX-aware behavior while retaining their original coverage.

AGENTS.md reference: AGENTS.md:L86-L86

Useful? React with 👍 / 👎.

@masarray
masarray merged commit 662b060 into main Oct 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant