Skip to content

P0: gray OFF/green ON toolbar, stable JUCE Audio Setup, snapshot manager + native Show ARD - #128

Closed
masarray wants to merge 16 commits into
mainfrom
fix/p0-audio-setup-toolbar-snapshots-20261028
Closed

masarray wants to merge 16 commits into
mainfrom
fix/p0-audio-setup-toolbar-snapshots-20261028

Conversation

@masarray

Copy link
Copy Markdown
Owner

P0 follow-up from user hardware screenshots — grounded on main@758ec23

  • Toolbar: restore canonical BTN-180 light-steel OFF, use status GREEN only for .selected/.active. Previous PR P0 GUI: equal MASTER/CH strips, brighter fast BTN-180, glass LCD meters and current landing #124 lime OFF was wrong. Add 8% CSS color-mix hover paint on hovered pad only, with no filter, blur, animated shadow or DOM work.
  • Native JUCE audio setup: AudioDeviceSelectorComponent dynamically enumerates hardware; setContentOwned(selector,false) keeps Windows top-level viewport fixed rather than resizing with selector content. One message-thread post-show reflow/repaint, no polling. First-show/move/DPI hardware FAT required.
  • Snapshot left-rail: compact Shows/Snapshots manager, Save New/Update/Rename/Delete/Recall, 10CH+MASTER Recall Safes, persistent localStorage UI preview, pre-recall Undo, 2-click destructive actions, accessible snapshot shortcut, factory immutable. Native real audio fenced to avoid misleading UI-only claims. Native MY SOUNDS real CH1 VST3 archive untouched.
  • New native 10CH ShowV2/SnapshotV2 transactional storage + safe ack recall ARD: docs/ARD_SNAPSHOT_SHOWS_NATIVE_TRANSACTIONAL_20261028.md. Explicit next milestone, not claimed completed.
  • Do not touch P1H 10CH DSP, P1G bus, Orbit, anti-crackle FX move/bypass, 30FPS meter or any vendor VST3 state.
  • Source CSS/runtime WebView2/offline HTML exact parity plus relevant UI and C++ contract tests.
  • Gates: exact-head Chromium UI CI and native Windows MSVC/CTest CI, verify screenshot and binary. Hardware audio dialog first-show DPI/recovery still requires user test.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-28T13:28:43.958809Z cf550a8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Cross-thread integration note (2026-10-29): P1I PR #127 has been squash-merged to main@13e21b28a43854a611a811f7991344304fc109e4 after exact-head Windows + Chromium PASS. PR #128 was built against prior main@758ec23 and shares modified paths src/Main.cpp, web/app.js, AR-MIX-Live-FX-Host-Standalone-v0.3.html. Do not squash/merge #128 blind. Please rebase/reconcile these 3 files on latest main while preserving all 10CH realtime native fader/pan/mute/solo (incl epoch/revision fencing, P1I UI controls) and exact embedded-HTML parity. Non-overlap CSS/audio-setup/snapshot enhancements should be retained. Re-run exact-head Windows & Chromium before merge. Snapshot manager must remain clearly UI-preview-only until native snapshot SSOT is implemented; no audio recall misrepresentation. #15 zero-FX hardware crackle is still unqualified.

Copy link
Copy Markdown
Owner Author

Architecture reconciliation — superseded, closing without merge. Old toolbar/device setup/snapshot UX branch touches Main.cpp, UI styles and HTML against Oct 28 baseline. Current native device UI, L2 geometry and Show engine differ. The remaining native Show/recall requirements are explicitly owned by #180; no blind merge.

Canonical PRD v5 / ARD v5. Active native graph #266, operator UI #265, issue #192. This historic branch/commit remains available for selective reference; no source deletion and no loss-of-working-audio merge.

@masarray masarray closed this Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant