Repository navigation
P4 stage 1: bounded native ShowV2 / 10CH SnapshotV2 wire schema and CTest - #131
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baseline and non-regression
Starts from verified
main@bc11edfwith P1J already merged. No changes to Main.cpp, audio callback, VST3 runtime, native GUI bridge, CSS, FX reorder/de-click, dearVR Orbit or 10CH geometry. Avoids stale PR #128 bulk merge.Implemented
ShowV2(snapshot UUID order + 10 CH safes) andSnapshotV2(10 indexed physical route/control records, pre/post sends, ordered VST catalog/UID/immutable SHA256 blob references, master).docs/P4_NATIVE_SHOW_V2_SCHEMA_STAGE1_20261029.md.Not yet delivered
No filesystem storage or real VST capture/recall, no GUI native scene activation, no Orbit/HPF/full bus state payload, no physical hardware FAT. Current localStorage scene remains UI-only. P4 Stage 2 adds transactional Studio/Shows archive+blobs and backup; Stage 3 binds authoritative GUI; Stage 4 gates real recall behind epoch/ACK and MUTE. #15 crackle remains open.
Gates
Require Windows MSVC/CTest and existing GUI smoke checks before any merge. CI PASS cannot replace real Windows Audio Setup first-paint and ASIO/WASAPI FAT.