Skip to content

P4 stage 1: bounded native ShowV2 / 10CH SnapshotV2 wire schema and CTest - #131

Merged
masarray merged 6 commits into
mainfrom
feature/p4-native-show-schema-20261029
Oct 28, 2026
Merged

masarray merged 6 commits into
mainfrom
feature/p4-native-show-schema-20261029

Conversation

@masarray

Copy link
Copy Markdown
Owner

Baseline and non-regression

Starts from verified main@bc11edf with P1J already merged. No changes to Main.cpp, audio callback, VST3 runtime, native GUI bridge, CSS, FX reorder/de-click, dearVR Orbit or 10CH geometry. Avoids stale PR #128 bulk merge.

Implemented

  • Native, CONTROL-thread-only JSON ShowV2 (snapshot UUID order + 10 CH safes) and SnapshotV2 (10 indexed physical route/control records, pre/post sends, ordered VST catalog/UID/immutable SHA256 blob references, master).
  • Versioned strict, bounded decoder; rejects unsafe IDs/names, duplicate snapshots, out-of-range ports, malformed/bad plugin hashes/commands and truncated oversized input. Failed decode does not modify previously accepted state.
  • Standalone CTest roundtrip and regression cases; adds test to the existing Windows native pipeline (no new CI matrix).
  • Engineering limits and follow-on stages documented in docs/P4_NATIVE_SHOW_V2_SCHEMA_STAGE1_20261029.md.

Not yet delivered

No filesystem storage or real VST capture/recall, no GUI native scene activation, no Orbit/HPF/full bus state payload, no physical hardware FAT. Current localStorage scene remains UI-only. P4 Stage 2 adds transactional Studio/Shows archive+blobs and backup; Stage 3 binds authoritative GUI; Stage 4 gates real recall behind epoch/ACK and MUTE. #15 crackle remains open.

Gates

Require Windows MSVC/CTest and existing GUI smoke checks before any merge. CI PASS cannot replace real Windows Audio Setup first-paint and ASIO/WASAPI FAT.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T21:34:14.458786Z 80c25c1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit faee66f into main Oct 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant