You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
P0: snapshot save/recall UI must fail atomically on storage and malformed data #132
Source-verified regression in main@bc11edf (2026-10-29)
web/app.js currently mutates scenes and sceneIdxbeforepersistSession() in saveMixerSnapshot(). When localStorage.setItem throws (quota / denied storage), only the userSnapshots object is rolled back; the list and selected index remain changed, making a never-saved scene appear active. loadSnapshotByIndex(i) also updates sceneIdx before invoking applySession(), which returns early on malformed schema but the rejected scene is still selected/persisted. persistSession() writes current, snapshots, chains as three independent keys, so a mid-write failure can persist a partial generation.
Incremental repair, no visual/engine redesign
Keep candidate list/index/state local until the entire storage transaction is successful; on errors restore the prior UI projection and explicitly report failure.
Reject malformed/unsafe/duplicate names and reject invalid data before selecting and applying. Make applySession() validate before mutation and return a boolean; do not mark failed recall as success.
Use a single versioned, bounded envelope for UI-only preview state with one localStorage key + migration from the three legacy keys; test quota/unavailable/partial old data and factory name protections. Do not misrepresent this as native VST3 recall.
Add realistic browser interaction cases for save, restart, overwrite confirm, delete confirm, corruption, storage denied and rollback. Preserve exact web/styles-src/standalone build parity, BTN-180 grey-off/green-on, no extra animation or polling.
Fixed browser/UI-only snapshot atomicity by merged PR #154 (main squash a5e2c309025f83c24f27c42b730162ae7efac22d). The former 3 independent localStorage keys have been replaced by one versioned envelope; snapshot save/delete/recall and session import validate and commit before mutating visible state. On rejected/blocked storage, no false-success scene/index mutation. Legacy multi-key read/migration remains. Deterministic blocked-storage, invalid-state, and successful-restore tests were included in the existing Chromium/Node CI (run 40866136735 SUCCESS). This resolves the UI-only bug, not native all-VST3 Show/session recall or hardware FAT.
Activity
masarray commentedon Oct 29, 2026
Fixed browser/UI-only snapshot atomicity by merged PR #154 (main squash
a5e2c309025f83c24f27c42b730162ae7efac22d). The former 3 independent localStorage keys have been replaced by one versioned envelope; snapshot save/delete/recall and session import validate and commit before mutating visible state. On rejected/blocked storage, no false-success scene/index mutation. Legacy multi-key read/migration remains. Deterministic blocked-storage, invalid-state, and successful-restore tests were included in the existing Chromium/Node CI (run 40866136735 SUCCESS). This resolves the UI-only bug, not native all-VST3 Show/session recall or hardware FAT.