Skip to content

SUPERSEDED by #13 — old GUI v0.5 × P2.5 integration (archive only) - #11

Closed
masarray wants to merge 4 commits into
feature/p25-live-preset-graph-swapfrom
integration/p25-gui-engine-reconciled
Closed

masarray wants to merge 4 commits into
feature/p25-live-preset-graph-swapfrom
integration/p25-gui-engine-reconciled

Conversation

@masarray

Copy link
Copy Markdown
Owner

WHY

The premium GUI branch and the audio-engine P2.5 branch have diverged. Merging whole files blindly can re-enable fake VU meters, break FabFilter/RX inserts or erase channel-identity and professional master-strip UX. This non-destructive integration keeps both reference branches intact.

Integration source of truth

  • Engine: feature/p25-live-preset-graph-swap @ 7a769105 (native JUCE, VST3 catalog, FabFilter/RX compatibility, .armix states, P2.5 prepared graph and RT telemetry)
  • Visual: fix/fader-thumb-symmetry-polish @ 7d489203 (approved polished mixer, tactile metal assets, channel identity editor, center-snap PAN, red metal Master fader, separate clip/peak indicators, full GUI UX)
  • Adapter: preserve native events and real hardware metering. The new GUI's masterL and masterR meters use actual native L/R peak values. Fake browser sinusoids are explicitly shut down in JUCE. Channel 2–12 and master FX/master PAN stay truthful visual previews (non-native controls disabled).
  • Added GitHub Pages preview assets and visual tests, cross-thread reconcile ledger, and Windows native integration contract tests.

Merge/qualification rules

  • DO NOT merge to main until Windows native CI + Chromium GUI smoke are both GREEN and Windows hardware verifies FabFilter/RX/ArSonKuPik insert/edit/bypass and P2.5 live preset recall.
  • This is a candidate integration branch, not a public stable release. No plugin binaries or old PRs deleted.

See docs/PROGRESS_RECONCILIATION_2026-10-25.md for the exact lineage, feature support matrix, and next phases.

Copy link
Copy Markdown
Owner Author

CANONICAL RECONCILIATION CHECKPOINT — BOTH CI GREEN

Freeze commit (do not rewrite): 351eb79bd8df775aadb4810c1cf53f7410cea411

QA verified: MSVC Windows release EXE + packaging; Node native GUI/VST3/graph contract tests; CTest 2/2 PASS (RealtimeControlPrimitives includes 12,000 concurrent handoffs; NativePresetZipRoundTrip checks binary state and corruption); latest tactile PNG asset integrity, 13-fader geometry, PAN/no-jump, channel and master interactive GUI, FX interaction and no browser JS errors via Chromium.

Integrity: Critical C++ source and native tests remain SHA-identical to P2.5 engine parent. GUI tracks the newest premium branch fix/fader-thumb-symmetry-polish (channel identity, master strip, fader/metal buttons/PAN); native adapter updated for its DOM, with real Channel 1 and Master L/R meters only, no fake VU oscillators. Master FX/PAN + 11 inactive channels are visually marked or disabled in JUCE. Standalone HTML JS and CSS now byte-synchronized with canonical source. Site landing and README are current, and historical README is preserved in docs.

NOT HARDWARE-QUALIFIED: this reconciled EXE has not yet been run with FabFilter, iZotope RX, or ArSonKuPik on user's PC. Earlier P2.4.1 FabFilter/RX insertion success is preserved as feedback, not proof for this revision. P2.5 recall is a two-buffer fade and may dip; ADD/REMOVE/REORDER still detach. Do not merge to main or publish stable without the targeted on-device smoke + longer soak.

Next phase: verify GUI visual parity and functional VST3 on Windows hardware, then progress P2.5.2 seamless chain operations and P2.6 true native multichannel. Avoid remerging old branches or replacing engine with standalone demo sources.

Copy link
Copy Markdown
Owner Author

Superseded by GUI-approved native integration PR #13

The GUI owner approved v0.8 and merged it into main in #2. The cross-thread checkpoint has now been merged via #12, with AGENTS.md and GUI baseline lock.

This draft PR #11 references GUI v0.5 / commit 7d489203 and has a native-feature-branch base, so merging it now could overwrite the newer approved v0.8 GUI. Its functionality and native integration contracts are represented in PR #13, which explicitly branches from the approved GUI main.

Disposition: Close this outdated integration PR without merging. Its source branch remains intact for traceability. Native engine and all stacked PRs remain pending independent Windows/real-hardware validation; do not misreport any of them as a completed release.

@masarray masarray changed the title Reconcile all ArSonMix threads: premium GUI v0.5 + optimized P2.5 VST3 engine SUPERSEDED by #13 — old GUI v0.5 × P2.5 integration (archive only) Oct 25, 2026
@masarray masarray closed this Oct 25, 2026

Copy link
Copy Markdown
Owner Author

Reconciliation status: superseded for merging by PR #13 (MERGED into main). This PR #11 retains older GUI v0.5 artifacts. Do not merge PR #11 or copy its whole frontend onto main. The approved v0.8 GUI and advanced P2.5 engine were safely integrated in #13, main merge SHA f6a957698d0c5980b750866ff55a075da4ec2a9b. Both Windows native and Chromium visual CI succeeded on the merged PR head d3ad468f30d9937ac8577b306774f0b23046bf7b. Keep this draft only for historical reference/evidence; further work starts from latest main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant