Skip to content

Lock approved ArSonMix GUI v0.8 across main, agents, and tested Pages - #12

Merged
masarray merged 1 commit into
mainfrom
chore/lock-approved-gui-v08-baseline
Oct 25, 2026
Merged

masarray merged 1 commit into
mainfrom
chore/lock-approved-gui-v08-baseline

Conversation

@masarray

Copy link
Copy Markdown
Owner

Approved GUI checkpoint — owner sign-off on 2026-10-25

PR #2 has been merged; approved GUI code is immutable in the checkpoint branch checkpoint/gui-v0.8-approved-20261025 at SHA 343692fc9b702661a8455cca30f0ffd108907324.

This PR publishes the cross-thread source of truth:

  • Root AGENTS.md for all AI coding threads and engineers
  • Canonical docs/GUI_BASELINE_LOCK_2026-10-25.md with every locked visual/interaction invariant and native-integration limitations
  • Updated README.md, accurate current GUI status, and no false audio/VST3 claims
  • GitHub Pages now derives from the tested main commit, never the old GUI branch; CI-gated, SHA-pinned workflow_run producer, plus manual dispatch
  • tests/gui_baseline_lock_test.py and GUI smoke extension for checkpoint/parity

The older stacked native PRs (#1, #3–#11) are retained as unfinished draft engine work, not incorrectly closed, and PR #11 must adapt to this approved GUI rather than overwriting it.

Merge gate

  • Chromium GUI smoke + asset parity tests pass on this PR.
  • After merge, main UI smoke must pass and trigger production Pages successfully.
  • Published preview/build.json must report a commit on main.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T06:11:19.922744Z 95171cc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit ce82c5c into main Oct 25, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95171cc791

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

uses: actions/checkout@v4
with:
ref: fix/fader-thumb-symmetry-polish
ref: ${{ github.event_name == 'workflow_run' && github.event.workflow_run.head_sha || 'main' }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Require a green smoke result for manual production deployments

When this workflow is manually dispatched while the latest main Chromium smoke is pending or failed, this checkout selects current main anyway: the build-job condition permits every non-workflow_run event, and the subsequent build steps never run tests/ui_smoke.py or verify a successful smoke result for the selected SHA. A GUI regression that passes syntax and asset checks can therefore reach production despite the new gate. Require a successful main smoke for the exact SHA on manual dispatch too, or run the Chromium smoke before deploying. This violates the production-deployment requirement in AGENTS.md.

AGENTS.md reference: AGENTS.md:L14-L14

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant