Repository navigation
Lock approved ArSonMix GUI v0.8 across main, agents, and tested Pages - #12
Conversation
… tested main commits
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95171cc791
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: fix/fader-thumb-symmetry-polish | ||
| ref: ${{ github.event_name == 'workflow_run' && github.event.workflow_run.head_sha || 'main' }} |
There was a problem hiding this comment.
Require a green smoke result for manual production deployments
When this workflow is manually dispatched while the latest main Chromium smoke is pending or failed, this checkout selects current main anyway: the build-job condition permits every non-workflow_run event, and the subsequent build steps never run tests/ui_smoke.py or verify a successful smoke result for the selected SHA. A GUI regression that passes syntax and asset checks can therefore reach production despite the new gate. Require a successful main smoke for the exact SHA on manual dispatch too, or run the Chromium smoke before deploying. This violates the production-deployment requirement in AGENTS.md.
AGENTS.md reference: AGENTS.md:L14-L14
Useful? React with 👍 / 👎.
Approved GUI checkpoint — owner sign-off on 2026-10-25
PR #2 has been merged; approved GUI code is immutable in the checkpoint branch
checkpoint/gui-v0.8-approved-20261025at SHA343692fc9b702661a8455cca30f0ffd108907324.This PR publishes the cross-thread source of truth:
AGENTS.mdfor all AI coding threads and engineersdocs/GUI_BASELINE_LOCK_2026-10-25.mdwith every locked visual/interaction invariant and native-integration limitationsREADME.md, accurate current GUI status, and no false audio/VST3 claimsmaincommit, never the old GUI branch; CI-gated, SHA-pinnedworkflow_runproducer, plus manual dispatchtests/gui_baseline_lock_test.pyand GUI smoke extension for checkpoint/parityThe older stacked native PRs (#1, #3–#11) are retained as unfinished draft engine work, not incorrectly closed, and PR #11 must adapt to this approved GUI rather than overwriting it.
Merge gate
mainUI smoke must pass and trigger production Pages successfully.preview/build.jsonmust report a commit onmain.