Repository navigation
Merge native P2.5 VST3 engine into approved GUI v0.8 without visual rollback - #13
Conversation
… VST3 engine, truthful meters, native bridge and CI
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea239b8c7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
REQUIRED — approved ArSonMix GUI v0.8 baseline and main checkpointThe product owner approved the GUI, now officially merged into Canonical current main checkpoint: PR #11 (old GUI v0.5 reconciliation) is now closed as superseded by this PR, not merged; its historical source remains untouched. The native stack PRs #1 and #3–#10 remain draft / pending. Mandatory before merging #13
GitHub Pages currently serves |
…integrating tested P2.5 native engine
… retirement and callback handoff
|
Confirmed merged into main: Windows-native CI PASS: https://github.com/masarray/arsonmix/actions/runs/40168658412 GUI PR #2 / PR #12 visual lock preserved. Earlier PRs #1, #3-#11 remain as historical review references; do not merge stale UI source. Native audio remains experimental, hardware/third-party plugin FAT pending. Subsequent development must branch from latest main. |
Why this is the safe reconciliation PR
GUI v0.8 was already merged into main by PR #2. Old PR #11 is based on v0.5 and would roll back the latest visual. This PR is branched directly from
main@aff95a7c, retaining 100% of itsweb/styles.css, existing v0.8 controls, left rail, and entire browser visual smoke suite, while adding the newest P2.5 native engine.Native capabilities added without losing v0.8
web/app.jsis not overwritten by old integration code; the only edit is to stop sin-wave preview meters when running inside JUCE.web/index.htmlonly addsbridge.jsandmonitor.js, keeping v0.8 layout unchanged. Standalone HTML synchronizes byte-for-byte with the current main CSS and JS.Safety / nonclaims
Do not call hardware-qualified or stable. P2.5 snapshot uses short de-click fades, not dual-DSP seamless transitions. ADD/REMOVE/REORDER still detach audio callback, vendor-specific Windows trial required. This merge establishes one coherent development
mainbaseline for next phases.Merge gate
Windows MSVC Release and CTest/native JS checks green, Chromium premium GUI visual smoke green, merge commit via standard merge (retain history).