Skip to content

Merge native P2.5 VST3 engine into approved GUI v0.8 without visual rollback - #13

Merged
masarray merged 3 commits into
mainfrom
integration/main-v08-gui-p25-native
Oct 25, 2026
Merged

masarray merged 3 commits into
mainfrom
integration/main-v08-gui-p25-native

Conversation

@masarray

Copy link
Copy Markdown
Owner

Why this is the safe reconciliation PR

GUI v0.8 was already merged into main by PR #2. Old PR #11 is based on v0.5 and would roll back the latest visual. This PR is branched directly from main @ aff95a7c, retaining 100% of its web/styles.css, existing v0.8 controls, left rail, and entire browser visual smoke suite, while adding the newest P2.5 native engine.

Native capabilities added without losing v0.8

  • Native JUCE ASIO/WASAPI, real Channel 1 VST3 catalog/add/editor/FabFilter/RX-compatible bus layouts, bypass, 1-input + stereo master meters, realtime diagnostics, .armix archive, P2.5 prepared live preset graph handoff.
  • Main web/app.js is not overwritten by old integration code; the only edit is to stop sin-wave preview meters when running inside JUCE.
  • Main web/index.html only adds bridge.js and monitor.js, keeping v0.8 layout unchanged. Standalone HTML synchronizes byte-for-byte with the current main CSS and JS.
  • Native bridge updated for v0.8 DOM/FX buttons, keeps demo-only strip channels and Master FX/PAN explicitly labeled or disabled, real L/R Master meters, LUFS-I/dBTP display not measured.
  • Restored all engine C++ and its tests intact from GREEN P2.5 checkpoint; added Windows native CI and a new main v0.8 integration regression contract.
  • README and cross-thread reconciliation ledger keep historical context; original PRs and checkpoints remain.

Safety / nonclaims

Do not call hardware-qualified or stable. P2.5 snapshot uses short de-click fades, not dual-DSP seamless transitions. ADD/REMOVE/REORDER still detach audio callback, vendor-specific Windows trial required. This merge establishes one coherent development main baseline for next phases.

Merge gate

Windows MSVC Release and CTest/native JS checks green, Chromium premium GUI visual smoke green, merge commit via standard merge (retain history).

… VST3 engine, truthful meters, native bridge and CI
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T06:13:23.745791Z ea239b8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea239b8c7f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/bridge.js Resolved
Comment thread src/Main.cpp Resolved
Comment thread web/bridge.js Resolved

Copy link
Copy Markdown
Owner Author

REQUIRED — approved ArSonMix GUI v0.8 baseline and main checkpoint

The product owner approved the GUI, now officially merged into main in #2 and locked cross-thread by #12.

Canonical current main checkpoint: ce82c5c85b35299c8f2ee141063f3b17264041e5
Exact approved GUI source: 343692fc9b702661a8455cca30f0ffd108907324
Recovery branch: checkpoint/gui-v0.8-approved-20261025
Agent rules: AGENTS.md
GUI requirements: docs/GUI_BASELINE_LOCK_2026-10-25.md

PR #11 (old GUI v0.5 reconciliation) is now closed as superseded by this PR, not merged; its historical source remains untouched. The native stack PRs #1 and #3–#10 remain draft / pending.

Mandatory before merging #13

  1. Reconcile this branch with current main @ ce82c5c; its previous base was aff95a7c. Preserve the new README, AGENTS.md, lock document and Pages main-only SHA-pinned workflow. Do not overwrite these with older native-branch documentation or restore the old preview-branch publisher.
  2. Preserve exact premium GUI v0.8 controls/assets/13-strip geometry, left-rail, 6-slot FX rack, master LUFS-I+dBTP visual, and standalone parity. Integrate native control/meter sources via focused adapters, not blanket file replacement.
  3. Windows MSVC CI + native contracts + Chromium GUI smoke must be GREEN. Confirm real-device FabFilter/RX/ArSonKuPik insert/bypass, actual driver output, true-meter source, and P2.5 graph handoff stability on Windows before making hardware/release claims. Treat native-only channel coverage honestly.
  4. Report separate GUI baseline acceptance vs Windows native hardware qualification. The latter is not granted by the GUI sign-off.

GitHub Pages currently serves main at ce82c5c with successful Pages CI. This PR #13 stays open until native checks and reconciliation pass.

@masarray
masarray merged commit f6a9576 into main Oct 25, 2026
2 of 3 checks passed

Copy link
Copy Markdown
Owner Author

Confirmed merged into main: f6a957698d0c5980b750866ff55a075da4ec2a9b. Permanent recovery checkpoint: checkpoint/main-v08-p25-native-merged-20261025. Final validated head: d3ad468f30d9937ac8577b306774f0b23046bf7b.

Windows-native CI PASS: https://github.com/masarray/arsonmix/actions/runs/40168658412
Chromium approved GUI v0.8 smoke PASS: https://github.com/masarray/arsonmix/actions/runs/40168658503
Windows EXE artifact: https://github.com/masarray/arsonmix/actions/runs/40168658412/artifacts/12589702043

GUI PR #2 / PR #12 visual lock preserved. Earlier PRs #1, #3-#11 remain as historical review references; do not merge stale UI source. Native audio remains experimental, hardware/third-party plugin FAT pending. Subsequent development must branch from latest main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant