Skip to content

P2.5.1 safety: align native gain/mute state and guard VST3 editor retirement - #14

Merged
masarray merged 9 commits into
mainfrom
fix/p251-native-ui-authority-editor-guard
Oct 25, 2026
Merged

masarray merged 9 commits into
mainfrom
fix/p251-native-ui-authority-editor-guard

Conversation

@masarray

Copy link
Copy Markdown
Owner

Context

Follow-up to merged GUI v0.8 + experimental P2.5 native engine PR #13 (f6a9576). Addresses three existing Codex review findings without changing locked GUI v0.8 app.js/styles.css/standalone layout.

Fixes

  • P1: Publish authoritative DSP Channel 1/Master dB gain values in native 12 Hz status and reconcile Channel 1 fader/PAN/MUTE + Master fader/MUTE from native status. Stale WebView localStorage and demo snapshots can no longer persist as live control truth.
  • P2: Process .master-strip before checking source .rack, so unsupported Master PAN and FX preview are disabled after any re-render.
  • P2: Refuse fxEditor while isGraphSwitchPending(); avoid opening VST3 editors for plugins awaiting retirement.
  • Add exact integration regression contract assertions.

Safety gate

Only merge if Windows native Release, CTest (incl. 12,000 graph handoffs), GUI Chromium tests PASS. Hardware FAT remains separately required. No UI visual baseline edits. No claim of live-safe structural FX edits or hardware release.

Lineage

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T07:21:04.000895Z 0b77771 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b77771529

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/bridge.js Outdated
Comment on lines +576 to +577
if(inputDirty && typeof renderMixer==="function")renderMixer();
else if(masterDirty && typeof renderMaster==="function")renderMaster();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve active drag elements during native status reconciliation

In the native host, a status event can arrive during a fader/PAN drag with values older than the latest pointer movement: web/app.js updates local state immediately but batches parameter sends through requestAnimationFrame. This mismatch triggers renderMixer() or renderMaster(), replacing the element retained in drag.el. Subsequent pointer movements measure the detached element's zero-sized bounding box, reducing fader travel to 24 px or PAN travel to 1 px and causing abrupt gain/pan jumps, potentially to maximum gain. Reconcile controls in place and protect in-flight edits from stale status rather than rebuilding active drag elements. This violates the locked no-jump fader interaction.

AGENTS.md reference: AGENTS.md:L8-L8

Useful? React with 👍 / 👎.

@masarray
masarray merged commit ab732c5 into main Oct 25, 2026
2 checks passed

Copy link
Copy Markdown
Owner Author

Final merged + post-merge verification — 2026-10-25

Merge commit: ab732c5060fdd63656a47cd59604a1c9f4fb0909 on main.

Release boundary: this is an accepted experimental development baseline, not hardware-qualified for live broadcasting. Physical ASIO/WASAPI, FabFilter/iZotope RX load/edit/bypass, recall, 30+ minute soak, and latency/dropout safety are outstanding. Next engine milestone P2.5.2 live-safe structural FX operations; do not revert locked v0.8 GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant