Repository navigation
P2.5.1 safety: align native gain/mute state and guard VST3 editor retirement - #14
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b77771529
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if(inputDirty && typeof renderMixer==="function")renderMixer(); | ||
| else if(masterDirty && typeof renderMaster==="function")renderMaster(); |
There was a problem hiding this comment.
Preserve active drag elements during native status reconciliation
In the native host, a status event can arrive during a fader/PAN drag with values older than the latest pointer movement: web/app.js updates local state immediately but batches parameter sends through requestAnimationFrame. This mismatch triggers renderMixer() or renderMaster(), replacing the element retained in drag.el. Subsequent pointer movements measure the detached element's zero-sized bounding box, reducing fader travel to 24 px or PAN travel to 1 px and causing abrupt gain/pan jumps, potentially to maximum gain. Reconcile controls in place and protect in-flight edits from stale status rather than rebuilding active drag elements. This violates the locked no-jump fader interaction.
AGENTS.md reference: AGENTS.md:L8-L8
Useful? React with 👍 / 👎.
Final merged + post-merge verification — 2026-10-25Merge commit:
Release boundary: this is an accepted experimental development baseline, not hardware-qualified for live broadcasting. Physical ASIO/WASAPI, FabFilter/iZotope RX load/edit/bypass, recall, 30+ minute soak, and latency/dropout safety are outstanding. Next engine milestone P2.5.2 live-safe structural FX operations; do not revert locked v0.8 GUI. |
Context
Follow-up to merged GUI v0.8 + experimental P2.5 native engine PR #13 (
f6a9576). Addresses three existing Codex review findings without changing locked GUI v0.8 app.js/styles.css/standalone layout.Fixes
.master-stripbefore checking source.rack, so unsupported Master PAN and FX preview are disabled after any re-render.fxEditorwhileisGraphSwitchPending(); avoid opening VST3 editors for plugins awaiting retirement.Safety gate
Only merge if Windows native Release, CTest (incl. 12,000 graph handoffs), GUI Chromium tests PASS. Hardware FAT remains separately required. No UI visual baseline edits. No claim of live-safe structural FX edits or hardware release.
Lineage