Repository navigation
π docs: track Goose upstream after its move to the Agentic AI Foundation - #10636
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Check report (fork branch β hive cannot push here): every failing check on this PR is the v5 baseline fingerprint tracked in #10623 (RE2 Fix: sync your branch with v5 and push β π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Read the diff against the v5 tree. The documentation is accurate to the code, and the source-of-truth switch is consistent across the three places that download Goose. Looks correct to me, with one thing I could not verify.
What I verified:
docs/goose-at-scale.mdclaims match the tree: the refusal gateHIVE_GOOSE_DANGEROUSLY_RUN_UNCONFINEDis the oneconfig/backends.confenforces;contribute-check,contribute-setup,contribute-hiveexist (Justfile:312,:347,:888);CONTRIBUTOR_MODE=headlessis honoured (Justfile:1570, forwarded at:1841); the relay really launchesgoose run --no-session -t(Justfile:3333, the embeddedcontributor-relay.jstable). Both relative links (../src/docs/contributor-relay.md,../src/docs/sandbox-isolation.md) resolve.src/Dockerfile,src/Dockerfile.contributorandsrc/scripts/cli-pin-bump.shall move fromblock/goosetoaaif-goose/goose; after the change noblock/gooserelease URL remains, andtest-cli-pin-bump.shnow asserts exactly that.
Open question (not a finding): the Dockerfiles keep the existing GOOSE_VERSION=1.53.0 and per-arch SHA256 pins while changing the download host to the new org. If the repo was transferred on GitHub the assets are byte-identical and this is fine; I did not fetch the external release to confirm. The image build in CI is the real check here.
Scope note: the title says "docs", but the PR also changes the image download source and the pin-bump script. That is tightly coupled to the doc claim "both Hive images use that release source", so it reads as intentional rather than creep.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Use canonical aaif-goose release locations without changing verified pins. Document headless Goose contributor operation, AAIF eligibility inquiry, and the upstream Ready-issue contribution gate. Refs hivecommons#10627 Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Hive-Run: hivecommons#10627 Hive-Plan: issue-10627-ecosystem-source-verification-and-documentation Hive-Spec: issue-10627#acceptance Signed-off-by: mendezr <mendezr@users.noreply.github.com>
9705782 to
5681d62
Compare
clubanderson
left a comment
There was a problem hiding this comment.
Reviewed after rebase onto current v5. Goose canonical AAIF source and v1.53.0 assets/checksums verified; Dockerfile pins stay SHA-verified; docs clarify Hive is not AAIF-hosted/endorsed. Script test covers the new release source. No CI/security weakening found.
|
LGTM label has been added. DetailsGit tree hash: 6b0171df9ec80503c39fcf72c301be64c42461bd |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Fixes #10627.
aaif-goose/gooserepo in both Dockerfiles and the pin resolver; retain version1.53.0and both SHA256 pins.Verification
block/goosetoaaif-goose/goose.v1.53.0Linux release tarballs and checked them withsha256sum -c: x86_64 OK; aarch64 OK. Release API digests also match both existing pins.src/scripts/test-cli-pin-bump.sh.AGENTS.md; the existing CLI pin CI workflow runs the shell syntax checks and regression suite. No Go changes.Remaining upstream handoff
No Goose docs PR was opened: its current AGENTS.md and CONTRIBUTING.md require a Ready issue before external implementation/PRs, and ask humans to write new issues themselves. An open-issue search found no Hive proposal. A human sponsor must file the Goose documentation proposal and obtain Ready status before this page can be proposed upstream. This PR does not bypass that gate or claim all acceptance criteria are met.
β hive: backend=pi model=openai-codex/gpt-6.1-sol
π Hive Agent:
contributor| SHA:9705782a6