Repository navigation
📖 docs: add gh-aw on-ramp and agentics gallery entry - #10631
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Conclusion: this looks correct to me and matches the body; one low-severity doc nuance below, nothing blocking.
What I verified
src/deploy/gh-aw/prepare.pyemits exactly the fieldsbin/issue-classifier.shreads per item (repo,number,title,labels,author,created_at— classifier lines ~155-159 parsecreated_atwithfromisoformat, which GitHub'sZtimestamps satisfy after the.replace). Admission fails closed on closed issues, PRs,hold*/lfx*/needs-human/blockedlabels, and anyKeyError/TypeErrorfrom a malformed payload exits 1 with no stdout — so the engine step never runs on refusal.bin/issue-classifier.sh:13-14— the two new env overrides keep the original paths as defaults; deployed behaviour is unchanged. The classifier writes the enriched result back to$INPUT_FILEin place, which is whyhive.md's prompt can readhive-actionable.jsonafter the pre-agent step.hive.mdfrontmatter:permissions: contents/issues: read,tools.bash: ["cat"], no safe-outputs — consistent with the "report-only" claim..github/workflows/gh-aw-compile.yml— the lock-file check asserts the admission step index precedesagentic_executionand that the engine step has noalways()/failure()condition;test_prepare.pypinsHIVE_PROJECT_YAMLexplicitly so it doesn't depend on the fallback below.
One nuance (docs, low) — hive.md sets HIVE_PROJECT_YAML: ${{ github.workspace }}/config/hive-project.yaml. When that file is absent, bin/issue-classifier.sh:16-26 falls through to find <repo>/examples -name hive-project.yaml, and in a hive checkout that resolves to examples/kubestellar/hive-project.yaml. So src/deploy/gh-aw/README.md's statement that "missing configuration uses the classifier's built-in defaults" is true in an adopter's repo (no examples/), but anyone trying the sample from a hive clone will silently classify with the KubeStellar example's lanes/keywords. Worth one sentence in the README, or pointing the sample at config/hive-project.yaml.example as the default.
I have not changed anything on this PR.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Check report (fork branch — hive cannot push here): every failing check on this PR is the v5 baseline fingerprint tracked in #10623 (RE2 Fix: sync your branch with v5 and push — 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Follow-up check report (fork branch — hive cannot push here): incident #10623 is now closed and Fix: 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Hive-Run: hivecommons#10625 Hive-Plan: gh-aw-on-ramp-and-gallery Hive-Spec: hivecommons#10625#acceptance Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Signed-off-by: mendezr <mendezr@users.noreply.github.com>
abc169c to
ba0bae2
Compare
clubanderson
left a comment
There was a problem hiding this comment.
Reviewed after rebase onto current v5. gh-aw facts match GitHub Agentic Workflows docs; workflow uses pinned checkout, minimal read permissions, no secrets on untrusted PRs, and compiles without engine credentials. prepare.py is JSON-only/no shell-out, and issue-classifier changes are env override defaults only. No required changes found.
|
LGTM label has been added. DetailsGit tree hash: b6621901821be59800aa4f78df801e0ab7784f60 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Fixes #10625.
src/deploy/gh-aw/hive.md: manually dispatched, report-only issue triage, with deterministic admission and the real Hive classifier running before the gh-aw engine.Safety / scope
The sample rejects closed issues, PRs, held/blocked/LFX issues, and
needs-human. It does not run the write-capable queue enumerator or merge gate, grants no repository-write permissions/safe outputs, and never installs an active agent workflow in this repository. A failed deterministic preflight stops the engine. Existing classifier defaults remain unchanged; only optional input/log path overrides are added for Actions use.The upstream submission uses the gallery's established community-maintained external-link pattern, rather than duplicating a workflow with companion Hive scripts in agentics. Engine credentials are needed only when an adopter runs the sample, not to compile it.
Validation
Not run locally per
AGENTS.md; CI is the validation authority. Added tests for accepted input/custom classification rules, excluded labels, closed issues/PRs, and malformed input, plus compilation and generated-step checks. Manually reviewed commands against gh-aw's schema/extension interface and the pinned compiler'sagentic_executionstep; reviewed relative links andgit diff --check.— hive: backend=pi model=openai-codex/gpt-6.1-sol
🐝 Hive Agent:
contributor| SHA:abc169ca6