[OffgridwithJD]

Part of #1341, the object-store twin-parity item: objstore_crlf.sh had no pytest twin.

The twin (test_objstore_crlf.py)

One test, all 5 shell checks by name, added to COMPLETE.

• Read path: read_parquet with a CR/LF in the URL path is refused naming "CR or LF", and a listener of the file's own (a socket in a thread, standing in for the shell's script) receives nothing carrying the injected line.
• REST path: the REST catalog client's request goes through the same connect path, so a catalog_uri with a CR/LF is refused the same way.
• Backend: alive after each attempt.

Twin proof. The request-line guard on the URL path removed, PG17, main 4027b8d against this branch:

	shell (main, and this branch)	pytest twin
guard removed	2 + 3 failed: no "CR or LF" refusal, and the listener received the injected line	red at the same first check, "a CR/LF in the URL path is rejected before the request is sent: got 0"

Evidence

• Clean: objstore_crlf 5/5 and the twin passed on each of PG 15–19.
• Ledger: objstore_crlf had no rows, so it is seeded with all 5, three dated by the mutation. 2361 → 2366 rows, the census 1801 → 1803, and suites_not_covered 246 → 245.
• Gate: rc=0.
• Counts: TESTS.md section 105, and cluster_tests 534 → 535. Several open PRs of mine take section 105 and move these counts, so each restates and renumbers on rebase.
• Database-free set: 429 passed.

🤖 Generated with Claude Code

[jdatcmd]

Approving 98363af on content. Reproduced on PG18.

• Green: shell 5/5; pytest 1 passed; compare_to_bash: 5 literal matches, 0 missing.
• Red: with the request-path CR/LF guard disabled (objstore/columnar_objstore_module.c:381), both twins fail the same three names, which are exactly the three rows the ledger dates:
  FAIL a CR/LF in the URL path is rejected before the request is sent: got [0] want [1]
FAIL no injected line reached the listener (no request splitting): got [1] want [0]
FAIL a CR/LF in a REST catalog_uri is rejected too (objstore_http_request path): got [0] want [1]

A note, not blocking: the twin checks only the primary message for "CR or LF", where the shell greps all of stderr.

Before merge: a rebase. TESTS.md §105, expected_tests.txt and the budget conflict.

[OffgridwithJD]

Rebased onto 57f6e0e (#1401), on top of #1403. The new head is d6ebf5d. Only the count files changed, so this needs your re-approval.

• Same patch: outside the count files, the changed lines match the head you approved, except for TESTS.md section renumbers where main's new sections took the old numbers.
• The ledger is restated on main's census and agrees with its tsv: 2791 rows, 2097 never, 694 dated, read back from the file. Each changed paragraph's arithmetic starts from main's last numbers.
• cluster_tests 567, by collection over the cluster files on this tree. guard_tests 433 is unchanged.
• Runs on the rebased tree at 217f23b, PG17 and PG18: PG17 harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped; PG17 pytest: 41 passed in 9.29s; PG18 harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped; PG18 pytest: 41 passed in 9.50s. harness_selftest 1245/1245 and docs_style passed on both. fix: a read inside an aborted inner block no longer loses the enclosing statement's rows (#1360) #1403 has since changed the write path's subtransaction flush, which every suite here exercises, so I'm re-running them all on 758039f and will post the result. CI runs PG17 and PG18 on this head.

🤖 Generated with Claude Code

[OffgridwithJD]

Re-run finished on the tree after #1403 (758039f or later). Everything is green, so the head above stands:

• PG17 docs_style: passed
• PG17 harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped
• PG17 pytest: 42 passed in 9.31s
• PG17 vacuum_lock_privilege: 19 passed + 0 failed + 0 unrunnable + 0 skipped
• PG18 docs_style: passed
• PG18 harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped
• PG18 pytest: 42 passed in 9.32s
• PG18 vacuum_lock_privilege: 19 passed + 0 failed + 0 unrunnable + 0 skipped

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto 7da848d (#1432, #1409). The new head is ddcb271; only the count files changed, so please re-approve this head.

• Ledger, restated on main's census and read back from the tsv: 2878 rows, 2181 never, 697 dated, suites_not_covered 231. A branch that seeds a suite moves suites_not_covered one below main's 232, derived from the runner's suite list.
• Counts by collection: cluster_tests 568, guard_tests 435.
• What the earlier runs still cover: test: the Iceberg REST readers' server-file gate, and no borrowed environment token (#1341 items 8, 9, 14, 52) #1409 and test: setting an attribute on pgc_conn or its cursors raises instead of doing nothing (#1420) #1432 change no src/, so the PG17 and PG18 runs posted above still describe this code. test: setting an attribute on pgc_conn or its cursors raises instead of doing nothing (#1420) #1432 does change the pytest proxies, which now refuse attribute assignment, so I'm re-running every twin on PG18 and will post if anything moves. A scan of this branch's twins finds no assignment to pgc_conn or a cursor.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at ddcb271. Compared with 98363af, the head I approved, file by file: the changed lines are the same, apart from the count files (check_ledger_budget.txt, expected_tests.txt) and, in #1378/#1379/#1380/#1383, the TESTS.md section number, now 115.

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto 1f7b5da (#1411, #1412, #1417, #1418). The new head is dd083da. Only the count files changed, plus TESTS.md section numbers where main took 115, so please re-approve this head.

• Ledger: 2989 rows, 2280 never, 709 dated, read back from the tsv, with suites_not_covered 230.
• Collection: cluster_tests 571, guard_tests 435.
• Re-running every suite and twin on PG18: fix: REINDEX reclaims the entries of deleted rows no snapshot can see (#1407) #1412 changes the index build in src/, and these suites use indexes. I'll post the results here; CI runs PG17 and PG18 on this head.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at dd083da, the rebase onto 1f7b5da. File by file, the changed lines are the same as the head I approved before, apart from the count files and, in #1378/#1379/#1380/#1383, the TESTS.md section number.

🤖 Generated with Claude Code

[OffgridwithJD]

The PG18 re-run on this head (dd083da, on 1f7b5da with #1412's index-build change) is all green:

• docs_style: passed
• harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped
• pytest: 41 passed in 6.85s

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto 37ea557 (#1414, #1425). The new head is 364f99c. Only the count files changed, so please re-approve this head.

• Ledger: 3003 rows, 2283 never, 720 dated, read back from the tsv.
• Collection: cluster_tests 576, guard_tests 435.
• Runs: test: the settings reference is held to the server (#1341 items 42, 57, 83) #1414 and test: megabyte-scale values are stored exactly (#1341) #1425 change no src/, so the PG18 re-run posted above, on 1f7b5da, still covers this code.

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto f2bd5f1 (#1427). The new head is 1b6f282. Only the count files changed, so please re-approve this head.

• Ledger: 3012 rows, 2284 never, 728 dated, read back from the tsv.
• Collection: cluster_tests 577, guard_tests 435.
• Runs: test: tables that skip WAL at wal_level=minimal survive a crash (#1341) #1427 changes no src/, so the PG18 re-run posted above still covers this code.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at 1b6f282, the rebase onto f2bd5f1. File by file, the changed lines are the same as the head I approved before, apart from the count files and, in #1378/#1379/#1380/#1383, the TESTS.md section number.

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto d5c0a5e (#1391). The new head is b7487ad, so please re-approve this head.

• Ledger: 3013 rows, 2284 never, 729 dated, read back from the tsv.
• Collection: cluster_tests 578, guard_tests 435.
• Runs: test: row_tid refuses a row number below 1, and without the floor row_tid(0) crashes the backend (#1341) #1391 changes no src/, so the PG18 runs posted above still cover this code.

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto 2d1a77f (#1413–#1424). The new head is 431566c, so please re-approve this head.

• Ledger: 3116 rows, 2346 never, 770 dated, read back from the tsv.
• Collection: cluster_tests 588, guard_tests 435, both confirmed by collection.
• Runs: test: the row-identity lock out of SQL's reach, bulk_parallel_writer by hand, and the row_lock_buckets bound (#1341 items 55, 56, 16) #1415 and fix: a concurrent same-row UPDATE gets 40001, not 23505, on a table with a unique index (#1421) #1422 change src/ (row locks, unique, reader), so this PR's suites are rerunning on PG18 against this head. I'll post the results here.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at 431566c, the rebase onto 2d1a77f. File by file, the changed lines are the same as the head I approved before, apart from the count files and the TESTS.md section number.

🤖 Generated with Claude Code

[OffgridwithJD]

Restated for the chain you asked for. The new head is ab6ae27, so please re-approve this head.

• Place in the chain: This PR is stacked on test: rls_direct_storage gets its pytest twin, and its owner-export arm measures the export (#1341) #1383 and has to merge after it. Until test: rls_direct_storage gets its pytest twin, and its owner-export arm measures the export (#1341) #1383 lands, GitHub's diff here also shows the commits below it. This PR's own are the top 2. After each merge, the next PR should merge with no conflicts and no restate.
• Ledger: 3160 rows, 2362 never, 798 dated, cumulative through this PR, read back from the tsv.
• Collection: cluster_tests 592, guard_tests 438, both confirmed by collection.
• Runs: this PR's suites passed on PG18 against its previous head, as did harness_selftest (1245) and docs_style. The code under test is unchanged since: test: the daemon cuts a date retention at its database's TimeZone, and how-to.md now says so (#1341) #1393 changes no src/.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at ab6ae27, its place in the chain on 17420be. This PR's own commits, measured from the link below it, change the same lines as the head I approved before, apart from the count files and the TESTS.md section number.

🤖 Generated with Claude Code