[OffgridwithJD]

Part of #1341: the medium sql-objects item "set_options refuses an unknown compression name". The guard in pgcolumnar--1.0-alpha5.sql had no arm. Without it, an unknown name is stored, and the C reader maps a name it doesn't know to −1 and falls back to the instance default. So the table would compress as something else, with nothing said.

Arms (encode_effort.sh, beside the encode_effort refusal they mirror)

• The refusal: set_options(compression => 'brotli') must raise unknown columnar compression "brotli".
• The stored value: the zstd set just before it must still be the stored value.

PG17, main ff09c2c against this branch, with the compression-name check removed:

	main	this branch
encode_effort.sh	10/10	both red, "the compression set before it is still the one stored: got [brotli] want [zstd]"

Shell only: encode_effort has no pytest twin.

Evidence

• Clean: encode_effort 12/12 on each of PG 15–19.
• Ledger: encode_effort had no rows, so it is seeded with all 12. 2353 → 2365 rows, the census 1798 → 1808, and suites_not_covered 246 → 245. The two arms are dated.
• Overlap: test: parallel_copy and parallel_export_parquet refuse a table the caller holds no grant on; import_export_privilege gets its twin and its ledger (#1341) #1362, test: an Arrow date outside PostgreSQL's range is refused, date32 and date64; arrow_import seeds the ledger (#1341) #1363 and test: a user mapping with half a credential is refused before any request; objstore_credentials seeds the ledger (#1341) #1369 also seed a suite each, so whichever lands later restates.
• Gate: rc=0. The database-free set gives 429 passed.

🤖 Generated with Claude Code

[jdatcmd]

Approving ed40487. Reproduced on PG18.

• Green: 12/12.
• Red: I replaced the compression-name guard in set_options (pgcolumnar--1.0-alpha5.sql:531-534) with a comment. Both arms fail:
  FAIL an unknown compression name is refused: got [no ( set_options …)] want [yes]
FAIL and the compression set before it is still the one stored: got [brotli] want [zstd]
• Ledger: the 12 seeded rows match the 12 checks, and the two dated rows are those two arms. No duplicate keys.

Before merge: it conflicts with main 9b3c181. Main's ceiling is already 245 from #1362, so the rebase must restate it to 244 and restate the census on top of 1821.

[OffgridwithJD]

Rebased onto 57f6e0e (#1401), on top of #1403. The new head is 65d4ff2. Only the count files changed, so this needs your re-approval.

• Same patch: outside the count files, the changed lines match the head you approved, except for TESTS.md section renumbers where main's new sections took the old numbers.
• The ledger is restated on main's census and agrees with its tsv: 2798 rows, 2105 never, 693 dated, read back from the file. Each changed paragraph's arithmetic starts from main's last numbers.
• cluster_tests 566, by collection over the cluster files on this tree. guard_tests 433 is unchanged.
• Runs on the rebased tree at 217f23b, PG17 and PG18: PG17 encode_effort: 12 passed + 0 failed + 0 unrunnable + 0 skipped; PG17 harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped; PG18 encode_effort: 12 passed + 0 failed + 0 unrunnable + 0 skipped; PG18 harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped. harness_selftest 1245/1245 and docs_style passed on both. fix: a read inside an aborted inner block no longer loses the enclosing statement's rows (#1360) #1403 has since changed the write path's subtransaction flush, which every suite here exercises, so I'm re-running them all on 758039f and will post the result. CI runs PG17 and PG18 on this head.

🤖 Generated with Claude Code

[OffgridwithJD]

Re-run finished on the tree after #1403 (758039f or later). Everything is green, so the head above stands:

• PG17 docs_style: passed
• PG17 encode_effort: 12 passed + 0 failed + 0 unrunnable + 0 skipped
• PG17 harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped
• PG18 docs_style: passed
• PG18 encode_effort: 12 passed + 0 failed + 0 unrunnable + 0 skipped
• PG18 harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto 7da848d (#1432, #1409). The new head is cad2dfa; only the count files changed, so please re-approve this head.

• Ledger, restated on main's census and read back from the tsv: 2885 rows, 2189 never, 696 dated, suites_not_covered 231. A branch that seeds a suite moves suites_not_covered one below main's 232, derived from the runner's suite list.
• Counts by collection: cluster_tests 567, guard_tests 435.
• What the earlier runs still cover: test: the Iceberg REST readers' server-file gate, and no borrowed environment token (#1341 items 8, 9, 14, 52) #1409 and test: setting an attribute on pgc_conn or its cursors raises instead of doing nothing (#1420) #1432 change no src/, so the PG17 and PG18 runs posted above still describe this code. test: setting an attribute on pgc_conn or its cursors raises instead of doing nothing (#1420) #1432 does change the pytest proxies, which now refuse attribute assignment, so I'm re-running every twin on PG18 and will post if anything moves. A scan of this branch's twins finds no assignment to pgc_conn or a cursor.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at cad2dfa. Compared with ed40487, the head I approved, file by file: the changed lines are the same, apart from the count files (check_ledger_budget.txt, expected_tests.txt) and, in #1378/#1379/#1380/#1383, the TESTS.md section number, now 115.

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto 1f7b5da (#1411, #1412, #1417, #1418). The new head is 0a50162. Only the count files changed, plus TESTS.md section numbers where main took 115, so please re-approve this head.

• Ledger: 2996 rows, 2288 never, 708 dated, read back from the tsv, with suites_not_covered 230.
• Collection: cluster_tests 570, guard_tests 435.
• Re-running every suite and twin on PG18: fix: REINDEX reclaims the entries of deleted rows no snapshot can see (#1407) #1412 changes the index build in src/, and these suites use indexes. I'll post the results here; CI runs PG17 and PG18 on this head.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at 0a50162, the rebase onto 1f7b5da. File by file, the changed lines are the same as the head I approved before, apart from the count files and, in #1378/#1379/#1380/#1383, the TESTS.md section number.

🤖 Generated with Claude Code

[OffgridwithJD]

The PG18 re-run on this head (0a50162, on 1f7b5da with #1412's index-build change) is all green:

• docs_style: passed
• encode_effort: 12 passed + 0 failed + 0 unrunnable + 0 skipped
• harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto 37ea557 (#1414, #1425). The new head is 44c60ad. Only the count files changed, so please re-approve this head.

• Ledger: 3010 rows, 2291 never, 719 dated, read back from the tsv.
• Collection: cluster_tests 575, guard_tests 435.
• Runs: test: the settings reference is held to the server (#1341 items 42, 57, 83) #1414 and test: megabyte-scale values are stored exactly (#1341) #1425 change no src/, so the PG18 re-run posted above, on 1f7b5da, still covers this code.

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto f2bd5f1 (#1427). The new head is f65e22d. Only the count files changed, so please re-approve this head.

• Ledger: 3019 rows, 2292 never, 727 dated, read back from the tsv.
• Collection: cluster_tests 576, guard_tests 435.
• Runs: test: tables that skip WAL at wal_level=minimal survive a crash (#1341) #1427 changes no src/, so the PG18 re-run posted above still covers this code.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at f65e22d, the rebase onto f2bd5f1. File by file, the changed lines are the same as the head I approved before, apart from the count files and, in #1378/#1379/#1380/#1383, the TESTS.md section number.

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto d5c0a5e (#1391). The new head is 714a628, so please re-approve this head.

• Ledger: 3020 rows, 2292 never, 728 dated, read back from the tsv.
• Collection: cluster_tests 577, guard_tests 435.
• Runs: test: row_tid refuses a row number below 1, and without the floor row_tid(0) crashes the backend (#1341) #1391 changes no src/, so the PG18 runs posted above still cover this code.

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto 2d1a77f (#1413–#1424). The new head is c2dd031, so please re-approve this head.

• Ledger: 3123 rows, 2354 never, 769 dated, read back from the tsv.
• Collection: cluster_tests 587, guard_tests 435, both confirmed by collection.
• Runs: test: the row-identity lock out of SQL's reach, bulk_parallel_writer by hand, and the row_lock_buckets bound (#1341 items 55, 56, 16) #1415 and fix: a concurrent same-row UPDATE gets 40001, not 23505, on a table with a unique index (#1421) #1422 change src/ (row locks, unique, reader), so this PR's suites are rerunning on PG18 against this head. I'll post the results here.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at c2dd031, the rebase onto 2d1a77f. File by file, the changed lines are the same as the head I approved before, apart from the count files and the TESTS.md section number.

🤖 Generated with Claude Code

[OffgridwithJD]

Restated for the chain you asked for. The new head is b8cd124, so please re-approve this head.

• Place in the chain: This PR is stacked on test: analyze() refuses a named column the table does not have, before writing any statistics; analyze_function seeds the ledger (#1341) #1373 and has to merge after it. Until test: analyze() refuses a named column the table does not have, before writing any statistics; analyze_function seeds the ledger (#1341) #1373 lands, GitHub's diff here also shows the commits below it. This PR's own are the top 2. After each merge, the next PR should merge with no conflicts and no restate.
• Ledger: 3336 rows, 2526 never, 810 dated, cumulative through this PR, read back from the tsv.
• Collection: cluster_tests 598, guard_tests 438, both confirmed by collection.
• Runs: this PR's suites passed on PG18 against its previous head, as did harness_selftest (1245) and docs_style. The code under test is unchanged since: test: the daemon cuts a date retention at its database's TimeZone, and how-to.md now says so (#1341) #1393 changes no src/.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at b8cd124, its place in the chain on 17420be. This PR's own commits, measured from the link below it, change the same lines as the head I approved before, apart from the count files and the TESTS.md section number.

🤖 Generated with Claude Code

[OffgridwithJD]

Restacked onto #1375's fix (875429d, its projections row renamed). The new head is f41f38b, so please re-approve this head. This PR's own commits are unchanged, and nothing in its diff moved.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at f41f38b. This PR's own commits are the same as the head I approved, rebased onto the fixed #1375.

🤖 Generated with Claude Code