Repository navigation
test: six rollup checks that read a product operation's result lose the premise prefix, five dated (#1339) - #1402
Conversation
jdatcmd
left a comment
There was a problem hiding this comment.
Reproduced at f9f43eb on PG18. rollup is 82/82.
expirereports 0 (PG_RETURN_INT64(retired)→ 0): 80 + 2,expire retired the old row groupsandexpire retired the group the delete thinned, bothgot [0] want [1].compact_rewritereports 0: 81 + 1,compact_rewrite rewrote a row group: got [0] want [1].
The narrow mutations redden exactly the renamed checks. Leaving the partials check undated, with the reason stated, is honest. Approving. I'll merge once CI is green, after checking the approval is on this head.
🤖 Generated with Claude Code
f9f43eb to
e098c0f
Compare
|
Rebased onto 57f6e0e (#1401), on top of #1403. The new head is e098c0f. Only the count files changed, so this needs your re-approval.
🤖 Generated with Claude Code |
|
Re-run finished on the tree after #1403 (758039f or later). Everything is green, so the head above stands:
🤖 Generated with Claude Code |
e098c0f to
c2e0e54
Compare
|
Rebased onto 7da848d (#1432, #1409). The new head is c2e0e54; only the count files changed, so please re-approve this head.
🤖 Generated with Claude Code |
c2e0e54 to
60e5796
Compare
|
Rebased onto 1f7b5da (#1411, #1412, #1417, #1418). The new head is 60e5796. Only the count files changed, plus TESTS.md section numbers where main took 115, so please re-approve this head.
🤖 Generated with Claude Code |
|
The PG18 re-run on this head (60e5796, on 1f7b5da with #1412's index-build change) is all green:
🤖 Generated with Claude Code |
|
Rebased onto 37ea557 (#1414, #1425). The new head is 0af054b. Only the count files changed, so please re-approve this head.
🤖 Generated with Claude Code |
60e5796 to
0af054b
Compare
|
Rebased onto f2bd5f1 (#1427). The new head is e2e7e06. Only the count files changed, so please re-approve this head.
🤖 Generated with Claude Code |
0af054b to
e2e7e06
Compare
|
Rebased onto d5c0a5e (#1391). The new head is 6909c4c, so please re-approve this head.
🤖 Generated with Claude Code |
e2e7e06 to
6909c4c
Compare
|
Rebased onto 2d1a77f (#1413–#1424). The new head is b37d9bb, so please re-approve this head.
🤖 Generated with Claude Code |
6909c4c to
b37d9bb
Compare
jdatcmd
left a comment
There was a problem hiding this comment.
Re-approved at b37d9bb, the rebase onto 2d1a77f. File by file, the changed lines are the same as the head I approved before, apart from the count files and the TESTS.md section number.
🤖 Generated with Claude Code
…ws are reworded The mutation column is a ';'-separated set, written back sorted. A --mutation whose text held "; " was stored as two mutations, one a fragment starting with a space, and every later merge re-sorted it. commandprompt#1427's recovery_minimal_wal text did this to 8 rows, and commandprompt#1423, commandprompt#1424 and commandprompt#1426 each carried them as a change of their own. Four older harness_selftest rows were split the same way. - merge refuses a --mutation holding ';' (rc 2, ledger untouched). - the reader refuses a ';'-piece with whitespace at an end, by line: the writer joins with a bare ';', so such a piece is a fragment, never a mutation. - the 12 rows are reworded without ';', from their original text in history. Only field 6 changes; the census stays 3007 / 2282 / 725. Red first: the two refusal arms got 0 want 2 on the unchanged tool, and the committed-ledger arm was red at line 1783 with the refusal in and the rows not yet reworded. guard_tests 435 -> 438 by collection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rompt#1341 item 75) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjTxfQJj5pnii9wzmPP9Ho
…ment-mark mutation (commandprompt#1341 item 75) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjTxfQJj5pnii9wzmPP9Ho
…wn privileges, in both twins (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjTxfQJj5pnii9wzmPP9Ho
…d the refused tier writes no file, in both twins (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjTxfQJj5pnii9wzmPP9Ho
…ITY DEFINER (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjTxfQJj5pnii9wzmPP9Ho
… back; both its branches echoed "ran" (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjTxfQJj5pnii9wzmPP9Ho
…ll's name (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjTxfQJj5pnii9wzmPP9Ho
… arm runs with the configured list empty, in both twins (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n comparing two empty strings (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…andprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d the shell names 'empty' itself (commandprompt#1379 review) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjTxfQJj5pnii9wzmPP9Ho
…dated (commandprompt#1379 review) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjTxfQJj5pnii9wzmPP9Ho
…l's name (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…0) and leaves nothing declared, in both twins (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ts connections (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Restated for the chain you asked for. The new head is 32a92ea, so please re-approve this head.
🤖 Generated with Claude Code |
b37d9bb to
32a92ea
Compare
jdatcmd
left a comment
There was a problem hiding this comment.
Re-approved at 32a92ea, its place in the chain on 17420be. This PR's own commits, measured from the link below it, change the same lines as the head I approved before, apart from the count files and the TESTS.md section number.
🤖 Generated with Claude Code
…emise: prefix (commandprompt#1341) Review of commandprompt#1375 by jdatcmd: CI's suites (PG 17) ledger gate found the row seeded as 'premise: the drop really removed the projection' while projections.sh:410 and test_projections.py:795 name the check without the prefix, so the gate saw one check not in the ledger and one orphan row. The row is renamed and keeps its other fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e writing any statistics, in both twins (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…blings do (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… dated (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ys so (commandprompt#1341) test_a_named_column_that_does_not_exist_is_refused calls pgcolumnar.analyze(), which needs PostgreSQL 18, so it declines on 15, 16 and 17 like the other analyze_function twins. It was missing from expected_unrunnable.txt, so CI's PG17 cluster job collected and passed 578 and still exited 67 on the unexpected decline. Measured on PG17: test_analyze_function.py exits 67 without these rows and 0 with them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tored one (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…dated (commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…its bar, and four that had none get arms here, in both twins (commandprompt#1386) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjTxfQJj5pnii9wzmPP9Ho
…eir mutations (commandprompt#1386) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjTxfQJj5pnii9wzmPP9Ho
…te, expire or a refresh lose the premise prefix, in both twins (commandprompt#1339) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjTxfQJj5pnii9wzmPP9Ho
…ite and expire mutations (commandprompt#1339) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VjTxfQJj5pnii9wzmPP9Ho
32a92ea to
1526d8e
Compare
|
Restacked onto #1375's fix (875429d, its projections row renamed). The new head is 1526d8e, so please re-approve this head. This PR's own commits are unchanged, and nothing in its diff moved. 🤖 Generated with Claude Code |
jdatcmd
left a comment
There was a problem hiding this comment.
Re-approved at 1526d8e. This PR's own commits are the same as the head I approved, rebased onto the fixed #1375.
🤖 Generated with Claude Code
Part of #1339 (#1236), from @jdatcmd's note on #1372: six
rollupchecks namedpremise:read the result of a product operation. They lose the prefix in both twins, and their ledger rows are renamed with their history.pgcolumnar.vacuumrewrites nothing:got [same: …]compact_rewritereports 0 whatever it rewrote:got [0]expirereports 0 whatever it retired:got [0]got [0]expireretires nothing: `got [500The two count mutations are deliberately narrow: they change only the return value, so they redden exactly the checks that read it. "Expire retires nothing" also reddens the expire counts and three refusal arms beside them, which already had dates. No remaining
premise:in the suite went red under any of the four.Evidence
Clean: rollup 82/82 and
test_rollup.pypassing on each of PG15–19.Bookkeeping
cluster_testsandguard_testsdon't move. The guard set is 433/433.rollup.shandtest_rollup.py, in other places. Whichever lands later restates.🤖 Generated with Claude Code