[OffgridwithJD]

Part of #1341: the medium sql-objects item "pgcolumnar.analyze(rel, columns) refuses a named column that does not exist". The function's own comment says silently collecting nothing would be "the failure mode that looks exactly like success". No arm reached the check.

Arms (both twins; a new pytest function, test_a_named_column_that_does_not_exist_is_refused)

On a fresh table:

• The refusal: analyze('af_unk', ARRAY['a','nosuch']) raises pgcolumnar.analyze(): column "nosuch" does not exist in af_unk, checked by SQLSTATE and message.
• Before any work: pg_stats holds no row for the table, not even for a, so the refusal came first.
• Control: the same call naming only a writes its statistics, so "none" isn't a table that never gets any.

pgcolumnar.analyze() needs PostgreSQL 18. On 15–17 the shell suite's single named version SKIP covers these too. The pytest function declines unnamed, exactly as its three siblings do, which my first push didn't: it failed on 15–17 before I gated it.

Mutation

The unknown-column check removed. PG18, main ff09c2c against this branch:

	main	this branch
analyze_function.sh / pytest	68/68, 5 passed	the call succeeded ("got [ok]"), and wrote statistics for a ("got [1] want [0]")

Evidence

• Clean: analyze_function 71/71 on 18–19, the named SKIP on 15–17. The pytest file passed on all five.
• Ledger: analyze_function had no rows, so it is seeded with all 72 checks. 2353 → 2425 rows, the census 1798 → 1868, and suites_not_covered 246 → 245. The two arms are dated.
• Gate: rc=0.
• Counts: TESTS.md row, and cluster_tests 533 → 534. Other PRs of mine take 534 too, so whichever lands later restates.
• Database-free set: 429 passed.

🤖 Generated with Claude Code

[jdatcmd]

Approving c61baf4 on content. Reproduced on PG18.

• Green: shell 71/71; pytest 6 passed.
• Red: I replaced the IF unknown IS NOT NULL THEN RAISE … block (pgcolumnar--1.0-alpha5.sql ~1560) with NULL;. The shell twin fails both arms:
  FAIL analyze() refuses a named column the table does not have, and names it: … got [] want [P0001 pgcolumnar.analyze(): column "nosuch" does not exist in af_unk]
FAIL and writes no statistics, not even for the real column named beside it: got [1] want [0]
  pytest stops at the first: got 'ok' want 'P0001 …'. The control stays green.
• Ledger: 72 rows for 71 checks plus the 15–17 SKIP name. No duplicate keys.

Notes, not blocking:

• The shell arm reports got [] on success, where pytest says 'ok'. Echoing ok would match it.
• A fresh 5000-row table is an autoanalyze candidate. An autoanalyze between the INSERT and the pg_stats count would redden "writes no statistics". The window is small; setting autovacuum_enabled = off on af_unk would close it. Unverified.

Before merge: a rebase. Restate the ceiling to 244 and the census on main's 1821, and settle the cluster_tests collision with #1372.

[OffgridwithJD]

Rebased onto 57f6e0e (#1401), on top of #1403. The new head is 454c14a. Only the count files changed, so this needs your re-approval.

• Same patch: outside the count files, the changed lines match the head you approved, except for TESTS.md section renumbers where main's new sections took the old numbers.
• The ledger is restated on main's census and agrees with its tsv: 2858 rows, 2165 never, 693 dated, read back from the file. Each changed paragraph's arithmetic starts from main's last numbers.
• cluster_tests 567, by collection over the cluster files on this tree. guard_tests 433 is unchanged.
• Runs on the rebased tree at 217f23b, PG17 and PG18: PG17 analyze_function: 0 passed + 0 failed + 0 unrunnable + 1 skipped (analyze() needs PostgreSQL 18, so PG17 declines it by name); PG17 harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped; PG17 pytest: 6 passed in 1.83s; PG18 analyze_function: 71 passed + 0 failed + 0 unrunnable + 0 skipped; PG18 harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped; PG18 pytest: 6 passed in 9.55s. harness_selftest 1245/1245 and docs_style passed on both. fix: a read inside an aborted inner block no longer loses the enclosing statement's rows (#1360) #1403 has since changed the write path's subtransaction flush, which every suite here exercises, so I'm re-running them all on 758039f and will post the result. CI runs PG17 and PG18 on this head.

🤖 Generated with Claude Code

[OffgridwithJD]

Re-run finished on the tree after #1403 (758039f or later). Everything is green, so the head above stands:

• PG17 analyze_function: 0 passed + 0 failed + 0 unrunnable + 1 skipped (PG18-only analyze() arms, declined by name)
• PG17 docs_style: passed
• PG17 harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped
• PG17 pytest: 6 passed in 2.33s (PG18-only analyze() arms, declined by name)
• PG18 analyze_function: 71 passed + 0 failed + 0 unrunnable + 0 skipped
• PG18 docs_style: passed
• PG18 harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped
• PG18 pytest: 6 passed in 8.21s

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto 7da848d (#1432, #1409). The new head is 2db496a; only the count files changed, so please re-approve this head.

• Ledger, restated on main's census and read back from the tsv: 2945 rows, 2249 never, 696 dated, suites_not_covered 231. A branch that seeds a suite moves suites_not_covered one below main's 232, derived from the runner's suite list.
• Counts by collection: cluster_tests 568, guard_tests 435.
• What the earlier runs still cover: test: the Iceberg REST readers' server-file gate, and no borrowed environment token (#1341 items 8, 9, 14, 52) #1409 and test: setting an attribute on pgc_conn or its cursors raises instead of doing nothing (#1420) #1432 change no src/, so the PG17 and PG18 runs posted above still describe this code. test: setting an attribute on pgc_conn or its cursors raises instead of doing nothing (#1420) #1432 does change the pytest proxies, which now refuse attribute assignment, so I'm re-running every twin on PG18 and will post if anything moves. A scan of this branch's twins finds no assignment to pgc_conn or a cursor.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at 2db496a. Compared with c61baf4, the head I approved, file by file: the changed lines are the same, apart from the count files (check_ledger_budget.txt, expected_tests.txt) and, in #1378/#1379/#1380/#1383, the TESTS.md section number, now 115.

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto 1f7b5da (#1411, #1412, #1417, #1418). The new head is 9d8861f. Only the count files changed, plus TESTS.md section numbers where main took 115, so please re-approve this head.

• Ledger: 3056 rows, 2348 never, 708 dated, read back from the tsv, with suites_not_covered 230.
• Collection: cluster_tests 571, guard_tests 435.
• Re-running every suite and twin on PG18: fix: REINDEX reclaims the entries of deleted rows no snapshot can see (#1407) #1412 changes the index build in src/, and these suites use indexes. I'll post the results here; CI runs PG17 and PG18 on this head.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at 9d8861f, the rebase onto 1f7b5da. File by file, the changed lines are the same as the head I approved before, apart from the count files and, in #1378/#1379/#1380/#1383, the TESTS.md section number.

🤖 Generated with Claude Code

[OffgridwithJD]

The PG18 re-run on this head (9d8861f, on 1f7b5da with #1412's index-build change) is all green:

• analyze_function: 71 passed + 0 failed + 0 unrunnable + 0 skipped
• docs_style: passed
• harness_selftest: 1245 passed + 0 failed + 0 unrunnable + 0 skipped
• pytest: 6 passed in 5.04s

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto 37ea557 (#1414, #1425). The new head is 4a2e517. Only the count files changed, so please re-approve this head.

• Ledger: 3070 rows, 2351 never, 719 dated, read back from the tsv.
• Collection: cluster_tests 576, guard_tests 435.
• Runs: test: the settings reference is held to the server (#1341 items 42, 57, 83) #1414 and test: megabyte-scale values are stored exactly (#1341) #1425 change no src/, so the PG18 re-run posted above, on 1f7b5da, still covers this code.

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto f2bd5f1 (#1427). The new head is 8e59b7a. Only the count files changed, so please re-approve this head.

• Ledger: 3079 rows, 2352 never, 727 dated, read back from the tsv.
• Collection: cluster_tests 577, guard_tests 435.
• Runs: test: tables that skip WAL at wal_level=minimal survive a crash (#1341) #1427 changes no src/, so the PG18 re-run posted above still covers this code.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at 8e59b7a, the rebase onto f2bd5f1. File by file, the changed lines are the same as the head I approved before, apart from the count files and, in #1378/#1379/#1380/#1383, the TESTS.md section number.

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto d5c0a5e (#1391). The new head is d93ea54, so please re-approve this head.

• Ledger: 3080 rows, 2352 never, 728 dated, read back from the tsv.
• Collection: cluster_tests 578, guard_tests 435.
• Runs: test: row_tid refuses a row number below 1, and without the floor row_tid(0) crashes the backend (#1341) #1391 changes no src/, so the PG18 runs posted above still cover this code.

🤖 Generated with Claude Code

[OffgridwithJD]

@jdatcmd CI's pytest (cluster tests, PG 17) was red on d93ea54 for a defect of mine: the new twin test, test_a_named_column_that_does_not_exist_is_refused, declines on PG15-17 as the other analyze() twins do, but I hadn't listed it in expected_unrunnable.txt. The job passed all 578 tests and exited 67 on the unexpected decline. My local PG17 runs showed the same 67 earlier, and I misread it as the expected decline.

Fixed in 59b4950: the registry gets the test for 15, 16 and 17. On PG17, test_analyze_function.py exits 67 without those rows and 0 with them, and the guard set passes 435. Please re-approve this head.

🤖 Generated with Claude Code

[OffgridwithJD]

Rebased onto 2d1a77f (#1413–#1424). The new head is 257784b, so please re-approve this head.

• Ledger: 3183 rows, 2414 never, 769 dated, read back from the tsv.
• Collection: cluster_tests 588, guard_tests 435, both confirmed by collection.
• Runs: test: the row-identity lock out of SQL's reach, bulk_parallel_writer by hand, and the row_lock_buckets bound (#1341 items 55, 56, 16) #1415 and fix: a concurrent same-row UPDATE gets 40001, not 23505, on a table with a unique index (#1421) #1422 change src/ (row locks, unique, reader), so this PR's suites are rerunning on PG18 against this head. I'll post the results here.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at 257784b, the rebase onto 2d1a77f. The one addition beyond bookkeeping is three expected_unrunnable.txt lines declaring that test_a_named_column_that_does_not_exist_is_refused declines on PG15, 16 and 17. That's right: pgcolumnar.analyze() needs PostgreSQL 18.

🤖 Generated with Claude Code

[OffgridwithJD]

Restated for the chain you asked for. The new head is 5879648, so please re-approve this head.

• Place in the chain: This PR is stacked on test: a projection sorted on a type with no ordering is refused (0A000), not a backend crash; projections seeds the ledger (#1341) #1375 and has to merge after it. Until test: a projection sorted on a type with no ordering is refused (0A000), not a backend crash; projections seeds the ledger (#1341) #1375 lands, GitHub's diff here also shows the commits below it. This PR's own are the top 4. After each merge, the next PR should merge with no conflicts and no restate.
• Ledger: 3324 rows, 2516 never, 808 dated, cumulative through this PR, read back from the tsv.
• Collection: cluster_tests 598, guard_tests 438, both confirmed by collection.
• Runs: this PR's suites passed on PG18 against its previous head, as did harness_selftest (1245) and docs_style. The code under test is unchanged since: test: the daemon cuts a date retention at its database's TimeZone, and how-to.md now says so (#1341) #1393 changes no src/.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at 5879648, its place in the chain on 17420be. This PR's own commits, measured from the link below it, change the same lines as the head I approved before, apart from the count files and the TESTS.md section number.

🤖 Generated with Claude Code

[OffgridwithJD]

Restacked onto #1375's fix (875429d, its projections row renamed). The new head is e56de60, so please re-approve this head. This PR's own commits are unchanged, and nothing in its diff moved.

🤖 Generated with Claude Code

[jdatcmd]

Re-approved at e56de60. This PR's own commits are the same as the head I approved, rebased onto the fixed #1375.

🤖 Generated with Claude Code