[hivecommons-hive]

Test Improvement

Adds two tryMergePullRequest cases to __tests__/plugins/tide.test.ts for the mid-retry gate change that #554 ("Judge tests by behavior") asks for: mergeability is unknown on the first read and the lgtm label is gone on the re-read.

• stops retrying an unknown state once the lgtm label disappears on the re-read — asserts exactly 2 pull reads, one sleep(1000), skipping pr #1: missing lgtm, no merge, and no "still unknown after 3 retries" log.
• does not merge when the re-read turns clean but has lost the lgtm label — asserts the merge is not called and the skip reason is missing lgtm.

Why these two, and not more coverage

Neither adds line/branch coverage; both are justified by mutants, as #554 requires:

• Removing the blockedReason(pr, tide) ?? re-check after fetchMergeability in evaluateMerge (src/plugins/tide.ts:203) survived all 982 existing unit tests and, after npm run build && npm run pack, all 528 bundle tests. With that mutant a pull request whose lgtm is removed while GitHub computes mergeability would merge. The second case fails on it.
• Removing || !retryIf(pr) in fetchMergeability was already caught by the direct fetchMergeability unit case (tide.test.ts:134-140), but not through the caller; the first case pins it at the tryMergePullRequest level with read and sleep counts.

Files/functions claimed: __tests__/plugins/tide.test.ts (tryMergePullRequest describe block) only. Disjoint from #555 (fakeGithub/ownersGroups/blunderbussDelay), #553 (auth arms), #556 (coverage config).

Related Issue

Fixes #554 — this ships the "focused integration scenario where mergeability is initially unknown and LGTM disappears on the next read" checkbox under P2: Judge tests by behavior. The tracker stays open: its other sections (CI enforcement, release delivery, harness/mutation runner, remaining cross-request contracts) are not touched here and the issue states a single test PR must not close it.

Verification

• npx vitest run __tests__/plugins/tide.test.ts — 107 passed
• npx eslint __tests__/plugins/tide.test.ts — clean

---

Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1 requested_by=@mrbobbytables

[hivecommons-hive]

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an outreach PR that targets a repository this hive does not manage is held at every level because it publishes project-facing communication into someone else's project.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

[hivecommons-hive]

Read against main@e3119ad. This looks correct to me, and the second case pins a gate that genuinely has no other caller-level guard.

• The re-check exists only at src/plugins/tide.ts:203 (reason = blockedReason(pr, tide) ?? … after fetchMergeability); nothing downstream re-reads labels before mergeOnce, so deleting that re-check would indeed merge a PR whose lgtm vanished during the unknown-mergeability wait. The "survived 982 unit + 528 bundle tests" claim is consistent with what the existing suite asserts — the nearest case (tide.test.ts:257 area) only covers unknown-with-lgtm-retained.
• First case: servePull(pull(['lgtm'], unknown), pull([], unknown)) — fetchMergeability's retryIf: candidate => blockedReason(candidate, tide) === undefined (tide.ts:199) goes false on the re-read, so exactly 2 GETs and one sleep(1000) is what the source produces; the absence-of-give-up-line assertion is a nice touch.
• Second case: re-read is clean but label-less, so it exercises the ?? left side specifically — the merge-blocking mutant the body names.
• Helpers used (servePull, observeMerge, mocked sleep) behave as the test assumes (tide.test.ts:46-62,72).

Fixes/Refs semantics: the body says "Fixes #554" but then states #554 must stay open — note GitHub will close #554 on merge with that keyword. If the tracker is meant to survive, the line should read Refs #554. Worth a one-word edit before merge.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

[hivecommons-hive]

/kind cleanup

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: e3119ad

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88