Skip to content

test(sweep): pin the delayed-reviewers OWNERS guard on a base branch without OWNERS files (sweep.ts:80) - #561

Closed
hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
quality/test-sweep-delay-no-owners
Closed

hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
quality/test-sweep-delay-no-owners

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Description

Pins the false arm of the branchHasOwners guard that precedes requestReviewersIfDue in the delayed-reviewers loop of src/cronJobs/sweep.ts (line 80): a pull request that is due for delayed blunderbuss but whose base branch carries no OWNERS files must be left alone — no timeline read, no review read, no requested_reviewers write.

Files/functions claimed (both new, so #558 __tests__/cronJobTest/sweep.test.ts, #559 / #555 __tests__/bundle/blunderbussDelay.test.ts, #553 auth.ts, #556 e2e floor and #557 tide.test.ts are untouched):

file case asserts
__tests__/cronJobTest/sweepDelayWithoutOwners.test.ts blunderbuss.delay: 1h, empty master tree, one PR created/updated 70 min ago sweep resolves { candidates: [], merged: [], enqueued: [], failures: [] }; git/trees/master read; timeline, reviews and requested_reviewers handlers never called
__tests__/bundle/blunderbussDelayWithoutOwners.test.ts the same scenario through dist/index.js on the schedule event exit 0, no ::error::, sweep: 0 candidates updated since, sweep: 1 more checked for delayed reviewers, exactly one git/trees/master?recursive=true read, zero timeline/review reads, zero non-GET requests, and the only non-config requests are the pull list and the tree read

Source under test is unchanged.

Fixes #560

Mutation check

if (await branchHasOwners(...)) → if (await branchHasOwners(...) || true) in src/cronJobs/sweep.ts:

  • unit case fails: sweep: 1 pull request(s) failed: #1 (blunderbuss: [MSW] Cannot bypass a request …) — the mutant reaches an endpoint the test deliberately does not serve
  • bundle case (after npm run pack:coverage, run with PROW_BUNDLE_PATH=.coverage-bundle/index.js) fails: ::error::… sweep: 1 pull request(s) failed: #1 (blunderbuss: could not read the timeline: HttpError: Not Found (fake))

Before this PR the same mutant is accepted by all 46 cases of sweep.test.ts and by the whole bundle suite.

Coverage evidence

Testing

  • npx vitest run __tests__/cronJobTest/sweepDelayWithoutOwners.test.ts — 1 passed
  • npx vitest run __tests__/bundle/blunderbussDelayWithoutOwners.test.ts — 1 passed (against committed dist/index.js)
  • npm run pack:coverage && PROW_BUNDLE_PATH=.coverage-bundle/index.js npx vitest run __tests__/bundle/blunderbussDelayWithoutOwners.test.ts — 1 passed
  • npx eslint on both files — clean

Checklist

  • Commits are signed off (DCO)
  • No new dependencies
  • No dist/ change (tests only)
  • Self-reviewed

Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1

…without OWNERS files

Both suites left the false arm of the branchHasOwners guard ahead of
requestReviewersIfDue in src/cronJobs/sweep.ts with zero hits: every
delayed-blunderbuss case served an OWNERS file on master. Add one unit case
and one dist/index.js scenario, each in its own file, that configure
blunderbuss.delay, serve an empty master tree and a due pull request, and
assert the tree is probed once while the timeline, reviews and
requested_reviewers endpoints are never touched. Both fail when the guard is
replaced by `|| true`.

Fixes #560

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner October 22, 2026 01:32
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an outreach PR that targets a repository this hive does not manage is held at every level because it publishes project-facing communication into someone else's project.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

/kind cleanup


🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: unknown

— hive: agent=quality backend=copilot model=claude-fable-5.1

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read both new test files against src/cronJobs/sweep.ts at merge-base. The guard being pinned is real and the assertions match it:

  • sweep.ts:80-82: in the delayed-only loop, branchHasOwners gates requestReviewersIfDue, so on an OWNERS-less base branch a due PR produces no timeline read, no reviews read, and no requested_reviewers POST — exactly what both cases assert from opposite directions (unit: ObserveRequest.notCalled on served-but-unused handlers; bundle: requestsMatching empty plus a whitelist of the only two non-config requests).
  • The fixtures (created/updated 70 min ago, delay: 1h, default lookback) correctly land the PR in delayedOnly (updated_at < since at sweep.ts:69), so the sweep: 0 candidates updated since / sweep: 1 more checked for delayed reviewers stdout assertions line up with sweep.ts:70-73.
  • sweep resolving { candidates: [], …, failures: [] } is right: the skip is silent, not a failure (sweep.ts:80 just falls through).

The mutation check in the body (|| true on the guard) is a genuine regressor for both cases. Not a duplicate of #558/#559 — both files are new and pin a different arm (guard false) than those PRs (window bounds, idempotence). Test-only, source unchanged, CI green. Looks correct to me.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

@mrbobbytables

Copy link
Copy Markdown
Member

Consolidated into #589 (commit cherry-picked unchanged, author and DCO sign-off preserved).

mrbobbytables added a commit that referenced this pull request Oct 26, 2026
…solidates #555, #558, #559, #561, #562, #564-#567) (#589)

* test: cover paginated OWNERS and review timelines

Exercise approval authorization, automatic reviewer selection, and delayed reviewer timing across page boundaries.

Hive-Run: #554

Hive-Plan: P2 cross-request contracts

Hive-Spec: issue-554#P2-cross-request-contracts

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>

* test(sweep): pin the inclusive due-window bounds and the timeline-read failure of delayed reviewers

Add four cases to the 'sweep with blunderbuss.delay' block of
__tests__/cronJobTest/sweep.test.ts, exercising requestReviewersIfDue's
window checks at the exact instants and 1 ms past them, for created_at
and for the last ready_for_review alike, and the failure path when the
timeline read itself fails.

Each boundary case fails on a one-character mutant of sweep.ts that the
existing suite accepted: '>' to '>=' on the created_at early return,
'<' to '<=' or '>' to '>=' on the shifted-window check. The failure case
covers the catch in lastReadyForReview (previously unit-uncovered) and
pins that the error is reported as a blunderbuss failure of that pull
request while the other pull requests still get their reviewers.

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(sweep): pin that a second delayed sweep leaves the first run's requested reviewers alone

The delayed-blunderbuss bundle suite modelled a pull that already had
reviewers only as a static fixture. This drives dist/index.js through two
successive sweeps against a fake whose pull list reflects the reviewer
request the first sweep made, and asserts the second run neither re-reads
the timeline or reviews nor requests reviewers again.

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(sweep): pin the delayed-reviewers OWNERS guard on a base branch without OWNERS files

Both suites left the false arm of the branchHasOwners guard ahead of
requestReviewersIfDue in src/cronJobs/sweep.ts with zero hits: every
delayed-blunderbuss case served an OWNERS file on master. Add one unit case
and one dist/index.js scenario, each in its own file, that configure
blunderbuss.delay, serve an empty master tree and a due pull request, and
assert the tree is probed once while the timeline, reviews and
requested_reviewers endpoints are never touched. Both fail when the guard is
replaced by `|| true`.

Fixes #560

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(sweep): pin the reviewer-key fallbacks of delayed blunderbuss on a bare pull listing (sweep.ts:208)

requestReviewersIfDue reads requested_reviewers ?? [] and
requested_teams ?? [] off the pull list entry, but no unit or bundle test
listed a delayed-only pull request without those keys, leaving both
fallback arms unreached in coverage/ and coverage-e2e/. Serve a due pull
with the keys removed on both harnesses and assert reviewers are still
requested.

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(owners): pin the fail-closed OWNERS group read when a later members page cannot be fetched (owners.ts:153-162)

Let the real octokit paginator walk a team's Link headers instead of the
stubbed paginate the existing group tests use. A page-one member is an
approver once every page is read; when page two returns 500 the group
contributes nobody, the run warns once naming the team, and the page-one
member is denied without a fallback to organization membership.

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(sweep): pin the delayed-reviewers catch of sweep in its Error and String(e) arms (sweep.ts:85)

Adds __tests__/cronJobTest/sweepDelayFailures.test.ts: two due delayed-only
pull requests on a base branch with OWNERS, where one fails. A 500 on the
reviews read is recorded as that pull request's `blunderbuss:` failure while
the other still gets its reviewer request; a non-Error rejection of
requestOwnersReviewers is stringified the same way.

Before: coverage/lcov.info BRDA:85,5,0,0 / BRDA:85,5,1,0 (neither arm hit by
the unit suite). After: both 1; sweep.ts branches 92.3 -> 94.87 %.

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(sweep): pin the ignore_drafts=false arm of delayed reviewers (sweep.ts:218)

With blunderbuss.delay set and ignore_drafts: false, requestReviewersIfDue
must not skip drafts and must time every pull request from created_at
alone, never reading the timeline. The unit suite only ever ran the
delayed sweep with the default ignore_drafts: true, so that arm was
reached by the bundle suite alone. Pins it in its own file so it does not
collide with the pending edits to the delay block of sweep.test.ts.

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(sweep): pin the no-catch-up recovery of delayed reviewers after missed schedule runs

After the schedule misses runs for longer than sweep.lookback, a pull
request whose review clock expired before now - delay - lookback is
neither listed, read nor requested by the delayed-reviewers step, and a
longer sweep.lookback is what recovers it. Pinned in a unit suite
(__tests__/cronJobTest/sweepDelayOutage.test.ts) and against
dist/index.js (__tests__/bundle/blunderbussDelayOutage.test.ts); the
blunderbuss.delay paragraph of docs/configuration.md now records the
expectation.

Refs #554

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(harness): fail tide and sweep unit tests on unserved requests

Completes the #571 wiring that was deferred while #557 and #558 occupied
these files: both servers now answer the merge-queue read with
noMergeQueue and assert at the end of each test that no request went
unserved; sweep's OWNERS scenarios serve the base-branch tip instead of
running through the 'could not read the tip' fallback.

Refs #570

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>

---------

Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
Co-authored-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@mrbobbytables
mrbobbytables deleted the quality/test-sweep-delay-no-owners branch October 26, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] sweep.ts delayed-reviewers OWNERS guard (line 80 false arm) is covered by neither the unit nor the bundle suite

1 participant