[hivecommons-hive]

Test Improvement

Files/functions claimed: __tests__/bundle/fakeGithub.ts (FakeGithub.unmatched, allowUnmatched, unexpectedRequests, assertNoUnexpectedRequests, reset), new __tests__/bundle/fakeGithubUnexpected.test.ts, and the beforeEach/afterEach of __tests__/bundle/ownersParseArms.test.ts and __tests__/bundle/ownersProbeArms.test.ts. Cluster: #554 P1 harness item "record unexpected API traffic and assert on it outside application error handling".

• The fake keeps the requests no route or fallback answered in unmatched, takes explicit allowances for the misses a scenario relies on (allowUnmatched(method, pattern)), and assertNoUnexpectedRequests() throws naming the rest. The configuration loader's probes are always allowed: every run without a routed prow configuration makes them.
• fakeGithubUnexpected.test.ts pins that contract with plain fetches (6 tests): unrouted → 404 + unexpected; routed/fallback → neither; loader probes allowed, an explicitly sourced config read is not; allowances by exact path, pattern and method; reset clears both the record and the scenario's allowances.
• ownersParseArms and ownersProbeArms adopt it: tide's merge queue read is answered "no queue" through mergeQueueFallback (as lgtmBindingArms/lgtmRemovalNoopArms already do) instead of a 404 that queueState swallows into a warning; the OWNERS probes each scenario expects to miss (sdk%2FOWNERS, root OWNERS on master, master's tree) are allowed in that scenario; anything else unrouted fails it. Before the allowances were added the assertion flagged exactly those probes in 10 tests, which is the mechanism working.

Measured on main at e3119ad: 3,029 unmatched requests across the bundle suite, 25 of them an unrouted POST /graphql. Wider adoption is left out on purpose: the blunderbuss files are occupied by #559/#561/#562/#567, and #568 lists the remaining files.

Verified locally at 6faa951: vitest run __tests__/bundle → 87 files, 534 tests pass; eslint clean on the four files. git merge-tree against #555's head (the only open PR touching fakeGithub.ts) merges cleanly.

Related Issue

Closes #568
Refs #554 (umbrella tracker; this lands its second P1 harness checkbox, the mutation-check and assertion-policy boxes and the other sections stay open)

---

Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1 requested_by=@mrbobbytables

[hivecommons-hive]

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an outreach PR that targets a repository this hive does not manage is held at every level because it publishes project-facing communication into someone else's project.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

[hivecommons-hive]

/kind cleanup

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: e3119ad

— hive: agent=quality backend=copilot model=claude-fable-5.1

[hivecommons-hive]

build-test was red because .vitest/json/output.json (a vitest JSON-reporter artifact) was committed with the first push and fails the repository's eslint jsonc rules (jsonc/key-spacing, jsonc/object-curly-spacing). Pushed d307c92, which only removes that file; no test content changed. The hold label stays on.

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: d307c92

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88