[hivecommons-hive]

Test Improvement

failOnUnhandledRequest only rejects a request no handler serves; code under test that catches the rejection lets the test pass with the request silently unserved. This PR adds the missing end-of-test assertion for the unit suite and fixes the 158 tests (15 files) it exposed on main@e3119ad.

__tests__/testUtils.ts

• failTestOnUnhandledRequests(server): records msw's request:unhandled per test (listener re-attached in beforeEach, so an afterEach that calls server.events.removeAllListeners() cannot disarm it), fails in afterEach listing the requests; .allow() is the explicit per-test allowance for a deliberate probe; seen()/check() expose the state for the self-test.
• noMergeQueue: mergeQueueGraphql({ enabled: false }).handler, the isMergeQueueEnabled: false GitHub reports for a base branch without a merge queue.

__tests__/unhandledRequests.test.ts (new): pins the helper — a swallowed unserved request is recorded and fails check(), a served request and a deliberate Response.error() are not counted, allow() lasts one test, and the listener is re-armed after removeAllListeners().

58 msw-backed unit files (every file outside __tests__/bundle/ except plugins/tide.test.ts and cronJobTest/sweep.test.ts, see Related Issue): one line, utils.failTestOnUnhandledRequests(server), after setupServer(...).

What the assertion exposed, and how each is served now

• POST /graphql merge-queue state query, unserved in every tide/sweep/lgtm merge-path test and reaching the direct merge via readQueueState's warning fallback (src/utils/mergeQueue.ts:88-93) → utils.noMergeQueue as the file-level default in 11 files (cronJobTest/lgtm, issueCommentTest/approve, label/lgtm, issueCommentTest/trigger, cronJobTest/handleCronJob, plugins/approveReview, plugins/approveEvents, pullReqTest/onPrLgtm, cronJobTest/labelSync, plugins/requireMatchingLabel, utils/ownersAuth). queue?.enabled === true (src/plugins/tide.ts:194) is the only consumer, so the outcome is unchanged; only the fallback warning disappears.
• GET /branches/master, unserved and falling back to pull.base.sha (src/utils/pullRequestOwners.ts:83-86) → branchHandler() in the ownersAuth / pullRequestOwners tree-failure probes.
• trigger.test.ts "/test › refuses an outsider" → ...utils.noOrgOrRepoConfigExcept(), as its /retest sibling already has.
• ownersLabel.test.ts error probe → utils.defaultBranchTree() for the approve handler's concurrent OWNERS-presence read.

The fallback branches keep their dedicated tests (utils/mergeQueue.test.ts:116-124, plugins/tideMergeQueue.test.ts:261, utils/pullRequestOwners.test.ts:290); no .allow() was needed in the existing suite.

Coverage evidence

• Unit, npm run test:coverage on this branch: 168 files / 2336 tests pass, 99.92 % lines / 99.35 % branches / 100 % functions — identical to main@e3119ad.
• npm run lint: clean apart from the pre-existing src/issueComment/cc.ts:81 jsdoc warning on main.
• Preflight against the held PRs: no file overlap; git merge-tree with test(tide): pin the lgtm gate re-check after an unknown-mergeability retry (evaluateMerge, tide.ts:198-206) #557, test(sweep): pin the inclusive due-window bounds and the timeline-read failure of delayed reviewers #558, test(sweep): pin the delayed-reviewers OWNERS guard on a base branch without OWNERS files (sweep.ts:80) #561, test(sweep): pin the reviewer-key fallbacks of delayed blunderbuss on a bare pull listing (sweep.ts:208) #562, test(sweep): pin the delayed-reviewers catch of sweep in its Error and String(e) arms (sweep.ts:85) #565, test(sweep): pin the ignore_drafts=false arm of delayed reviewers (requestReviewersIfDue, sweep.ts:218) #566, test(sweep): pin the no-catch-up recovery of delayed reviewers after missed schedule runs #567 reports no conflict. New files those PRs add (sweepDelay*.test.ts, blunderbussDelay*.test.ts) create their own servers and are not wired here; a one-line follow-up can add them once they land. __tests__/bundle/ is untouched — that side is test(bundle): record the fake GitHub API's unmatched requests and assert on them outside the application #569.

Related Issue

Fixes #570 (remaining: wiring __tests__/plugins/tide.test.ts and __tests__/cronJobTest/sweep.test.ts, left untouched because held PRs #557 and #558 occupy those files — the hive refuses an overlapping-files PR; one-line follow-up once they land)
Refs #554 (umbrella: this is the unit-suite half of "Record unexpected API traffic and assert on it"; the bundle half is #569, the other sections stay open there)

---

Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@mrbobbytables

[hivecommons-hive]

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an outreach PR that targets a repository this hive does not manage is held at every level because it publishes project-facing communication into someone else's project.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

[hivecommons-hive]

/kind cleanup

---

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: e3119ad

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88