Skip to content

test(sweep): pin that a second delayed sweep leaves the first run's requested reviewers alone - #559

Closed
hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
quality/test-successive-sweeps
Closed

test(sweep): pin that a second delayed sweep leaves the first run's requested reviewers alone#559
hivecommons-hive[bot] wants to merge 1 commit into
mainfrom
quality/test-successive-sweeps

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Test Improvement

Adds one bundle scenario to __tests__/bundle/blunderbussDelay.test.ts (dist/index.js delayed blunderbuss): the sweep runs twice against a fake GitHub whose GET /pulls list reflects every POST …/requested_reviewers it has accepted so far. The second run must log sweep: #1 already has requested reviewers, make no further timeline or review reads, and leave exactly one reviewer request on record.

This is the Successive sweeps box of #554 ("run again against state updated by the first run … assert no duplicate or unwanted reviewer requests"). The manual-assignment half of that box is already pinned by the existing a manual reviewer / a manual team cases in the same file.

Cluster claimed: src/cronJobs/sweep.ts requestReviewersIfDue requested-reviewers guard, bundle level only. Disjoint from #555 (pagination), #557 (tide), #558 (__tests__/cronJobTest/sweep.test.ts due-window bounds); git merge-tree against #555 and #558 shows no conflict.

Verification

  • npx vitest run __tests__/bundle/blunderbussDelay.test.ts → 18/18 at aa71e9a
  • npx eslint __tests__/bundle/blunderbussDelay.test.ts clean
  • The regressors are requested() and reviewReads() staying at length 1 after the second run; removing the guard would make both 2.

Related Issue

Refs #554 — umbrella tracker; this closes only its successive-sweeps box. Remaining boxes (OWNERS page-two failure, outage recovery, CI enforcement, release) stay open, and the OWNERS page-two failure scenario waits on #555's fakeGithub header support landing.

Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5.1 requested_by=@mrbobbytables

@hivecommons-hive
test(sweep): pin that a second delayed sweep leaves the first run's r…
aa71e9a 
…equested reviewers alone

The delayed-blunderbuss bundle suite modelled a pull that already had
reviewers only as a static fixture. This drives dist/index.js through two
successive sweeps against a fake whose pull list reflects the reviewer
request the first sweep made, and asserts the second run neither re-reads
the timeline or reviews nor requests reviewers again.

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive
hivecommons-hive Bot requested a review from jpmcb as a code owner October 21, 2026 23:18
@hivecommons-hive hivecommons-hive Bot added the hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2026
@hivecommons-hive

hivecommons-hive Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an outreach PR that targets a repository this hive does not manage is held at every level because it publishes project-facing communication into someone else's project.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

This was referenced Oct 21, 2026
Open
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Merged
hivecommons-hive[bot]
hivecommons-hive Bot commented Oct 23, 2026
View reviewed changes

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against src/cronJobs/sweep.ts at merge-base. The scenario is sound and pins the right guard:

  • The second-sweep skip is the requested-reviewers check at sweep.ts:208-211, which runs before any timeline or review read in requestReviewersIfDue, so reviewReads() and timelineReads() staying at length 1 after the second run is exactly what the guard guarantees — the regressors are real (removing the guard would double both).
  • The stateful GET /pulls route that reflects accepted requested_reviewers POSTs is the correct way to model GitHub between sweeps; it exercises the production path rather than a canned second listing.
  • The asserted log line sweep: #1 already has requested reviewers is the literal core.debug at sweep.ts:209, which the toolkit emits as a ::debug:: line on stdout regardless of runner debug settings, so the stdout assertion holds in the bundle run.

Not a duplicate of #558: that PR pins the due-window bounds in the unit suite (__tests__/cronJobTest/sweep.test.ts); this one pins the idempotence guard at bundle level in a different file. Test-only, CI green. Looks correct to me.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

hivecommons-hive[bot]
hivecommons-hive Bot commented Oct 23, 2026
View reviewed changes

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against src/cronJobs/sweep.ts at merge-base. The scenario is sound and pins the right guard:

  • The second-sweep skip is the requested-reviewers check at sweep.ts:208-211, which runs before any timeline or review read in requestReviewersIfDue, so reviewReads() and timelineReads() staying at length 1 after the second run is exactly what the guard guarantees — the regressors are real (removing the guard would double both).
  • The stateful GET /pulls route that reflects accepted requested_reviewers POSTs is the correct way to model GitHub between sweeps; it exercises the production path rather than a canned second listing.
  • The asserted log line sweep: #1 already has requested reviewers is the literal core.debug at sweep.ts:209, which the toolkit emits as a ::debug:: line on stdout regardless of runner debug settings, so the stdout assertion holds in the bundle run.

Not a duplicate of #558: that PR pins the due-window bounds in the unit suite (__tests__/cronJobTest/sweep.test.ts); this one pins the idempotence guard at bundle level in a different file. Test-only, CI green. Looks correct to me.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

/kind cleanup

🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5q9t | SHA: e3119ad

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind labels Oct 23, 2026
@mrbobbytables mrbobbytables mentioned this pull request Oct 26, 2026
Merged
12 of 13 tasks
@mrbobbytables

mrbobbytables commented Oct 26, 2026

Copy link
Copy Markdown
Member

Consolidated into #589 (commit cherry-picked unchanged, author and DCO sign-off preserved).

mrbobbytables added a commit that referenced this pull request Oct 26, 2026
@mrbobbytables @hivecommons-hive
test: pin the delayed-blunderbuss and paginated-OWNERS contracts (con…
bc6e6b4 
…solidates #555, #558, #559, #561, #562, #564-#567) (#589)

* test: cover paginated OWNERS and review timelines

Exercise approval authorization, automatic reviewer selection, and delayed reviewer timing across page boundaries.

Hive-Run: #554

Hive-Plan: P2 cross-request contracts

Hive-Spec: issue-554#P2-cross-request-contracts

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>

* test(sweep): pin the inclusive due-window bounds and the timeline-read failure of delayed reviewers

Add four cases to the 'sweep with blunderbuss.delay' block of
__tests__/cronJobTest/sweep.test.ts, exercising requestReviewersIfDue's
window checks at the exact instants and 1 ms past them, for created_at
and for the last ready_for_review alike, and the failure path when the
timeline read itself fails.

Each boundary case fails on a one-character mutant of sweep.ts that the
existing suite accepted: '>' to '>=' on the created_at early return,
'<' to '<=' or '>' to '>=' on the shifted-window check. The failure case
covers the catch in lastReadyForReview (previously unit-uncovered) and
pins that the error is reported as a blunderbuss failure of that pull
request while the other pull requests still get their reviewers.

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(sweep): pin that a second delayed sweep leaves the first run's requested reviewers alone

The delayed-blunderbuss bundle suite modelled a pull that already had
reviewers only as a static fixture. This drives dist/index.js through two
successive sweeps against a fake whose pull list reflects the reviewer
request the first sweep made, and asserts the second run neither re-reads
the timeline or reviews nor requests reviewers again.

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(sweep): pin the delayed-reviewers OWNERS guard on a base branch without OWNERS files

Both suites left the false arm of the branchHasOwners guard ahead of
requestReviewersIfDue in src/cronJobs/sweep.ts with zero hits: every
delayed-blunderbuss case served an OWNERS file on master. Add one unit case
and one dist/index.js scenario, each in its own file, that configure
blunderbuss.delay, serve an empty master tree and a due pull request, and
assert the tree is probed once while the timeline, reviews and
requested_reviewers endpoints are never touched. Both fail when the guard is
replaced by `|| true`.

Fixes #560

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(sweep): pin the reviewer-key fallbacks of delayed blunderbuss on a bare pull listing (sweep.ts:208)

requestReviewersIfDue reads requested_reviewers ?? [] and
requested_teams ?? [] off the pull list entry, but no unit or bundle test
listed a delayed-only pull request without those keys, leaving both
fallback arms unreached in coverage/ and coverage-e2e/. Serve a due pull
with the keys removed on both harnesses and assert reviewers are still
requested.

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(owners): pin the fail-closed OWNERS group read when a later members page cannot be fetched (owners.ts:153-162)

Let the real octokit paginator walk a team's Link headers instead of the
stubbed paginate the existing group tests use. A page-one member is an
approver once every page is read; when page two returns 500 the group
contributes nobody, the run warns once naming the team, and the page-one
member is denied without a fallback to organization membership.

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(sweep): pin the delayed-reviewers catch of sweep in its Error and String(e) arms (sweep.ts:85)

Adds __tests__/cronJobTest/sweepDelayFailures.test.ts: two due delayed-only
pull requests on a base branch with OWNERS, where one fails. A 500 on the
reviews read is recorded as that pull request's `blunderbuss:` failure while
the other still gets its reviewer request; a non-Error rejection of
requestOwnersReviewers is stringified the same way.

Before: coverage/lcov.info BRDA:85,5,0,0 / BRDA:85,5,1,0 (neither arm hit by
the unit suite). After: both 1; sweep.ts branches 92.3 -> 94.87 %.

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(sweep): pin the ignore_drafts=false arm of delayed reviewers (sweep.ts:218)

With blunderbuss.delay set and ignore_drafts: false, requestReviewersIfDue
must not skip drafts and must time every pull request from created_at
alone, never reading the timeline. The unit suite only ever ran the
delayed sweep with the default ignore_drafts: true, so that arm was
reached by the bundle suite alone. Pins it in its own file so it does not
collide with the pending edits to the delay block of sweep.test.ts.

Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(sweep): pin the no-catch-up recovery of delayed reviewers after missed schedule runs

After the schedule misses runs for longer than sweep.lookback, a pull
request whose review clock expired before now - delay - lookback is
neither listed, read nor requested by the delayed-reviewers step, and a
longer sweep.lookback is what recovers it. Pinned in a unit suite
(__tests__/cronJobTest/sweepDelayOutage.test.ts) and against
dist/index.js (__tests__/bundle/blunderbussDelayOutage.test.ts); the
blunderbuss.delay paragraph of docs/configuration.md now records the
expectation.

Refs #554

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>

* test(harness): fail tide and sweep unit tests on unserved requests

Completes the #571 wiring that was deferred while #557 and #558 occupied
these files: both servers now answer the merge-queue read with
noMergeQueue and assert at the end of each test that no request went
unserved; sweep's OWNERS scenarios serve the base-branch tip instead of
running through the 'could not read the tip' fallback.

Refs #570

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>

---------

Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
Co-authored-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@mrbobbytables mrbobbytables mentioned this pull request Oct 26, 2026
Closed
11 of 22 tasks
@mrbobbytables
mrbobbytables deleted the quality/test-successive-sweeps branch October 26, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpmcb jpmcb Awaiting requested review from jpmcb jpmcb is a code owner

Assignees

No one assigned

Labels

hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mrbobbytables