Repository navigation
chore(coverage): raise the e2e branch floor to 98 after the pending coverage work landed - #556
Conversation
…overage work landed Measured npm run test:coverage:e2e on main@e3119ad with #528, #537, #544, #548 and #549 merged: 100 / 99.46 / 100 / 100 (1686/1695 branches). The 97 floor set at 1062ce7 (97.96 measured) now sits 2.46 pp under main; 98 keeps the same just-under-main convention. 99 was considered and not taken: it would leave 8 branches of slack, two of which are already consumed by the negative-count await artifacts at approve.ts:504 and auth.ts:220 that no test can recover. Closes #551 Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive
Bot
added
the
hold
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Read against main@e3119ad. This looks correct to me.
vitest.e2e-coverage.config.mjs: only thebranches: 97 → 98threshold and its baseline comment change; the other three floors are untouched. The PR's owne2e-coveragecheck ran green at the new floor, which independently confirms main's measured branches clear 98.docs/contributing.md:50: thetest:coverage:e2erow's "97 % branches" updated to 98 to match — docs and config stay in step.- The added comment is honest about what the floor does ("bounds drift, does not detect one-branch regressions"), which addresses the ambiguity #551 raised rather than papering over it.
No findings. Two-file, config-plus-docs change; nothing else to verify.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
|
/kind cleanup 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
github-actions
Bot
added
kind/cleanup
mrbobbytables
removed
the
hold
Summary
Re-evaluates the
npm run test:coverage:e2ebranch floor as #551 asks, now that #528, #537, #544, #548 and #549 are all merged.Measured baseline —
npm run test:coverage:e2eonmain@e3119ad(local run, 86 files / 528 tests): 100 % lines / 99.46 % branches / 100 % functions / 100 % statements, 1686/1695 branches. The 9 remaining misses aresweep.ts:80,85,208,auth.ts:15-17(held PR #553),config.ts:618, and the two negative-count await artifactsapprove.ts:504/auth.ts:220already documented indocs/contributing.md.Decision: raise to 98. The 97 floor was set at 1062ce7 when main measured 97.96; it now sits 2.46 pp below main. 98 keeps the repo's just-under-main convention. 99 was considered and not taken: it would leave 8 branches of slack, 2 of which are permanently consumed by the phantom negatives, so ordinary additive changes could trip it without any scenario regressing. As the issue notes, a one-branch loss (~0.06 pp) does not cross a whole-percentage floor; the config comment now says so explicitly rather than implying detection.
Files
vitest.e2e-coverage.config.mjs—branches: 97→98, baseline comment updateddocs/contributing.md— thetest:coverage:e2erow's figure updated to matchVerification
npx vitest run --coverage --config vitest.e2e-coverage.config.mjs __tests__/bundlepasses at the new floor (99.46 ≥ 98)npm run lint -- vitest.e2e-coverage.config.mjscleanUnit and bundle reports were not merged, per the issue.
Closes #551
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@mrbobbytables