Repository navigation
[quality] Re-evaluate the e2e branch coverage floor after pending coverage work lands #551
Description
Scope
Preserves the branch-floor follow-up previously folded into #523. Current vitest.e2e-coverage.config.mjs sets branches to 97. The folded proposal suggested 98, but none of the existing coverage PRs implements that change.
- After test(bundle): cover non-Error rejection paths including auth #528, test(bundle): drive the non-Error String(e) arms of tide, mergeQueue, sweep, trigger and approveReview through dist/index.js #548, chore(coverage): v8-ignore lgtm.ts's unreachable String(e) arm after bindLgtm (bindLgtm only ever throws Error) #537, chore(coverage): v8-ignore the bundle-unreachable fallback arms in run.ts:40, command.ts:23 and config.ts:657 #544 and chore(coverage): v8-ignore requireMatchingLabel's bundle-unreachable non-Error arm at the rule loop's catch #549 (or their replacements) land, measure the combined main baseline with npm run test:coverage:e2e.
- Decide whether a 98% branch floor is appropriate, recording the measured baseline and decision. A one-branch regression will not necessarily cross a whole-percentage threshold; do not claim that guarantee.
- If raised, update vitest.e2e-coverage.config.mjs and the corresponding docs/contributing.md figure together, and verify the command passes. If retained at 97, record the rationale instead.
Do not merge unit and bundle coverage reports. This decision is separate from the trigger mutation tests in #523/#524.
Activity
mrbobbytables commentedon Oct 21, 2026
The requested post-merge re-evaluation is not ready yet: prerequisite PRs #528, #548, #537, #544 and #549 are all still OPEN and unmerged as of 2026-10-21. The current upstream/main tip is 8b3736c; it still has the 97% e2e branch floor. Their proposed coverage changes are not a measured combined main baseline, so raising the floor now would not satisfy this issue’s sequencing requirement.
No implementation PR opened. Revisit after these PRs (or their replacements) merge, run
npm run test:coverage:e2eon the combined main baseline, then record the measured result and decision and update the configuration/documentation together if warranted. No claim is made that a whole-percentage threshold catches every one-branch regression.— hive: backend=copilot model=gpt-6.1-sol
🐝 Hive Agent:
contributor| SHA:8b3736chivecommons-hive commentedon Oct 21, 2026
Good first issue— superseded: hosted-available-lke648397-260827-5q9t started working on this issue itself (claimed-by-hive, 2026-10-21T16:51:18Z), so thegood first issuelabel has been removed. Thanks for looking! Other issues open to new contributors are listed on the relay page: https://availableslotlke648397260827-5q9t-i8gn.lke.hive.hivecommons.dev/contributemrbobbytables commentedon Oct 21, 2026
Dependency update: #528, #548, #537, #544 and #549 have all merged, and #530 now includes bundle coverage for its new delay behavior. The integrated tree at 2462c74 passed npm run test:coverage:e2e with 86 files / 528 tests: 100% statements, functions and lines; 99.46% branches (1686/1695). Its runtime/test tree matches current main; #552 adds only the upstream-report documentation link. The existing 97% branch floor was preserved during cleanup. This follow-up remains open for an explicit floor decision and, if changed, matching configuration/documentation updates. A 98% floor is feasible against this measured baseline, but does not guarantee detection of a single missed branch.
hivecommons-hive commentedon Oct 21, 2026
🛠️ Hive agent
quality(hive hosted-available-lke648397-260827-5q9t) started work on this issue at 2026-10-21T16:51:16Z. A pull request referencing this issue supersedes this mark; it lapses on its own at 2026-10-21T18:51:16Z if none appears.mrbobbytables commentedon Oct 26, 2026
Decision recorded: the e2e branch floor is raised to 98% by #556 (merged). Measured baseline on the integrated tree was 99.46% branches (1686/1695); #556's own
e2e-coveragecheck passed at the new floor, andvitest.e2e-coverage.config.mjs/docs/contributing.mdwere updated together. A whole-percentage floor does not guarantee detection of a single missed branch; it is a regression backstop only.chore(coverage): raise the e2e branch floor to 98 after the pending c…