Repository navigation
chore(coverage): v8-ignore requireMatchingLabel's bundle-unreachable non-Error arm at the rule loop's catch - #549
Conversation
…non-Error arm Every await in apply() rewraps its rejection in new Error, so the e instanceof Error ? e.message : e fold at the rule loop's catch can only take its Error arm from dist/index.js. Mark the alternate with /* v8 ignore next */, the form config.ts already uses, so the e2e lane stops reporting a branch no bundle input can reach. The unit test that drives the arm stays. dist/ repacked (comment lines only). Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
|
Please add a kind label with |
mrbobbytables
left a comment
There was a problem hiding this comment.
Copilot review performed under the maintainer's explicit authorization to update, review, release reviewed holds, and merge eligible PRs in this cleanup.
Every awaited operation in apply wraps failures as Error before the rule-loop catch. The hint targets the primitive alternate only and retains the live Error arm and existing unit assertion.
Verified successful build-test, e2e-coverage and DCO results on head 839630c. Any folded issue findings remain assigned to the canonical destinations in the updated scope tables.
…overage work landed (#556) Measured npm run test:coverage:e2e on main@e3119ad with #528, #537, #544, #548 and #549 merged: 100 / 99.46 / 100 / 100 (1686/1695 branches). The 97 floor set at 1062ce7 (97.96 measured) now sits 2.46 pp under main; 98 keeps the same just-under-main convention. 99 was considered and not taken: it would leave 8 branches of slack, two of which are already consumed by the negative-count await artifacts at approve.ts:504 and auth.ts:220 that no test can recover. Closes #551 Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Coverage annotation
npm run test:coverage:e2eonmain@ 88241f4 reports one zero-hit branch that no open held PR names:src/plugins/requireMatchingLabel.tsBRDA:167— the: earm of${rule.missing_label}: ${e instanceof Error ? e.message : e}inrequireMatchingLabel()'s per-rulecatch. #548 identified it as bundle-unreachable and left it out of scope. This marks it with/* v8 ignore next -- … */, the formsrc/utils/config.ts:657takes in #544 andsrc/utils/config.ts:219already uses onmain. No behaviour change; the unit test that drives the arm stays.dist/repacked (comment lines only).src/plugins/requireMatchingLabel.tsBRDA:167catch: the non-Errorarmawaitinapply()rewraps its rejection innew Error(...)first:labelIssue(labeling.ts:66),removeLabels(labeling.ts:185),createComment(comments.ts:34),botCommentsWithMarker(requireMatchingLabel.ts:245) anddeleteMissingComments(requireMatchingLabel.ts:233).evaluate,sameLabelandmarkerForare pure.Placement: the hint sits on the alternate operand of the
?:, so theErrorarm stays measured. The unit lane keeps driving the alternate directly:reports a non-Error rejection from a rule verbatim(__tests__/plugins/requireMatchingLabel.test.ts:407) spieslabeling.labelIssueto reject with the string'rate limited'.Files / functions claimed:
src/plugins/requireMatchingLabel.ts(requireMatchingLabel, the per-rulecatch),dist/index.js. Disjoint insrc/from every open held PR: #510 isauth.ts, #537 islgtm.ts, #544 isrun.ts/command.ts/config.ts, #530 issweep.ts/blunderbuss.ts/config.ts; #520 touches only__tests__/plugins/requireMatchingLabel.test.ts.dist/index.jsis shared with #510, #537 and #544;git merge-tree --write-tree HEAD pr-510|pr-537|pr-544|pr-520exits 0 for each (no textual conflict).Verification (this branch, local)
npm run build && npx eslint src/plugins/requireMatchingLabel.ts && npm run pack: clean;dist/index.jsdiff is the three comment linesnpm run test:coverage:e2e: 83 files / 502 tests pass;coverage-e2e/lcov.infonow carries onlyBRDA:169,23,0,2for this site (no zero-hit record); branches 1636/1656 (98.79 %) → 1636/1655 (98.85 %)npm run test:coverage: 163 files / 2206 tests pass, 100 % lines / 99.75 % branches (1651/1655), thresholds metRelated Issue
None supplied for this kick; this PR is the finding and the fix for the one branch it names.
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88