Skip to content

chore(coverage): v8-ignore requireMatchingLabel's bundle-unreachable non-Error arm at the rule loop's catch #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrbobbytables merged 1 commit into from
Oct 21, 2026
Merged

chore(coverage): v8-ignore requireMatchingLabel's bundle-unreachable non-Error arm at the rule loop's catch #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45227,7 +45227,9 @@ async function enforceRequiredLabels(octokit, context, target, options = {}) {
await apply(octokit, context, issueNumber, rule, labels);
}
catch (e) {
errors.push(`${rule.missing_label}: ${e instanceof Error ? e.message : e}`);
// every await in apply() rewraps its rejection in new Error (labelIssue, removeLabels, createComment,
// botCommentsWithMarker, deleteMissingComments), so only an Error reaches this catch from the bundle
errors.push(`${rule.missing_label}: ${e instanceof Error ? e.message : /* v8 ignore next -- non-Error arm unreachable from dist/index.js; requireMatchingLabel.test.ts drives it */ e}`);
}
}
if (errors.length > 0) {
Expand Down
4 changes: 3 additions & 1 deletion src/plugins/requireMatchingLabel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,9 @@ export async function enforceRequiredLabels(octokit: Octokit, context: Context,
await apply(octokit, context, issueNumber, rule, labels)
}
catch (e) {
errors.push(`${rule.missing_label}: ${e instanceof Error ? e.message : e}`)
// every await in apply() rewraps its rejection in new Error (labelIssue, removeLabels, createComment,
// botCommentsWithMarker, deleteMissingComments), so only an Error reaches this catch from the bundle
errors.push(`${rule.missing_label}: ${e instanceof Error ? e.message : /* v8 ignore next -- non-Error arm unreachable from dist/index.js; requireMatchingLabel.test.ts drives it */ e}`)
}
}

Expand Down
Loading