Repository navigation
[Feat] Add on-demand connection tests for custom MCP servers - #3655
Merged
daniel-lxs merged 2 commits intoNov 3, 2026
Merged
Conversation
Contributor
|
No new code issues found. The prior finding is fixed: connection tests now await the server-keyed fetch, and regression coverage checks both opposite-outcome switches. An isolated TanStack Query probe confirmed that each fetch retains its original outcome after switching observers. Lint, type-check, docs, Knip and CodeQL checks passed; tests and the app build were still running when checked. See session
Reviewed 16df38e |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
November 3, 2026 05:54
This was referenced Nov 3, 2026
daniel-lxs
approved these changes
Nov 3, 2026
daniel-lxs
left a comment
Member
There was a problem hiding this comment.
Reviewed head 16df38e. The connection-test race is addressed by awaiting the original server-keyed fetch, with regression coverage for both opposite outcomes. All review feedback is addressed and required checks pass.
daniel-lxs
deleted the
feature/custom-mcp-connection-test-0skzokh2jrws0
branch
November 3, 2026 14:02
Merged
8 of 12 tasks
5 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal product improvement; no separate issue.
Why this PR exists
What changed
Add Test connection inside a saved custom remote MCP server's Manage tools dialog. It explicitly fetches fresh tool metadata and reports named success/failure, including a valid empty catalog. Previously there was no successful-dialog retest action, and reopening could reuse cache.
Reuse the existing authorized, credential-aware, SSRF-guarded endpoint. Pending requests coalesce; testing does not execute tools or change enablement/approval choices. No new endpoint, persistent state or dependency. Public docs explain the remote-metadata scope and stdio limitation.
How it was tested
fb5e231d: genuine public DeepWiki catalog loads three schemas but has no Test action; the fresh-cache regression fails for that missing capability.16df38eebd20e795784579e96d98f474ccb33b4crepairs the review-found observer race by awaiting the captured server-keyed fetch. Both opposite-outcome regressions fail before repair and pass after it. 37 client + 21 server command tests, web types, docs build/links/render and actual commit/pre-push gates pass. Full local suite not run.Screenshots
Genuine local app and public schemas, with disclosed delayed/aborted transport for negative cases. Latest final-head evidence replaces earlier captures.
Related PRs
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally — normal broad fast equivalents and actual hooks passedpnpm changeset— no changeset added