Repository navigation
[Fix] Custom skill edits disappear when an earlier save completes - #3651
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See session Reviewed the pending-state guards, shared/environment creation, retained drafts and corrected retries, and regression tests. Current-head lint, type checks, and Knip passed; tests, app build, and JavaScript/TypeScript CodeQL were still running when checked. Reviewed 28acf05 |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
November 3, 2026 05:16
This was referenced Nov 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal product recovery work; no separate issue.
Why this PR exists
What changed
Add Custom Skill accepted Description and Content edits after Save began. A successful response then closed and reset the dialog, discarding those later edits while persisting only the submitted values. Disable those two fields while saving, matching the existing Slug, availability and edit-skill form behavior. On failure the retained draft becomes editable again for correction and retry.
Two existing
isSavingguards; no new state, API, dependency or visible control. Shared and environment-specific creation use the same pending state. Normal pre-save editing and successful creation remain unchanged.How it was tested
fb5e231d: actual authenticated mobile dialog, real create mutation held at a disposable PostgreSQL lock. Description and Content accepted later typing; release produced success/reset and persisted only the original text. New pending assertions fail in three cases before the production edit.28acf054f5f7abc94e4e87399e1799909bf965be: same real lock/create/keyboard stimulus rejects later text, then persists submitted values after release. Desktop 1440×1000 and mobile 390×844 interactions verified; committed patch is byte-identical to the visually inspected snapshot.Screenshots
Real local app, synthetic form data. Pending duration uses a disposable database lock; recovery follows a disclosed aborted create request. The recovery image was taken after the toast expired and does not show the failure itself.
Related PRs
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally — normal broad fast equivalents and actual hooks passedpnpm changeset— small form consistency fix; no changeset