Repository navigation
[Fix] Automation edit actions are indistinguishable in assistive navigation - #3652
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See session Reviewed all five changed files, shared summary-row consumers, and desktop/mobile model-trigger composition. The contextual names preserve visible button text, explicit action labels, and custom action slots. CI lint and type checks passed; tests, Docker build, and JavaScript/TypeScript CodeQL were still running when checked. No local validation suites were run. Reviewed 7b2f63b |
5 of 8 tasks
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
November 3, 2026 05:29
5 of 8 tasks
5 of 8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal accessibility work; no separate issue.
Why this PR exists
What changed
The custom automation dialog exposed five indistinguishable “Edit” buttons to assistive navigation. Name each target: Edit Schedule, Edit Priority, Edit Environment, Edit Model and Edit Destination. Default shared setting-summary actions derive the name from their existing row label, so built-in schedule/webhook and scheduling-timezone actions gain the same context. Explicit action labels and custom action slots retain their current contract.
Two accessible-name attributes and existing consumer-test selector updates. Visible Edit copy stays compact; no new UI, state, dependency or persistence behavior. This lets users select the intended setting by its accessible name.
How it was tested
fb5e231d: actual mobile New custom automation accessibility snapshot and DOM show five bare Edit actions. On the shipped tree each has its setting name; native desktop1440×1000 Enter on Edit Priority opens Priority, mobile390×844 Enter on Edit Model opens Models, and Escape restores focus to Edit Model with unsaved Name/Prompt retained.7b2f63bc5872bd6decb1baff153fbd9599a48fc6is byte-identical to the proof snapshot. Screenshots prove layout only; native accessibility snapshots and interactions establish names/activation. No real screen-reader/device or live automation-execution claim.Screenshots
Genuine authenticated local app and unsaved synthetic draft; no response/DOM mocks or temporary source changes. These frames do not show accessible names or certify persistence.
Related PRs
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally — normal broad fast equivalents and actual hooks passedpnpm changeset— accessible-name consistency; no changeset