Skip to content

[Docs] Clarify Slack destination discovery and current-conversation replies - #3669

Draft
roomote-community[bot] wants to merge 1 commit into
developfrom
fix/docs-slack-discovery-0is9zhbf0h2n0
Draft

roomote-community[bot] wants to merge 1 commit into
developfrom
fix/docs-slack-discovery-0is9zhbf0h2n0

Conversation

@roomote-community

Copy link
Copy Markdown
Contributor

​Opened on behalf of @mrubens. Follow up by mentioning @roomote, in the web UI, or in Discord.

Related issue

Daily docs accuracy audit for 2026-11-04T03:00:36.618Z through 2026-11-05T03:00:36.618Z; no linked issue.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Clarify in the session and Slack guides that standalone Slack destination lookup lists public channels the app has joined, excludes private channels, and is separate from replying in the current conversation or an automation's configured report channel. An absent private channel is not evidence that Slack access was lost.

The window's Slack explanation fix (#3646, 37aa060) exposes the distinction already enforced by discoverSlackChannels on shipped main/v1.20.0 (d2390b12). The docs previously implied broader discovery. This is a docs-only correction, with no runtime or permissions change.

Checked six develop merges plus the main promotion in the exact window. The default branch is develop (57aa1a2e); the published release is v1.20.0/main (d2390b12, released 2026-11-04T15:14:47Z). The Slack and Copilot helper fixes are develop-only. MCP client management/revocation (#3657) already includes its settings, upgrade, Redis, and rollback guidance. The promotion also first ships connection testing (#3655) and task safety stops (#3658), already covered in their feature docs. Dependency patches #3625/#3649 require no new setup instructions.

Open docs PRs were checked for overlap, including the actual Slack diff in #3647 and provider fixes in #3594; neither covers this discovery distinction. Pending unrelated corrections remain separate.

How it was tested

  • mise exec -- pnpm --filter @roomote/docs check-cookbook-index passed: seven recipes current.
  • mise exec -- pnpm --filter @roomote/docs check passed: pinned Mintlify build validation and no broken links.
  • Opened both changed pages in the real local Mintlify browser preview and confirmed the new text rendered. The initial preview failed because validation removed generated preview props; restarting the existing preview process restored both pages. No screenshots or simulated evidence are claimed; browser proof was classified unnecessary for this semantic correction.
  • git diff --check passed. Normal pre-push checks passed: oxlint, web/worker residual ESLint, all 27 fast typecheck tasks, and Knip.
  • The pre-commit judgement hook permitted the commit but marked two prose rules incomplete because its provider/evidence evaluation was unavailable. This is not a full judgement pass. Full Vitest, formatting-inclusive pnpm lint / pnpm check-types, and live external Slack/OAuth journeys were not run for this docs-only change.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
    • Normal fast pre-push gates and docs-specific validation passed; full formatting-inclusive commands were not run.
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset
    • Docs-only correction; no changeset needed.

@roomote-community

roomote-community Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor Author

No code issues found. See session

Reviewed both documentation pages against public-only Slack destination discovery and current-conversation/automation reply handling. CI docs validation, tests, lint, type checks, and Knip passed; Docker and JavaScript/TypeScript CodeQL checks were still running at review time.

Reviewed 1b56165

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant