Repository navigation
Fix source contracts and cross-platform validation failures - #1604
Merged
Merged
Conversation
gmh5225
marked this pull request as ready for review
October 21, 2026 07:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cached no-return lookup could disagree with live image ownership, synthetic object tail callees were rejected as non-executable, and exception parents without an ordinary RETURN could lose their catch result by being classified as void. This change preserves those contracts at their shared owners and fixes the cross-platform failures exposed during performance qualification.
Linux Release validation: full Lift 7,489 passed, zero failures; 34 Darwin-native cases require macOS. LibC 71/71, session 193/193 with matching optional inputs, pipeline 49/49, return contracts 21/21, HighControlFlow 430/430, store forwarding 28/28, worker/allocator 47/47. Swift and real AArch64 parity coverage were enabled. Format, documentation and 51 CI policy tests pass. Native Linux and Windows clang-cl artifacts confirm the critical owners without skips in both scheduler configurations. For MSVC-built SDKs, generated-C execution fixtures select Clang, matching the native unit fixtures; this validates the SDK and emitted semantics without claiming that every Clang C extension compiles directly with cl.exe.
Qt 6.8.3 Release: all 23 GUI/worker CTests pass locally on the final lifetime fix, including the unchanged search and Unicode drag/drop assertions. The late-output MCP regression first failed locally, then passed 20 complete repetitions. The prior shutdown failure was reproduced as a use-after-free under ASan. The exact bookmark and translation cases pass after the lifetime fix; the offscreen focus regression also passes in eight separate ASan processes. The complete ASan controller run passes all 192 cases with no sanitizer reports. Windows offscreen CI explicitly loads the system font directory: a font-free local run reproduces its exact 407-versus-612 width failure, and real fonts satisfy the unchanged assertion. All 11 catalogs compile with 1,154 matching source keys, placeholders and unique menu access keys.
The comparison engine is now the supplied IDA 9.5 Beta1 (kernel 9.5, build 261001). Seven frozen input images use identical explicit address lists: 3,198 requests, 2,977 common successes, with all refusals retained (8 NeverD; 213 IDA). NeverD leads in six of seven common-success warm decompile aggregates. Three fresh sequential pairs confirm Android32 remains 16.8% slower by median, while MSVC x64 is 3.7% faster by median. The library open, analysis, warmup and full-request total is lower for NeverD on all seven images. Startup, memory, individual times and errors are recorded separately; the total-path measure is not GUI startup. This replaces the previous IDA 9.4 comparison claim. A 2,298-request source comparison retains the success/refusal sets; only three return signatures change to conservatively retain unknown values.
Current-head native macOS, Windows and remaining CI qualification are in progress.