Repository navigation
Retire stale discovery jobs, test the heartbeat guard, skip non-Clang runs of engine C - #1624
Merged
Merged
Conversation
The engine's C is Clang's dialect. It writes exact floating-point constants with __builtin_bit_cast, and calls a declared function through a cast to its call site's own type, such as an ms_abi variadic one; GCC lacks the builtin and folds such a cast into a call with the declared ABI, which made the Win64 LLVMC route crash. NeverDWorkerCallSiteTypes now checks for Clang once, still runs every analysis check, and reports the routes it could not execute as a skip (77) instead of failing or passing on them.
A discovery job outlived its image when the next one had no native discovery: the early answer for EVM or SBF never reached the job, which kept its result, and its image after a failure, until the session ended. Retire a finished stale job when a load completes and on every discovery call, before any early answer; a running one is still not waited for.
The heartbeat guard from #1622 had no test because the worker's stale interleaving cannot be forced. Give the session the same-build test seam the SDK session uses, deliver a heartbeat as the worker connection does, and check that the previous project's state, discovery completion included, is ignored while the current project's is applied. It fails without the guard.
Contributor
Author
|
Local verification on 76b5748 (Linux x64, Release; engine with clang 23, GUI project with GCC 15 and Qt 6.8.3):
Hosted runs on this branch: CI 39620265477, Desktop GUI 39620271511, Native pipeline compatibility 39620277527. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the gaps left after #1622.
DiscoveryStepsRetireAnEarlierImagesFinishedJobcovers a job still running at the load, one already finished, and synchronous discovery; all three fail without the change.tests/SessionTestAccess.h, a friend that delivers a message as the worker connection does).heartbeatsOfAnotherProjectLeaveTheSessionAlonechecks that the previous project's heartbeat, discovery completion included, is ignored and the current project's is applied. It fails without the guard.__builtin_bit_cast, it calls a declared function through a cast to its call site's own type, such as anms_abivariadic one; GCC 15 folds that cast into a call with the declared SysV ABI, so the Win64 LLVMC route crashed under GCC, while Clang emits the MS convention.NeverDWorkerCallSiteTypesnow checks for Clang once, still runs every analysis check, and reports the routes it could not execute as a skip (77). Builds with Clang available already use it (Fix source contracts and cross-platform validation failures #1604, Close remaining dev gaps: stale project heartbeats, GCC worker C compiler, search-jump test, formatting #1622).Local verification (Linux x64, Release; engine with clang 23, GUI project with GCC 15 and Qt 6.8.3): see the comment below.
CI,Desktop GUIandNative pipeline compatibilityare dispatched on this branch for Windows, macOS and Linux; those runs are keyed to the branch, so they finish independently of this PR.